Skip to content

fix(ci): run xarray's backend tests from their new package - #4491

Merged
d-v-b merged 2 commits into
zarr-developers:mainfrom
d-v-b:fix/downstream-xarray-test-layout
Oct 8, 2026
Merged

d-v-b merged 2 commits into
zarr-developers:mainfrom
d-v-b:fix/downstream-xarray-test-layout

Conversation

@d-v-b

@d-v-b d-v-b commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

this fixes the xarray downstream tests by adapting to the current state of xarray

🤖 AI text below 🤖

The downstream xarray CI job now runs the xarray/tests/backends package. pydata/xarray#11633 split xarray/tests/test_backends.py, test_backends_api.py and test_backends_datatree.py into that package, so the job failed to collect any tests (see the failing run).

Running the package covers the same tests the three old modules held: the zarr store, region and append tests (test_zarr.py), the engine-agnostic API tests (test_api.py) and the DataTree tests (test_datatree.py), plus the netCDF4, h5netcdf and scipy backend tests that were in test_backends.py and ran before because the io extra installs those backends. It also picks up the small modules that were never selected before (test_chunks.py, test_common.py, test_file_manager.py, test_locks.py, test_lru_cache.py, test_plugins.py).

The run-downstream label is set so the job runs on this PR.

Verification

The run-downstream label triggered the Downstream workflow on this PR: run 37808680079 collected and ran the package against xarray main (4929aa90f) with the branch zarr installed (3.4.1.dev74+g67939032):

3368 passed, 223 skipped, 45 xfailed, 4 xpassed in 106.73s

The numcodecs job in the same run passed as well. The agent also reproduced the install steps locally (xarray main, --group dev ".[io,parallel,accel]", branch zarr with --no-deps) and collected 3640 tests from the package.

Author attestation

  • I am a human, these are my changes, and I have reviewed and understood every change and can explain why each is correct.

TODO

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.md
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

🤖 Generated with Claude Code

pydata/xarray#11633 split xarray/tests/test_backends.py and the other
test_backends*.py modules into the xarray/tests/backends package, so the
downstream job failed to collect any tests. Run the package instead.

Assisted-by: ClaudeCode:claude-fable-5-1

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@d-v-b d-v-b added the run-downstream Run the tests of downstream libraries (e.g., xarray) against zarr label Oct 8, 2026
@github-actions github-actions Bot added the needs release notes Automatically applied to PRs which haven't added release notes label Oct 8, 2026
Assisted-by: ClaudeCode:claude-fable-5-1

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@github-actions github-actions Bot removed the needs release notes Automatically applied to PRs which haven't added release notes label Oct 8, 2026
@d-v-b
d-v-b marked this pull request as ready for review October 8, 2026 16:42
@d-v-b

d-v-b commented Oct 8, 2026

Copy link
Copy Markdown
Contributor Author

self-merging b/c tests (including the downtream tests) are working correctly

@d-v-b
d-v-b merged commit bb17a80 into zarr-developers:main Oct 8, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-downstream Run the tests of downstream libraries (e.g., xarray) against zarr

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant