Repository navigation
fix(ci): run xarray's backend tests from their new package - #4491
Merged
d-v-b merged 2 commits intoOct 8, 2026
Merged
Conversation
pydata/xarray#11633 split xarray/tests/test_backends.py and the other test_backends*.py modules into the xarray/tests/backends package, so the downstream job failed to collect any tests. Run the package instead. Assisted-by: ClaudeCode:claude-fable-5-1 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Assisted-by: ClaudeCode:claude-fable-5-1 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
d-v-b
marked this pull request as ready for review
October 8, 2026 16:42
Contributor
Author
|
self-merging b/c tests (including the downtream tests) are working correctly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this fixes the xarray downstream tests by adapting to the current state of xarray
🤖 AI text below 🤖
The downstream xarray CI job now runs the
xarray/tests/backendspackage. pydata/xarray#11633 splitxarray/tests/test_backends.py,test_backends_api.pyandtest_backends_datatree.pyinto that package, so the job failed to collect any tests (see the failing run).Running the package covers the same tests the three old modules held: the zarr store, region and append tests (
test_zarr.py), the engine-agnostic API tests (test_api.py) and the DataTree tests (test_datatree.py), plus the netCDF4, h5netcdf and scipy backend tests that were intest_backends.pyand ran before because theioextra installs those backends. It also picks up the small modules that were never selected before (test_chunks.py,test_common.py,test_file_manager.py,test_locks.py,test_lru_cache.py,test_plugins.py).The
run-downstreamlabel is set so the job runs on this PR.Verification
The
run-downstreamlabel triggered the Downstream workflow on this PR: run 37808680079 collected and ran the package against xarraymain(4929aa90f) with the branch zarr installed (3.4.1.dev74+g67939032):The numcodecs job in the same run passed as well. The agent also reproduced the install steps locally (xarray
main,--group dev ".[io,parallel,accel]", branch zarr with--no-deps) and collected 3640 tests from the package.Author attestation
TODO
docs/user-guide/*.mdchanges/🤖 Generated with Claude Code