Repository navigation
test(dtype): cover unicode fields in the structured default scalar test - #4496
Merged
d-v-b merged 1 commit intoOct 9, 2026
Merged
Conversation
zarr-developers#4495 also changed the default of `U` fields in structured dtypes from "0" to "". Add `U4` to the regression test and name string fields in the changelog entry. Assisted-by: ClaudeCode:claude-opus-5-5
d-v-b
marked this pull request as ready for review
October 9, 2026 10:16
Contributor
Author
|
teeny follow-up to #4495 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Structured data types now default string (
S,U) and raw-bytes (V) fields to zero bytes. Before, an array with a raw-bytes field failed to create without an explicit fill value, and string fields defaulted to"0".Summary
This is a follow-up to #4495. Moving from
np.array([0], dtype)[0]tonp.zeros(1, dtype)[0]also changed the default ofUfields from'0'to'', but the test and the changelog entry only namedSandV. This PR addsU4to the parametrized test and rewords the unreleasedchanges/4495.bugfix.mdentry.For reviewers
There is no new fragment, because the behavior change already ships under #4495. The agent checked that all three test cases fail on the parent of #4495 and pass on main. No library code changes.
Author attestation
TODO
docs/user-guide/*.md(no feature change)changes/(edits the unreleased4495.bugfix.mdinstead)🤖 Generated with Claude Code