Conversation
fixes ziglang#25284 by giving explicit source locations to the now failable coercion(s).
@min @max coerce comptime known arguments earlier@min @max
Contributor
Author
|
I just noticed that I forgot to add tests so this doesn't regress. Will do when I'm back from school. |
...my pc might've crashed while running these tests, I hope it's unrelated to this code. ...but I also kind of hope it is this code, cause then I don't got hardware problems at least.
Contributor
Author
|
I wrote in one of the commit messages that running the tests crashed my pc. Well in case it helps with figuring it out, I'm using Arch Linux with a Ryzen 7 5800x, 32 GiBs of RAM and a 960 GiBs NVME SSD as my #25192 seems related. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently an assertion fails when trying to compile code like the following.
As far as I can see, this happens because in
sema.analyzeMinMaxno source location is given to the coercion ofstd.math.maxInt(u32)to the result type (f32). Becausestd.math.maxInt(u32)isn't representable as anf32without rounding, this will throw an error. The error code then asserts that there is a source location, which, as said before, there is not.I fixed this by coercing the comptime known arguments a bit earlier, with a source location given.
Also I removed the coercion of the comptime known argument(s) to
intermediate_scalar_tylater on, because they are already guarantied to be coerced into it.fixes #25284