Repository navigation
vocab: append-only field ordering - #361
Merged
Merged
Conversation
A field minted after a class's edges were fixed is flagged `after_edges` and projected after them, so positions already pinned by a consumer's FieldMask (diagnosis: patient=10, encounter=11) do not move. `Class::field_basis` spells that order on the vocabulary side and a test checks it equals the class view's projection for every promoted class. Mints, each a column of a harvested MedCare screen: - diagnosis: recorded_on - lab_value: recorded_at, order_id - treatment: ended_at, session_count - examination: form_kind, note - document: name, uploaded_at, keywords, note - specialist_referral (0x090D, Facharztüberweisung): patient and referred_to edges; start_date, end_date, status, note Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
AdaWorldAPI
marked this pull request as ready for review
October 15, 2026 06:21
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
AdaWorldAPI
pushed a commit
that referenced
this pull request
Oct 15, 2026
Removes the concept 0x090D and the attribute mints added in #361. A consumer's codebook content does not belong in OGAR; OGAR keeps the generic part: `AttributeOptions::after_edges`, `Attribute::appended` and `Class::field_basis`, plus a test that an appended attribute lands after the edges and that `field_basis` matches the class view's order for every class. 0x090D is not reused. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
AdaWorldAPI
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds append-only field ordering (
after_edges,Attribute::appended,Class::field_basis). Its concept and attribute mints are withdrawn in a follow-up.Generated by Claude Code