Skip to content

ci: never fail test-with-coverage on a Codecov upload error - #1329

Merged
AdaWorldAPI merged 1 commit into
mainfrom
ccr-0455e606-wmtsor
Oct 5, 2026
Merged

AdaWorldAPI merged 1 commit into
mainfrom
ccr-0455e606-wmtsor

Conversation

@AdaWorldAPI

Copy link
Copy Markdown
Owner

test-with-coverage went red on #1327 (twice) and #1328 (twice) after every test had passed. Each time the cause was the Upload coverage to Codecov step:

Error: write EPROTO … ssl3_read_bytes:ssl/tls alert handshake failure … SSL alert number 40
    at WriteWrap.onWriteComplete (node:internal/stream_base_commons:87:19)

The step already sets fail_ci_if_error: false, but that flag only covers errors the Codecov uploader reports. Here the action itself throws on its first TLS connection, before the uploader runs, so the step fails anyway.

Change

.github/workflows/rust-test.yml: add continue-on-error: true to the upload step, with a comment explaining why. This is one line plus the comment.

What it does not hide

Test failures still fail the job. They surface in the preceding cargo llvm-cov step, which is unchanged. Only a failed upload is made non-blocking, which is what fail_ci_if_error: false already declared as the intent.

The YAML parses (yaml.safe_load).

🤖 Generated with Claude Code

https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg


Generated by Claude Code

The upload step already sets fail_ci_if_error: false, but a TLS handshake
failure inside codecov-action itself throws before the uploader runs and
still failed the job (EPROTO, SSL alert 40, on #1327 and #1328) after every
test had passed. continue-on-error makes the step non-blocking as intended;
test failures still fail the cargo llvm-cov step above.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.


Comment @coderabbitai help to get the list of available commands.

@cursor

cursor Bot commented Oct 5, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: a85dc17d-459d-4b53-b89e-136e1328712b)

@AdaWorldAPI
AdaWorldAPI marked this pull request as ready for review October 5, 2026 06:21
@coderabbitai

coderabbitai Bot commented Oct 5, 2026

Copy link
Copy Markdown

Autopilot could not be updated. Open Coding to check access and billing.

@AdaWorldAPI
AdaWorldAPI merged commit 21d07e3 into main Oct 5, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants