Repository navigation
ci: never fail test-with-coverage on a Codecov upload error - #1329
Merged
Merged
Conversation
The upload step already sets fail_ci_if_error: false, but a TLS handshake failure inside codecov-action itself throws before the uploader runs and still failed the job (EPROTO, SSL alert 40, on #1327 and #1328) after every test had passed. continue-on-error makes the step non-blocking as intended; test failures still fail the cargo llvm-cov step above. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Comment |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: a85dc17d-459d-4b53-b89e-136e1328712b) |
AdaWorldAPI
marked this pull request as ready for review
October 5, 2026 06:21
|
Autopilot could not be updated. Open Coding to check access and billing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test-with-coveragewent red on #1327 (twice) and #1328 (twice) after every test had passed. Each time the cause was the Upload coverage to Codecov step:The step already sets
fail_ci_if_error: false, but that flag only covers errors the Codecov uploader reports. Here the action itself throws on its first TLS connection, before the uploader runs, so the step fails anyway.Change
.github/workflows/rust-test.yml: addcontinue-on-error: trueto the upload step, with a comment explaining why. This is one line plus the comment.What it does not hide
Test failures still fail the job. They surface in the preceding
cargo llvm-covstep, which is unchanged. Only a failed upload is made non-blocking, which is whatfail_ci_if_error: falsealready declared as the intent.The YAML parses (
yaml.safe_load).🤖 Generated with Claude Code
https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
Generated by Claude Code