Skip to content

ci: never fail test-with-coverage on a Codecov upload error #1329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AdaWorldAPI merged 1 commit into from
Oct 5, 2026
+5 −0
Merged

ci: never fail test-with-coverage on a Codecov upload error #1329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/rust-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,6 +536,11 @@ jobs:
cargo llvm-cov --manifest-path crates/lance-graph/Cargo.toml --lib --lcov --output-path lcov.info
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v4
# `fail_ci_if_error: false` only covers errors the uploader reports. A
# TLS failure inside the action itself (seen as `EPROTO … SSL alert
# number 40` on #1327 and #1328) throws before the uploader runs and
# failed the job anyway. Test failures surface in the step above.
continue-on-error: true
with:
files: lcov.info
flags: rust-unittests
Expand Down
Loading