Repository navigation
V3 mandatory: the reading comes from the plug, never from the classid value (D-HPR) - #1464
Merged
Merged
Conversation
Operator ruling 2026-10-10: V3 mandatory; the reading comes only from the plug (HotPlug -> OgarAuthority -> Activation::resolve_for_context) and the slab declaration; lockstep tables deprecated; a concept is an immutable address and names in other languages are labels. Plan W1-W6 retires classid_read_mode / BUILTIN_READ_MODES, which selects V3 by the 0x1000 marker and falls back to V1 for an unknown classid. Caller inventory across lance-graph, q2, MedCare-rs and OGAR included; stored 0x1000 keys stay readable. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019fbZ92dFKQ5BJHrA3YcH9A
|
Warning Review limit reachedYour organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Next included review available in 26 minutes. View limit details
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Comment |
ocr::to_node_row_with, aiwar::aiwar_node_rows_with,
soa_graph::{project_snapshot_with, nearest_anchor_with} and
nan_projection::project_energy_nonfinite_plugged take the reading the
caller's plug resolved instead of looking the classid up in
BUILTIN_READ_MODES. The plugged NaN sweep fails closed: an unplugged
concept is NoReadingFor, never a V1 default.
The classid-lookup forms keep their behaviour and delegate. Each new
form has a test on a classid the lookup misreads (V1/Full default), so a
form that silently re-looks-up fails.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019fbZ92dFKQ5BJHrA3YcH9A
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019fbZ92dFKQ5BJHrA3YcH9A
AdaWorldAPI
marked this pull request as ready for review
October 10, 2026 18:05
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 94fe22224a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ted, kept Operator 2026-10-10: "1000 isn't hurting, just document and Mark it as deprecated. No need to force evict." Doc notes on the five CLASSID_*_V3 constants and on classid_read_mode point new code at the plug reading; existing keys and callers keep working. A doc note rather than #[deprecated], which would fail every existing caller under -D warnings. Plan W4 done (documentation), W5 reworded: legacy keys keep resolving, no forced removal. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019fbZ92dFKQ5BJHrA3YcH9A
added-plans-have-dids failed: D-V3M does not match the D-id pattern (two letters before a digit), so the plan read as carrying no D-id. Renamed to D-HPR everywhere. Codex P2: to_node_row_with_follows_the_handed_reading mints a V3 tail, which mint_for refuses without the tail feature, so the --no-default-features suite panicked. Gated on guid-v3-tail like the aiwar and soa_graph tests. No-default-features lib suite: 1445 pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019fbZ92dFKQ5BJHrA3YcH9A
AdaWorldAPI
changed the title
AdaWorldAPI
pushed a commit
that referenced
this pull request
Oct 10, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019fbZ92dFKQ5BJHrA3YcH9A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Operator ruling, 2026-10-10:
D-HPR-0: plan and record
.claude/plans/v3-mandatory-hotplug-reading-v1.md, with the ruling written out as rules and the waves W1–W6.classid_read_mode/*_V3caller across lance-graph, q2, MedCare-rs and OGAR, plus the stored data keyed on0x1000.INTEGRATION_PLANS/STATUS_BOARDrows.D-HPR-1: the contract takes the reading as a parameter
New forms take the reading the caller's plug resolved, instead of looking the classid up in
BUILTIN_READ_MODES:ocr::LayoutBlock::to_node_row_withaiwar::aiwar_node_rows_withsoa_graph::project_snapshot_withandsoa_graph::nearest_anchor_withnan_projection::project_energy_nonfinite_plugged: resolves each run throughActivation::resolve_tenant_reading. An unplugged concept returnsNoReadingFor, never a V1 default.The old forms keep their behaviour and delegate to the new ones.
D-HPR-4: the fossils are documented as deprecated and kept
CLASSID_*_V3constants andclassid_read_modecarry a "Deprecated, kept" doc note. Nothing is evicted.#[deprecated]: the attribute would fail every existing caller under-D warnings, which is the forced migration the ruling rules out.Gates
lance-graph-contract: all tests pass with default features, and the lib suite passes with--no-default-features(1445 tests). fmt and clippy-D warningsare clean.0x1718_0000, which the lookup reads as V1 /Full. Disable runs: each test turns red when its form re-looks-up the classid (4/4).guid-v3-tail.added-plans-have-dids: the plan ids are renamed toD-HPR-*.D-V3Mdid not match the D-id pattern.Open (operator)
0x1000. Not blocking.🤖 Generated with Claude Code
https://claude.ai/code/session_019fbZ92dFKQ5BJHrA3YcH9A