Repository navigation
lance-graph-ogar: reading-only plugs (D-HPR-8) + storage readings off the concept key (D-HPR-7) - #1474
Merged
Conversation
…R-8) Reading is not a capability (operator decision, 2026-10-11). A HotPlug with an empty `covered` list now skips the capability join, so a concept with no action table, or a table whose executor list does not name the consumer, no longer refuses the plug. Palette seats and canon storage domains keep their existing routing. Every other id must still be a minted concept, and its row still goes through the mirror check. A plug that names any capability goes through the join unchanged. This unblocks the SAP and Odoo glove plugs on 0x0103; the glove-parity pin is updated to match. Tests: 2 new in lance-graph-ogar (can-fire, can-stay-silent). Red before the fix (NoCapabilitiesFor(0x0103)). A disable run that made every plug reading-only turned the silence test and 5 others red. lance-graph-ogar 109 tests and lance-graph-glove-parity 16 tests pass; fmt clean; no new clippy findings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019fbZ92dFKQ5BJHrA3YcH9A
|
Warning Review limit reachedYour organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Next included review available in 36 minutes. View limit details
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Comment |
concept_override no longer maps the five canon domains (0x0701, 0x0A01, 0x0E01, 0x0101, 0x0202) to their storage models. Three of these u16s are also consumer appid heads, so any consumer that plugged the shared concept got one app's storage model (O3; option (a) decided by the operator 2026-10-11). The domain models differed from PLUG_AND_PLAY_V3 only in value_schema, which the slab's SlabDeclaration already overrides, so the domain's own slab restores its model. Reading-only routing for these ids is unchanged. Tests: the D-HPR-2 pin is re-pinned. Each domain now reads plug-and-play, and resolve_for_context with the domain's slab declaration equals classid_read_mode of its *_V3 key. Both re-pinned tests failed before the change. lance-graph-ogar and lance-graph-glove-parity pass; fmt clean; clippy unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019fbZ92dFKQ5BJHrA3YcH9A
AdaWorldAPI
changed the title
AdaWorldAPI
marked this pull request as ready for review
October 11, 2026 08:22
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
AdaWorldAPI
pushed a commit
that referenced
this pull request
Oct 11, 2026
v3_mint_reachability_probe expected V1 when the feature was off; the V3 registry entries are unconditional now, so it asserts V3 always. STATUS_BOARD: D-HPR-6a in PR with its scope (the 128-bit opt-in is not touched), D-HPR-7 and D-HPR-8 shipped in #1474. Plan W6a records the scope. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019fbZ92dFKQ5BJHrA3YcH9A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes to
OgarAuthority, both decided by the operator on 2026-10-11 (planv3-mandatory-hotplug-reading-v1, W7 and W8).D-HPR-8: a plug that asks only for a reading activates
activatenow skips the capability join whencoveredis empty. Reading is not a capability, so a concept with no action table, or a table that does not list the consumer, no longer refuses the plug.What stays guarded:
verify_against_mirror.This unblocks the SAP and Odoo glove plugs on
0x0103, and the glove-parity pin is updated to match.D-HPR-7: storage readings leave the concept key
concept_overrideno longer maps the five canon domains to their storage models. Three of these u16s are also consumer appid heads (0x0101,0x0202,0x0A01), so any consumer that plugged the shared concept got one app's storage model. The domain models differed fromPLUG_AND_PLAY_V3only invalue_schema, which the slab'sSlabDeclarationalready overrides. The domain's own slab now restores its model.Tests
NoCapabilitiesFor(0x0103)). A disable run that made every plug reading-only turned 6 tests red.classid_read_mode(*_V3)reading. Both re-pinned tests were red before the change.lance-graph-ogarandlance-graph-glove-paritypass.cargo fmtis clean. Clippy shows the same 4 pre-existing warnings.🤖 Generated with Claude Code
https://claude.ai/code/session_019fbZ92dFKQ5BJHrA3YcH9A