Repository navigation
dir-sim: a provisioning plane separate from delivery - #1477
Merged
Merged
Conversation
validate::provisioning_conflicts reports every key claimed by more than one present directory object: each present user's UPN, primary and secondary SMTP and routing address, and each live group's primary SMTP, whatever the object's enabled or recipient state. Entra keeps UPN and proxyAddresses unique across the whole tenant, so a disabled account or a mailbox-less account's leftover SMTP claims its value too. It is a separate plane: address_owner, address_recipient and validate read the owner planes as before, so a provisioning conflict changes neither who holds an address nor where mail to it is delivered. address_rows becomes rows_over(owners, mail_owners); the delivery call passes the same planes it computed before. The claimants are listed, not judged: Entra quarantines the duplicate on the object whose sync brought it, and the simulator observes no sync order. Contacts, public folders and other object kinds also claim proxy addresses in a real tenant and are not observed; recorded as a fidelity limit in the function's docs. tests/provisioning.rs: a leftover address conflicts in provisioning and leaves owner/recipient and validate unchanged; a disabled account's UPN is still claimed; distinct claims and one object under two roles are silent. Red against an empty stub, green after. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
AdaWorldAPI
marked this pull request as ready for review
October 11, 2026 09:18
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (3)
✨ Finishing Touches
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a42379a2c8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
AdaWorldAPI
pushed a commit
that referenced
this pull request
Oct 11, 2026
Exchange delivers mail sent to any of a distribution group's SMTP proxies, but the address space read a group by its primary address only: mail to a group's secondary proxy resolved to no one. rows_over now adds each live, observed group's secondary SMTP proxies, so address_owner and address_recipient answer the group, and validate's address rules see the same rows (Exchange refuses an address another object holds). provisioning_conflicts read the group proxies in a loop of its own; that loop is now part of rows_over, so the two planes keep one definition of a group's claims. The provisioning plane is otherwise unchanged. Behaviour change, pinned both ways: mail_to_a_groups_secondary_proxy_ reaches_the_group (red before: Ok(None)); a_groups_secondary_proxy_ claims_its_address now expects an AddressConflict where it pinned the user as owner, since the user and the group share the key. Board: D-DSV-1 shipped (#1477, #1480); D-DSV-2 added. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Decision 1(c): the observed address claims, provisioning conflicts and delivery resolution are kept as three separate questions. This PR adds the provisioning one without touching delivery.
validate::provisioning_conflicts(view)reports every key claimed by more than one present directory object: each present user's UPN, primary and secondary SMTP and routing address, and each live group's primary SMTP, whatever the object's enabled or recipient state. Entra keeps UPN andproxyAddressesunique tenant-wide, so a disabled account or a mailbox-less account's leftover SMTP still claims its value.address_owner,address_recipientandvalidateare unchanged.address_rowsbecomesrows_over(owners, mail_owners)and the delivery path passes the same planes it computed before.Tests
tests/provisioning.rs:validatereports noAddressConflict;Red against an empty stub, green after. Disable runs: feeding the owner planes instead of the present plane turns two tests red; dropping the distinct-claimant filter turns all three red.
cargo test -p lance-graph-dir-sim --all-featuresgreen; clippy--all-targets --all-features -D warningsclean.Board:
STATUS_BOARD.mdgains D-DSV-1; D-DSP-0/1/3 marked shipped in #1473.🤖 Generated with Claude Code
https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
Generated by Claude Code