Skip to content

Antalya-26:6 - iceberg v3: rewriteFiles - Added logic to merge small files into bins #2420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
subkanthi wants to merge 5 commits into
base: antalya-26.6
Choose a base branch
from
Draft

Antalya-26:6 - iceberg v3: rewriteFiles - Added logic to merge small files into bins #2420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7131654
Added logic to merge small files into bins
subkanthi Sep 23, 2026
23e7a52
Fix compilation error in IcebergMetadata
subkanthi Sep 23, 2026
43c15c4
Explicitly specify SecondaryStorages in BinPackRewrite.h
subkanthi Sep 23, 2026
d10fcdd
Fix assert in gtest_bin_pack_rewrite
subkanthi Sep 24, 2026
0357f1f
Link Avro library to unit_tests_dbms so headers can be included in te…
subkanthi Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -956,6 +956,10 @@ if (ENABLE_TESTS)
target_link_libraries(unit_tests_dbms PRIVATE ch_contrib::parquet)
endif()

if (TARGET ch_contrib::avrocpp)
target_link_libraries(unit_tests_dbms PRIVATE ch_contrib::avrocpp)
endif()

if (TARGET ch_contrib::silk_fibers)
target_link_libraries(unit_tests_dbms PRIVATE ch_contrib::silk_fibers)
endif()
Expand Down
10 changes: 10 additions & 0 deletions src/Core/Settings.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8370,6 +8370,16 @@ Allow to explicitly use 'OPTIMIZE' for iceberg tables.
Minimum number of manifest files required to trigger manifest-only compaction via OPTIMIZE TABLE ... MANIFEST.
If the current number of manifest files is less than or equal to this threshold, compaction is skipped.
Requires allow_experimental_iceberg_compaction to be enabled.
)", EXPERIMENTAL) \
DECLARE(UInt64, iceberg_target_data_file_size_bytes, 536870912, R"(
Target data file size in bytes for Iceberg bin-packing compaction via OPTIMIZE TABLE.
Small files are merged until the result approaches this size. Default is 512 MiB.
Requires allow_experimental_iceberg_compaction to be enabled.
)", EXPERIMENTAL) \
DECLARE(UInt64, iceberg_min_data_file_size_bytes, 402653184, R"(
Data files smaller than this threshold are candidates for bin-packing compaction via OPTIMIZE TABLE.
Default is 384 MiB (75% of iceberg_target_data_file_size_bytes).
Requires allow_experimental_iceberg_compaction to be enabled.
)", EXPERIMENTAL) \
DECLARE(Bool, allow_iceberg_remove_orphan_files, false, R"(
Allow to use 'ALTER TABLE ... EXECUTE remove_orphan_files()' for iceberg tables.
Expand Down
2 changes: 2 additions & 0 deletions src/Core/SettingsChangesHistory.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ const VersionToSettingsChangesMap & getSettingsChangesHistory()
addSettingsChanges(settings_changes_history, "26.6.2.20001.altinityantalya",
{
{"use_puffin_files_cache", false, true, "Enables cache of parsed Puffin file content such as deletion vectors."},
{"iceberg_target_data_file_size_bytes", 536870912, 536870912, "Target file size for Iceberg bin-packing compaction (default 512 MiB)."},
{"iceberg_min_data_file_size_bytes", 402653184, 402653184, "Files below this size are candidates for Iceberg bin-packing compaction (default 384 MiB)."},
});

addSettingsChanges(settings_changes_history, "26.6",
Expand Down
Loading