Repository navigation
Keep inspector label focus during refresh - #495
Closed
Eli Pinkerton (wallstop) wants to merge 2 commits into
Closed
Eli Pinkerton (wallstop) wants to merge 2 commits into
Eli Pinkerton (wallstop) wants to merge 2 commits into
Conversation
5 tasks
Eli Pinkerton (wallstop)
added a commit
that referenced
this pull request
Oct 31, 2026
Surviving inspector label actions must retain identity and focus when neighboring labels are inserted or removed. Check ordinal positions and retention of the unchanged empty-label state in the existing hosted case. Count unrelated row bindings separately because selected-row refresh may legitimately rebind the affected object. Changed-file checks and all 16 local gate steps pass, including CSharpier and npm pack. Required Unity execution remains incomplete: the bridge reports no Pipeline instance for C:\Code\DataVisualizer. Keep PR #495 draft until original-code reproduction, focused UI regression, full EditMode and actual PlayMode suites, and UI inspection pass. Refs #308.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
|
6 of 9 tasks
Eli Pinkerton (wallstop)
added a commit
that referenced
this pull request
Oct 31, 2026
Surviving inspector label actions must retain identity and focus when neighboring labels are inserted or removed. Check ordinal positions and retention of the unchanged empty-label state in the existing hosted case. Count unrelated row bindings separately because selected-row refresh may legitimately rebind the affected object. Changed-file checks and all 16 local gate steps pass, including CSharpier and npm pack. Required Unity execution remains incomplete: the bridge reports no Pipeline instance for C:\Code\DataVisualizer. Keep PR #495 draft until original-code reproduction, focused UI regression, full EditMode and actual PlayMode suites, and UI inspection pass. Refs #308.
Eli Pinkerton (wallstop)
force-pushed
the
fix/retain-inspector-label-controls
branch
from
October 31, 2026 03:22
c82f712 to
bc8b9db
Compare
Eli Pinkerton (wallstop)
changed the base branch from
main
to
fix/mcp-bridge-lifecycle
October 31, 2026 03:22
Eli Pinkerton (wallstop)
added a commit
that referenced
this pull request
Oct 31, 2026
Surviving inspector label actions must retain identity and focus when neighboring labels are inserted or removed. Check ordinal positions and retention of the unchanged empty-label state in the existing hosted case. Count unrelated row bindings separately because selected-row refresh may legitimately rebind the affected object. Changed-file checks and all 16 local gate steps pass, including CSharpier and npm pack. Required Unity execution remains incomplete: the bridge reports no Pipeline instance for C:\Code\DataVisualizer. Keep PR #495 draft until original-code reproduction, focused UI regression, full EditMode and actual PlayMode suites, and UI inspection pass. Refs #308.
Eli Pinkerton (wallstop)
force-pushed
the
fix/retain-inspector-label-controls
branch
from
October 31, 2026 05:17
bc8b9db to
576cb7b
Compare
Ordinary selected-asset edits rebuilt every inspector label pill and removed focus from its action. Reconcile labels in ordinal order and retain each surviving pill and the empty-state label. Extend the hosted refresh regression to check pill identity and focused label actions through SerializedObject edits, Undo and Redo. The 16-step local gate and changed-file fast checks pass. Unity validation is incomplete: two original-code runs stop on the native editor assertion "Access version should be odd when acquiring lock" before the new checks. The editor then stops responding during compilation. No suppression or successful Unity regression result is claimed; restart the host and run the focused regression, full EditMode suite and actual PlayMode suite. Refs #308.
Surviving inspector label actions must retain identity and focus when neighboring labels are inserted or removed. Check ordinal positions and retention of the unchanged empty-label state in the existing hosted case. Count unrelated row bindings separately because selected-row refresh may legitimately rebind the affected object. Changed-file checks and all 16 local gate steps pass, including CSharpier and npm pack. Required Unity execution remains incomplete: the bridge reports no Pipeline instance for C:\Code\DataVisualizer. Keep PR #495 draft until original-code reproduction, focused UI regression, full EditMode and actual PlayMode suites, and UI inspection pass. Refs #308.
Eli Pinkerton (wallstop)
force-pushed
the
fix/retain-inspector-label-controls
branch
from
October 31, 2026 05:26
576cb7b to
82296d4
Compare
This was referenced Oct 31, 2026
Eli Pinkerton (wallstop)
added a commit
that referenced
this pull request
Nov 1, 2026
DISCLOSURE: LLM-GENERATED TEXT **Why:** Removing an asset label rebuilt every inspector label pill, so keyboard focus fell to the window body and tab order restarted. **What:** - Reconcile inspector pills by ordinal label instead of rebuilding them. - Hand focus to the next surviving remove button after a removal. - Fall back to the add-label field when the last pill goes. - Reuse one empty notice and one shared background-luminance check. Refs #308. Note: draft #495 carries the same behavior inside the window without hosted behavior validation. This PR delivers it as a tested control.
Collaborator
Author
Eli Pinkerton (wallstop)
added a commit
that referenced
this pull request
Nov 1, 2026
A running Editor can be incompatible with Pipeline while the bridge reports only no instance. Host status identifies STATUS_PIPELINE_LOAD_PENDING: Pipeline cannot start on 6000.5.2f1 and requires 6000.5.3f1 or later. The bridge doctor hid that cause and called an unadvertised status name. Expose bounded read-only pinned host diagnostics through MCP, preserve status reasons and detect stale running source. Forward catalog changes over authenticated session streams with bounded coalescing. Add explicit instance-checked stop and idle reconnect without replaying mutations. Use bounded main-loop waits for console signals, leave stdin closure to its writer, and reject late requests after shutdown. Original-code regressions fail for missing HTTP sessions, the wrong diagnostic tool and writer-owned pipe closure. Repaired full harness: all 49 test files pass, including 67 Unity bridge cases (two Windows-only cases skip on Linux). Targeted strict Pyright reports zero diagnostics. Local fast checks pass. The package payload and Unity C# are unchanged. Windows CI and live host recovery remain required. No host upgrade, Editor close, successful live canary, or permanent-upstream guarantee is claimed. The old bridge must be replaced once to load this code. Refs #497. Keeps draft #495's behavior validation pending host recovery.
An error occurred while trying to automatically change base from
fix/mcp-bridge-lifecycle
to
main
November 1, 2026 17:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DISCLOSURE: LLM-GENERATED TEXT
Why: Ordinary asset edits replace inspector label actions and drop keyboard focus.
What:
Refs #308.