Repository navigation
[Containerapp] az containerapp env create: Pre-announce future logs destination default change
#34243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Michael Dai (michaelkira)
wants to merge
1
commit into
Azure:dev
Choose a base branch
from
michaelkira:private/michdai/containerapp-logs-preannouncement
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+48
−0
Open
[Containerapp] az containerapp env create: Pre-announce future logs destination default change
#34243
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
15 changes: 15 additions & 0 deletions
15
src/azure-cli/azure/cli/command_modules/containerapp/_breaking_change.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # -------------------------------------------------------------------------------------------- | ||
| # Copyright (c) Microsoft Corporation. All rights reserved. | ||
| # Licensed under the MIT License. See License.txt in the project root for license information. | ||
| # -------------------------------------------------------------------------------------------- | ||
|
|
||
| from azure.cli.core.breaking_change import register_default_value_breaking_change | ||
|
|
||
| register_default_value_breaking_change( | ||
| 'containerapp env create', | ||
| '--logs-destination', | ||
| 'log-analytics', | ||
| 'azure-monitor', | ||
| target_version=None, | ||
| doc_link='https://github.com/Azure/azure-cli/pull/34228', | ||
| ) | ||
33 changes: 33 additions & 0 deletions
33
.../azure/cli/command_modules/containerapp/tests/latest/test_containerapp_breaking_change.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| # -------------------------------------------------------------------------------------------- | ||
| # Copyright (c) Microsoft Corporation. All rights reserved. | ||
| # Licensed under the MIT License. See License.txt in the project root for license information. | ||
| # -------------------------------------------------------------------------------------------- | ||
|
|
||
| import inspect | ||
| import runpy | ||
| import unittest | ||
| from unittest import mock | ||
|
|
||
| from azure.cli.core.breaking_change import upcoming_breaking_changes | ||
| from azure.cli.core.mock import DummyCli | ||
| from azure.cli.command_modules.containerapp.custom import create_managed_environment | ||
|
|
||
|
|
||
| class ContainerappBreakingChangeTest(unittest.TestCase): | ||
| def test_logs_destination_preannouncement(self): | ||
| with mock.patch.dict(upcoming_breaking_changes, clear=True): | ||
| runpy.run_module('azure.cli.command_modules.containerapp._breaking_change') | ||
| changes = upcoming_breaking_changes['containerapp env create'] | ||
| self.assertEqual(len(changes), 1) | ||
| change = changes[0] | ||
| self.assertEqual(change.current_default, 'log-analytics') | ||
| self.assertEqual(change.new_default, 'azure-monitor') | ||
| self.assertIn('--logs-destination', change.message) | ||
| self.assertIn('in a future release', change.message) | ||
| self.assertIn('https://github.com/Azure/azure-cli/pull/34228', change.message) | ||
| self.assertTrue(change.to_tag(DummyCli()).always_display) | ||
|
|
||
| self.assertEqual( | ||
| inspect.signature(create_managed_environment).parameters['logs_destination'].default, | ||
| 'log-analytics', | ||
| ) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Michael Dai (@michaelkira) As the underlying breaking change is going to merged in the next release for ignite. Please set
target_version='2.93.0'Please refer to https://github.com/Azure/azure-cli/milestone/175 for more information