Repository navigation
[Containerapp] az containerapp env create: Pre-announce future logs destination default change - #34243
Open
Michael Dai (michaelkira) wants to merge 1 commit into
Conversation
Keep the default at log-analytics and warn about the future azure-monitor default without promising an unconfirmed release window. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Michael Dai (michaelkira)
requested review from
a team,
Greedygre (Greedygre),
Zunli Hu (Juliehzl) and
Hong Wang (howang-ms)
as code owners
October 20, 2026 04:53
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
microsoft-github-policy-service
Bot
requested review from
ZelinWang (wangzelin007) and
Yong Zhang (yonzhan)
October 20, 2026 04:53
3 of 4 tasks
3 tasks done
Contributor
|
Thank you for your contribution Michael Dai (@michaelkira)! We will review the pull request and get back to you soon. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The scoped changes use existing warning infrastructure, preserve current behavior, and have no identified blocking issues.
No open issues 🎉
What changed in this PR
Pre-announces the future Container Apps logs destination default change without changing current creation behavior.
Changes:
- Registers a future-release warning with a migration link, without promising a release window.
- Adds a regression test for the warning and unchanged
log-analyticsdefault.
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/containerapp/tests/latest/test_containerapp_breaking_change.py | Verifies warning registration, wording, visibility, and current default. |
| src/azure-cli/azure/cli/command_modules/containerapp/_breaking_change.py | Registers the default-change pre-announcement. |
Review effort: Balanced
Member
|
/azp run |
Contributor
|
Hi Michael Dai (@michaelkira), |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation — ️✔️ All clear
Related command
az containerapp env createDescription
Pre-announces the future change of the
--logs-destinationdefault fromlog-analyticstoazure-monitorusing the standard breaking-change registration.This PR does NOT change the current default or create behavior. The warning links to the migration information in #34228. To retain Log Analytics behavior after the eventual change, users should explicitly pass
--logs-destination log-analytics.Release coordination
target_version=None, following existing VM pre-announcements, to say "in a future release" rather than automatically promising the next window. Maintainers: please confirm the target version/window and announcement release.Testing Guide
python -m pytest src\azure-cli\azure\cli\command_modules\containerapp\tests\latest\test_containerapp_breaking_change.py -q: PASSED (1 test). Verifies the warning registration, always-displayed tag, future-release wording, migration link, and unchanged handler default.azdev style azure-cli-containerapp: PASSED (Pylint and Flake8).containerapp env create -g test-rg -n test-env -l australiaeast: PASSED. Confirmed the runtime warning is emitted and the handler receiveslog-analytics; the creation decorator was mocked and extension discovery disabled for isolation.History Notes
[Containerapp]
az containerapp env create: Pre-announce the future change of the--logs-destinationdefault fromlog-analyticstoazure-monitor; the current default remains unchangedThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.