Skip to content

Add bounded VeinMining with durable usage charges - #87

Draft
BenCodez wants to merge 1 commit into
split/mcperks-p3-refillfrom
split/mcperks-p4-vein
Draft

BenCodez wants to merge 1 commit into
split/mcperks-p3-refillfrom
split/mcperks-p4-vein

Conversation

@BenCodez

@BenCodez BenCodez commented Nov 8, 2026

Copy link
Copy Markdown
Owner

Adds the focused VeinMining slice from #76, stacked on #86. Opt-in connected-ore traversal stays bounded and never loads chunks. Additional native player breaks preserve protection events, tool wear and normal drops; deferred work rechecks the original event, exact player session, held slot and tool metadata. A shared in-flight guard suppresses recursive automation through listener replacement and reload.

Optional personal charges reserve the additional-block budget before gameplay. Proved-unused units are refunded; an uncertain native call remains spent and stops the batch. Existing perks do not gain the effect automatically. This PR leaves harvesting, PrecisionMode, queues, banking and statistics in their separate slices.

Validation: 56 focused cases and 421 clean-package tests passed, zero failures/errors/skips, with source stability confirmed. Existing P3 test assertions are retained. The earlier full P4 review is combined with a fresh independent focused correction/composition review returning No findings; this is not a fresh whole-PR verdict. The final regression surfaces callback failures outside the production callback, with a retained parent-source failure. ZIP integrity, all 40 unchanged resources, filtered descriptor, new Java 21 classes, test/provided-library exclusions and 75 actual dependency JARs were checked. JAR SHA-256: d3ecc81b1143c13ac4d1bb182fa2c59010b5d8782184f1d0f740458e79ce20de.

Remains a draft for normal dependency delivery, current-head hosted feedback and separately authorized native/older-server acceptance. Validation used isolated candidate dependencies, not released artifacts. MCPerks does not declare Folia support. Merge order is #78, #80, #86, then this slice. No merge, release or deployment is included.

Created with AI assistance.

@coderabbitai

coderabbitai Bot commented Nov 8, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b0a926e5-bb29-43b0-9d60-cf5538824acb
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant