Repository navigation
fix(mobile): start iOS dictation after native gesture begin - #2592
Conversation
RNGH 3.3 ignores activation while UNDETERMINED; iOS manual touch-down precedes BEGAN. Activate from onBegin and make the regression harness honor that ordering. Issue: #2591 Agent-Task: codex/local/01a1621c-a81b-7670-86be-1ddaf404c2e2
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 26 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Batch55 native recheck: FAIL on frozen acceptance candidate Existing iOS27 Simulator, fresh candidate Debug native build; strict fingerprint Real short tap and800ms long press on the empty-chat microphone each produced Stop/cancel/lock/interruption and the historical immediate-stop symptom remain untested because this path never starts. This does not validate the repair or release candidate. Source composer owner retains the fix; no product source edits in the QA batch. Private local evidence index: |
Closes #2591 · Agent claim · Follow-up to #2576
Why the change
iOS dictation taps and holds can reach the release callback without starting speech because the manual gesture requests activation before the native handler has begun.
Special things to note
419a72578be52f7e4333c27b2c0f6fcb76908f2b. Batch54 proves missingonStarton actual taps/holds, not the earlier immediate native-stop report; recording lifecycle, real microphone and VoiceOver remain unaccepted.Change outline
Batch56 — native startup reached; recording still fails
Latest native follow-up on candidate
914bfa57ed048containing merged #2595, not a rerun of the earlier gesture-only heads. iOS 27 Simulator, English, signed Debug binary55de08577ac5, strict native fingerprintb3e74315f0c2; full identities and image hashes are in the provenance report.FAIL: sustained recording. The centered button now reaches speech startup, but the native task ends immediately; root cause remains undetermined. An uninstrumented real tap reaches the same failure UI. Valid v2 observations stayed current and fully restored. Initial Batch56 traces from the withdrawn v1 observer were contaminated by Hermes eval loop-closure binding and are excluded. No Simulator-wide limitation is inferred from the remaining failure.
Actual candidate failure — light,
large, 402 × 874, software keyboard absent. The microphone is centered. This is not a successful Listening state or a matched failure-state Before/After pair; the earlier Batch55 baseline above/below retains its own source, fixture and missing-start result.Scoped interaction result: a synthetic three-line draft survived expand/done, attachment-tray open/close and six theme/text-size changes, then was sent once with exact canonical Host text and a real direct DeepSeek reply 42. The software keyboard did not appear, so keyboard avoidance is UNTESTED. Later draft lines are visible in the larger-text fields; full editing, caret and scroll acceptance is not inferred.
Six candidate draft captures — keyboard absent; no matched Batch56 Before matrix
Light:
large,accessibility-large,accessibility-extra-extra-extra-large, respectively.Dark: the same three OS text sizes, respectively.
Still unaccepted: stable Listening, second-tap Stop, explicit Cancel, recording interruption/retry, keyboard clearance, full matched Before/After, physical microphone, VoiceOver and Android. The bounded exact-app-PID native log read parsed 1003 records but yielded no allowlisted error facts; that does not locate the native cause. New source repairs, if required, need their own branch/PR and a new owner-cut test batch. No product source change or new merge/release authorization is implied by this evidence update.
Evidence follow-up:
t3code/local/mcp:dbfb1c61-ea88-4449-82fe-bce3ae129811, successor claim. Earlier Batch54/55 reports below remain historical and retain their stated limits.The regression harness now reproduces the pinned RNGH 3.3 iOS ordering: touch-down precedes BEGAN, and early activation is ignored. The old implementation failed eight interaction assertions with zero starts; the repair passes all 47 focused composer/dictation tests. Mobile typecheck, repository lint (existing unrelated warnings), touched-file formatting and iOS Babel transformation of nine worklets pass. No production diagnostic instrumentation is included.
Native evidence pending: the exclusive shared runner is completing frozen Batch54. Merged main containing this repair is submitted for a new owner-cut batch, with real taps/holds and bounded callback/native-event counts before any success claim. Review path: empty composer → tap Dictate → observe onStart, availability/permission and native start/audio events → tap stop; repeat hold/release, left cancel, up lock and interruption. Capture real before/after recording states and report native error code/domain without transcript/audio. Existing #2576 composer screenshots do not prove this repair works.
The single activation transition is fully shown above; a separate HTML explainer is omitted.
Task:
codex/local/01a1621c-a81b-7670-86be-1ddaf404c2e2.Batch55 update — recording startup still fails
This result supersedes the earlier pending-retest status: native Batch55 on source
87724a3b58d5(including #2592) still produced only onHeld/finalize on real short tap and 800ms hold, with no onStart, availability/permission calls or native speech events. The observer stayed installed/current, the loaded Hermes code contains #2592, and both observers were stopped/restored. Historical immediate-end remains a separate unlocated symptom; no successful recording state is claimed.The Human also reported the offset/clipped microphone. Merged repair #2595, issue #2594, replaces the iOS manual gesture with a centered native SwiftUI button (tap start / tap stop, explicit cancel). Its Batch56 native result is recorded above; sustained recording remains unaccepted.
Actual failure state — light, large text, 402 × 874 pt, keyboard hidden; Debug strict fingerprint
b3e74315f0c2, final signed executable55de08577ac5. This image is a failure baseline, not an After-success comparison. Provenance.