Repository navigation
feat(mobile): native iOS composer actions and dictation gestures - #2576
Merged
Merged
Conversation
Issue: #2575 Agent-Task: codex/local/01a1621c-a81b-7670-86be-1ddaf404c2e2
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 23 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
DoodleBears
marked this pull request as ready for review
October 22, 2026 06:58
This was referenced Oct 22, 2026
DoodleBears
added a commit
that referenced
this pull request
Oct 22, 2026
Agent-Task: codex/local/01a1621c-a81b-7670-86be-1ddaf404c2e2
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2575 · Agent claim · Follow-up to #2567
Why the change
iOS composer controls should use native button feedback and native touch recognition while preserving the existing text entry, send and dictation workflow.
Special things to note
46bb44b2ff4f1ca9ca682ac9dce423a310c3bb2d. Batch54 has partial native UI evidence below; recording startup remains unresolved and full native acceptance is pending. Batch 51 exercised the earlier fix(mobile): unify the iOS message composer island #2567 layout and encountered immediate dictation termination after permission, so it does not validate these new gestures or prove that audio issue fixed. Physical microphone, VoiceOver, Release feel/performance and Android acceptance are separate.Change outline
Batch56 — native startup reached; recording still fails
Latest native follow-up on candidate
914bfa57ed048containing merged #2595, not a rerun of the earlier gesture-only heads. iOS 27 Simulator, English, signed Debug binary55de08577ac5, strict native fingerprintb3e74315f0c2; full identities and image hashes are in the provenance report.FAIL: sustained recording. The centered button now reaches speech startup, but the native task ends immediately; root cause remains undetermined. An uninstrumented real tap reaches the same failure UI. Valid v2 observations stayed current and fully restored. Initial Batch56 traces from the withdrawn v1 observer were contaminated by Hermes eval loop-closure binding and are excluded. No Simulator-wide limitation is inferred from the remaining failure.
Actual candidate failure — light,
large, 402 × 874, software keyboard absent. The microphone is centered. This is not a successful Listening state or a matched failure-state Before/After pair; the earlier Batch55 baseline above/below retains its own source, fixture and missing-start result.Scoped interaction result: a synthetic three-line draft survived expand/done, attachment-tray open/close and six theme/text-size changes, then was sent once with exact canonical Host text and a real direct DeepSeek reply 42. The software keyboard did not appear, so keyboard avoidance is UNTESTED. Later draft lines are visible in the larger-text fields; full editing, caret and scroll acceptance is not inferred.
Six candidate draft captures — keyboard absent; no matched Batch56 Before matrix
Light:
large,accessibility-large,accessibility-extra-extra-extra-large, respectively.Dark: the same three OS text sizes, respectively.
Still unaccepted: stable Listening, second-tap Stop, explicit Cancel, recording interruption/retry, keyboard clearance, full matched Before/After, physical microphone, VoiceOver and Android. The bounded exact-app-PID native log read parsed 1003 records but yielded no allowlisted error facts; that does not locate the native cause. New source repairs, if required, need their own branch/PR and a new owner-cut test batch. No product source change or new merge/release authorization is implied by this evidence update.
Evidence follow-up:
t3code/local/mcp:dbfb1c61-ea88-4449-82fe-bce3ae129811, successor claim. Earlier Batch54/55 reports below remain historical and retain their stated limits.Verification: 55 focused tests passed (composer actions/dictation, native gesture boundaries, style and system-text guards); mobile typecheck and repository lint passed (existing unrelated lint warnings remain). Expo's pinned Babel preset compiles all eight gesture/reaction worklets. All applicable CI39736127350 jobs also passed, including mobile verification and isolated Host smoke. These are automated checks, not native device acceptance.
Batch54 — native composer, light, 402 × 874 pt
Before — React Native action controls, with the same integrated island and two-line draft.
After — SwiftUI action buttons in the same island; the existing text input and draft are preserved.
Actual iOS 27 Simulator captures, English, system text size
large, same synthetic chat, viewport and visible software keyboard; the blinking caret/status-bar return affordance can differ. Befored402bb92d80aremoves only #2576 from Afterea36821ea929. Both share qualified native fingerprint2ab2d67bec3aand installed executable SHA256cbf75e97a9776956bca0bcdf081a0dc5da2a6ba858d5bf4fbd26a58e3e5c62e7(native build source683b0cbe9c0f). This Human-approved compatible comparison excludes later main splash inputs: scoped evidence, not latest-main/release acceptance. Exact provenance and partial results.Draft/keyboard/multiline, expansion/return and attachment-menu interactions were captured on both versions. Before send/direct DeepSeek reply and exact canonical message passed. Further After send/attachment/return-button acceptance is still being completed by the sole runner. The initial dark keyboard mismatch has been corrected in the matched pair below. Physical microphone, VoiceOver, CJK IME and Android remain untested.
Recording investigation remains open: actual short taps and an 800ms hold reached
onHeld/finalization but notonStartor native speech; the callback observer remained installed. The pinned RNGH 3.3 iOS touch-down event precedes BEGAN, and early activation is ignored. Repair #2592 moves activation toonBegin; its regression reproduces the missing-start failure and passes after the fix, but unified native retesting is pending. This is distinct from Batch51's historical immediate termination. Stop, lock, cancel and transcription cannot be accepted until recording starts. No success-state recording screenshot has been fabricated.Batch54 — native composer, dark, 402 × 874 pt
Before — React Native action controls, multiline draft and dark software keyboard.
After — SwiftUI action controls with the same draft, caret position and dark keyboard.
Both are actual native Batch54 captures with the same English locale, system text size
large, 402 × 874 pt viewport, synthetic chat, two-line draft, end-position caret and keyboard candidates. Befored402bb92d80a/ Afterea36821ea929; native fingerprint2ab2d67bec3a, executablecbf75e97a977…, matching the full binary identity above. Updated provenance and limitations. These compare composer controls; they are not evidence of successful recording or latest-main/release acceptance.Task:
codex/local/01a1621c-a81b-7670-86be-1ddaf404c2e2.Batch55 update — recording startup still fails
This result supersedes the earlier pending-retest status: native Batch55 on source
87724a3b58d5(including #2592) still produced only onHeld/finalize on real short tap and 800ms hold, with no onStart, availability/permission calls or native speech events. The observer stayed installed/current, the loaded Hermes code contains #2592, and both observers were stopped/restored. Historical immediate-end remains a separate unlocated symptom; no successful recording state is claimed.The Human also reported the offset/clipped microphone. Merged repair #2595, issue #2594, replaces the iOS manual gesture with a centered native SwiftUI button (tap start / tap stop, explicit cancel). Its Batch56 native result is recorded above; sustained recording remains unaccepted.
Actual failure state — light, large text, 402 × 874 pt, keyboard hidden; Debug strict fingerprint
b3e74315f0c2, final signed executable55de08577ac5. This image is a failure baseline, not an After-success comparison. Provenance.