feat(admin): tabs in the Add peer dialog, status beside Info, no autofill (CLEAN-98) - #91
Merged
Merged
Conversation
…fill (CLEAN-98) Three things the dialog got wrong once a ranch had more than a handful of agents. The address form sat at the bottom of the same scrolling column as the candidate list, so on a ranch with a dozen agents nothing on the first screen said an external import existed at all. The two ways in are now tabs — "On this ranch" and "External agent" — with the dialog description saying what the open tab does. With nothing left to connect on this ranch the dialog opens on the address tab, unless the operator has already picked one themselves. In a candidate row the status badge trailed the agent name, so it landed at a different distance in every row while the Info chip stayed on the right edge. Status now rides with that chip: name on the left, status + Info on the right, lined up down the whole list. The card address field sits directly above a password field, which is exactly the shape Chrome and the password managers read as a login form — they were dropping a saved account into it. Both fields now carry autocomplete off (new-password on the credential) plus the 1Password/LastPass/Dashlane ignore attributes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SZ9dCrzZqd5SwR4erLYe12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three UX defects in the Add peer dialog of the Peers tab, found while testing external imports on CLEAN-97.
Tabs instead of one scrolling column
The address form sat at the bottom of the same scrolling column as the candidate list. On a ranch with a dozen agents nothing on the first screen said an external import existed at all. The two paths are now tabs at the top — On this ranch and External agent — and the dialog description says what the open tab does. The ranch tab carries the count of agents still available. With nothing left to connect on this ranch the dialog opens on the address tab, unless the operator has already picked a tab themselves.
Status beside Info
In a candidate row the status badge trailed the agent name, so it landed at a different distance in every row while the Info chip stayed on the right edge. Status now rides with that chip: name on the left, status + Info on the right, lined up down the list.
No browser autofill on the import fields
The card address field sits directly above a password field — exactly the shape Chrome and the password managers read as a login form, and they were dropping a saved account into it. Both fields now carry
autocompleteoff (new-passwordon the credential) plus the 1Password / LastPass / Dashlane ignore attributes.Verification
npx nuxt typecheckinadmin: no error from this change. The one error it reports,slices/reins/data/knowledge.gateway.ts(retrying), is pre-existing onmain— the committed SDK has been stale since CLEAN-96; with a freshly generated SDK the console typechecks clean.Jira: CLEAN-98
🤖 Generated with Claude Code
https://claude.ai/code/session_01SZ9dCrzZqd5SwR4erLYe12