Repository navigation
Conversation
The information icon left strokeWidth unset on two of its three paths, so they fell back to the SVG default of 1 while the rest of the icon set uses 1.5. At the 16px size Alert renders it, the stem came out about 0.67px.
🦋 Changeset detectedLatest commit: fcbeca6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
3 of 8 tasks
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
informationicon had nostrokeWidthon two of its three paths, so they fell back to the SVG default of 1 while the rest of the icon set uses 1.5 (171 of 177 icons)strokeWidth={1.5}to those two paths, nothing else in the icon changesLinks and tickets
None, I didn't find an existing issue for this
Good to know
informationicon, it's the default icon for the neutral and info statesChecklist
Contribution
buildandbuild-storybookwork locallyAccessibility
The icon is
aria-hiddeninside Alert, so names and keyboard behavior don't change. The stem is now easier to see at 16px.aria-labelScreenshots
Before and after at Alert size and at 4x, with the warning icon for reference
Note
Low Risk
Single-icon SVG stroke tweak with no API or behavior changes; only expected visual snapshot diffs.
Overview
Sets
strokeWidth={1.5}on the twoInformationSVG paths that were still using the default 1px stroke, so the icon matches the rest of the click-ui set (including the path that already had 1.5).The stem and dot in neutral/info **
Alert**s (16px) should no longer look thinner or uneven next to warning/check icons. A patch changeset notes the visual fix for@clickhouse/click-ui.Reviewed by Cursor Bugbot for commit fcbeca6. Bugbot is set up for automated code reviews on this repo. Configure here.