Skip to content

fix(Icon): match information icon stroke to the icon set - #1283

Closed
kachdan wants to merge 1 commit into
ClickHouse:mainfrom
kachdan:fix/information-icon-stroke
Closed

kachdan wants to merge 1 commit into
ClickHouse:mainfrom
kachdan:fix/information-icon-stroke

Conversation

@kachdan

@kachdan kachdan commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Description

  • The information icon had no strokeWidth on two of its three paths, so they fell back to the SVG default of 1 while the rest of the icon set uses 1.5 (171 of 177 icons)
  • Alert renders it at 16px, so the stem came out about 0.67px and looked a lot thinner than the warning and check icons next to it, the dot was also drawn from two halves with different widths so it was a bit lopsided
  • Added strokeWidth={1.5} to those two paths, nothing else in the icon changes

Links and tickets

None, I didn't find an existing issue for this

Good to know

  • Alert is the only component that uses the information icon, it's the default icon for the neutral and info states
  • The Alert visual specs that show that icon will have a diff, that's the intended change. I couldn't run the Docker visual tests on my side so the snapshots aren't regenerated in this PR
  • I also didn't run the full local checks, the change is one prop on two SVG paths and the before and after below is rendered from the actual paths

Checklist

  • Breaking changes? (add migration notes in changesets)
  • Visual changes? (specify in changesets)
  • Design review needed?

Contribution

  • Sufficient research before PR
  • Self-reviewed the PR
  • Manually tested the changes (when applies - visual confirmation in Storybook)
  • build and build-storybook work locally
  • Tests and Stories are aligned with the changes

Accessibility

The icon is aria-hidden inside Alert, so names and keyboard behavior don't change. The stem is now easier to see at 16px.

  • Keyboard - every action works with Tab / Enter / Space / Esc; focus is visible and returns to the trigger on close
  • Names — every control has a name that includes its visible label; icon-only controls take aria-label
  • Vision — colors come from tokens, focus ring shows, targets are at least 24×24 px

Screenshots

Before and after at Alert size and at 4x, with the warning icon for reference

information-icon-before-after

Note

Low Risk
Single-icon SVG stroke tweak with no API or behavior changes; only expected visual snapshot diffs.

Overview
Sets strokeWidth={1.5} on the two Information SVG paths that were still using the default 1px stroke, so the icon matches the rest of the click-ui set (including the path that already had 1.5).

The stem and dot in neutral/info **Alert**s (16px) should no longer look thinner or uneven next to warning/check icons. A patch changeset notes the visual fix for @clickhouse/click-ui.

Reviewed by Cursor Bugbot for commit fcbeca6. Bugbot is set up for automated code reviews on this repo. Configure here.

The information icon left strokeWidth unset on two of its three paths, so
they fell back to the SVG default of 1 while the rest of the icon set uses
1.5. At the 16px size Alert renders it, the stem came out about 0.67px.
@CLAassistant

CLAassistant commented Oct 27, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@changeset-bot

changeset-bot Bot commented Oct 27, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: fcbeca6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clickhouse/click-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@XOP

XOP commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Hi @kachdan , thank you, appreciate the contribution,
this issue is addressed alternatively:
#1290

the fate of this exact icon remain under question so far :) furthermore, we'll need to fix the origin in Figma first.

@XOP XOP closed this Nov 5, 2026
@XOP XOP added the wontfix This will not be worked on label Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wontfix This will not be worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants