Repository navigation
fix: Alert icons update - #1290
Conversation
🦋 Changeset detectedLatest commit: 3447561 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Letting @danielclickh take this one :) |
|
Hi @XOP, I still see the information icon in storybook, should it still be there? Size adjustment looks good to me! |
|
@danielclickh yes, one don't remove the icon, as it's breaking changes; it was not in the scope. We can wdyt? |
|
I wonder what others think about it - I tend to prefer to completely remove it, this way we make sure none of us is going to ended up using it somewhere else. |
|
just to confirm @danielclickh @DreaminDani
what I suggest to do:
SG? |
|
Sounds good ot me @XOP ! |
|
@danielclickh please approve this one if no further comments, |
Storybook Preview Deployed✅ Preview URL: https://click-cu9gp9fp1-clickhouse.vercel.app Built from commit: |
Chromatic Storybook
Built from commit: Statuses as of the end of the run. The build link shows the live review state. |
Description
info-in-circleinstead ofinformation.customIconfollowsize:sm(16px) ormd(20px).Alert.test.tsxchecks the icon for each state and size. 16 Alert PNGs changed.Links and tickets
Checklist
info-in-circleand the 20px medium size against Figma.Contribution
buildandbuild-storybookwork locallyAccessibility
aria-hidden; the dismiss button keepsaria-label="close".Screenshots
See the VRT diff
Note
Low Risk
Scoped visual and icon-mapping changes in Alert only, with no behavioral or security impact.
Overview
Neutral and info alerts now render the
info-in-circleglyph instead ofinformation. Medium alerts use a 20px state icon (andcustomIcon) viamdsizing; small stays 16px. Consumers who want the old look can passcustomIcon="information".Tests cover the state→icon mapping, size wrapper classes, and the default small
info-in-circle. A minor changeset notes the visual change (Fixes #546).Reviewed by Cursor Bugbot for commit 3447561. Bugbot is set up for automated code reviews on this repo. Configure here.