Skip to content

fix: Alert icons update - #1290

Merged
XOP merged 3 commits into
mainfrom
fix/issue-546-alert-icon
Nov 16, 2026
Merged

XOP merged 3 commits into
mainfrom
fix/issue-546-alert-icon

Conversation

@XOP

@XOP XOP commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Description

  • Alert: neutral and info states show info-in-circle instead of information.
  • Alert: the state icon and customIcon follow size: sm (16px) or md (20px).
  • Tests: Alert.test.tsx checks the icon for each state and size. 16 Alert PNGs changed.

Links and tickets

Checklist

  • Breaking changes? (add migration notes in changesets) No.
  • Visual changes? (specify in changesets) Yes: circled "i" on neutral and info; 20px state icon on medium alerts.
  • Design review needed? Yes, to confirm info-in-circle and the 20px medium size against Figma.

Contribution

  • Sufficient research before PR
  • Self-reviewed the PR
  • Manually tested the changes (when applies - visual confirmation in Storybook)
  • build and build-storybook work locally
  • Tests and Stories are aligned with the changes

Accessibility

  • Keyboard - … — not tested. No behavior change; the dismiss button is unchanged.
  • Names - … — the state icon stays aria-hidden; the dismiss button keeps aria-label="close".
  • Vision - … — icon colors and sizes come from tokens. Focus ring, target size and the Storybook axe panel were not checked.

Screenshots

See the VRT diff


Note

Low Risk
Scoped visual and icon-mapping changes in Alert only, with no behavioral or security impact.

Overview
Neutral and info alerts now render the info-in-circle glyph instead of information. Medium alerts use a 20px state icon (and customIcon) via md sizing; small stays 16px. Consumers who want the old look can pass customIcon="information".

Tests cover the state→icon mapping, size wrapper classes, and the default small info-in-circle. A minor changeset notes the visual change (Fixes #546).

Reviewed by Cursor Bugbot for commit 3447561. Bugbot is set up for automated code reviews on this repo. Configure here.

@XOP XOP added bug Something isn't working icons and assets labels Nov 4, 2026
@changeset-bot

changeset-bot Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 3447561

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clickhouse/click-ui Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@DreaminDani

Copy link
Copy Markdown
Contributor

Letting @danielclickh take this one :)

@DreaminDani
DreaminDani removed their request for review November 4, 2026 17:18

Copy link
Copy Markdown

Screenshot 2026-11-05 at 13.52.48.png

Hi @XOP, I still see the information icon in storybook, should it still be there? Size adjustment looks good to me!

@XOP

XOP commented Nov 5, 2026

Copy link
Copy Markdown
Contributor Author

@danielclickh yes, one don't remove the icon, as it's breaking changes; it was not in the scope.
it isn't used internally, but can be used in projects.

We can
A) update it (the glyph itself both in Figma and code)
and B) deprecate it -> remove completely in the next release.

wdyt?

Copy link
Copy Markdown

I wonder what others think about it - I tend to prefer to completely remove it, this way we make sure none of us is going to ended up using it somewhere else.

@DreaminDani @crisalbu @elizabetdev thoughts?

@XOP

XOP commented Nov 12, 2026

Copy link
Copy Markdown
Contributor Author

just to confirm @danielclickh @DreaminDani

  • removing "information" icon
  • in the project replacing with "info-in-circle"
    then it leaves us with the odd name, implying there's some other kind of info icon, which is not there.

what I suggest to do:

  • remove current "i" icon and only use ℹ️
  • rename info-in-circle to info (preferable, not used now) or information
  • update all usages in project(s)

SG?

@danielclickh

Copy link
Copy Markdown

Sounds good ot me @XOP !

@XOP

XOP commented Nov 13, 2026

Copy link
Copy Markdown
Contributor Author

@danielclickh please approve this one if no further comments,
I will update the icon in a separate breaking PR

@workflow-authentication-public

Copy link
Copy Markdown
Contributor

Storybook Preview Deployed

✅ Preview URL: https://click-cu9gp9fp1-clickhouse.vercel.app

Built from commit: 54f2b20f3e7510158f1d5dc2d6d644511cf6f554

@workflow-authentication-public

Copy link
Copy Markdown
Contributor

Chromatic Storybook

Check Status Link
Storybook ✅ 670 stories published Open Storybook
UI Tests ⏳ 8 changes must be accepted as baselines Open build

Built from commit: 3447561ca2ad6e506dbb4757f02edadcde8d4260 · Chromatic run

Statuses as of the end of the run. The build link shows the live review state.

@XOP
XOP merged commit 85aa466 into main Nov 16, 2026
11 checks passed
@XOP
XOP deleted the fix/issue-546-alert-icon branch November 16, 2026 11:42
@cursor cursor Bot mentioned this pull request Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working icons and assets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Alert icon appears smaller than expected, possible render bug

3 participants