Skip to content

C5: Rewrite guidance suite and repo content to v2 (Effect-first) #28

Closed

Description

@diegohb

Parent

Part of #23 (Spec: opencode-architect 1.0.0)

What to build

All bundled references, the oneshots, and the conformance checklist rewritten in place to v2 facts drawn from the verified-facts record: the v1 singular-key checklist item is inverted (v2 plural registration key becomes conformant) and new v2 items added (Effect plugin definition, permissions array, JSON-Schema tool arguments). Repo content updates land here too: ADR-0012 (v2-native, drop v1 hosts), glossary additions and renames (plugin registration key, plugin definition shape, tool registration), superseding notes on ADR-0010/0011, README, CONTRIBUTING, and AGENTS.md content. Effect-first throughout; general Effect-TS teaching defers to the repo's effect-ts skill. No v1 archive ΓÇö git history is the archive. Every changed fact traces to the verified-facts record.

Acceptance criteria

  • No known-false v1 claims remain in references, oneshots, or checklist
  • Every changed API fact cites the verified-facts record
  • ADR-0012, glossary updates, and ADR-0010/0011 superseding notes written
  • README, CONTRIBUTING, AGENTS.md content consistent with v2
  • Docs-fact gate (C5 of testing seams) passes

Blocked by

  • #C4

Activity

  1. diegohb commented on Oct 6, 2026

    @diegohb
    MemberAuthor

    Acceptance criteria verified (C5, #28)

    All five boxes checked off. Evidence per criterion:

    1. No known-false v1 claims remain in references, oneshots, or checklist — the docs-fact gate (tests/docs-fact-gate.test.ts + tests/docs-fact-gate.ts) scans all of references/*.md plus README/AGENTS.md/CONTRIBUTING/CONTEXT.md for known-false v1 assertion forms (v1 package name, singular config keys emitted as keys, tool.schema, config.json outside read-only legacy advisories, v1 hook/frontmatter assertion forms, pinned consumer versions) with documented migration-mapping exemptions. 3/3 tests green on cb5c59e.
    2. Every changed API fact cites the verified-facts record — all 10 API-teaching references assert facts under a "facts per opencode-v2-facts §N" citation; the gate's citation test enforces it. New adjudications were extended into §13 (row 10: legacy plugin read-only tolerance) rather than resolved locally, per §15.
    3. ADR-0012, glossary updates, superseding notes — docs/adr/0012-v2-native-only.md written; ADR-0010 and ADR-0011 each carry a superseding note (v2 default-export contract, facts §2; mandatory exports["./server"], facts §13.9/§14.6); glossary gained plugin registration key, plugin definition shape, tool registration, with Plugin install / Partial cache artifact / Zero-write no-op reworded for v2.
    4. README, CONTRIBUTING, AGENTS.md consistent with v2 — README: v2 docs badge link, Effect-first intro, plugin-registered tool rows; CONTRIBUTING.md created (fact policy, gates, Effect-first style); AGENTS.md: plugin-registered tools, Effect-first definition, entry/exports["./server"] packaging.
    5. Docs-fact gate passes — bun test tests/docs-fact-gate.test.ts → 3 pass, 0 fail; bun run check clean; full bun test at the pre-existing win32 baseline only (5 environment failures verified identical on base commit 72bb363, tracked in Win32-only test failures: tarball path resolution and chmod-based removal-failure injection #36; ubuntu CI unaffected).

    Effect-first throughout; general Effect-TS teaching defers to the repo's effect-ts skill by reference (maintainer-installed precondition, spec #23). Templates and agent definitions untouched (C6/C7 scope). Work in 17 commits on v2/issue-28-rewrite-guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    ready-for-agentFully specified, ready for an AFK agent

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions