Repository navigation
Desktop: nothing redraws when idle, cheaper theme changes (#474) - #489
Merged
Merged
Conversation
The caret blink and the frame hook kept the window repainting at 8 fps forever with the composer focused. The caret now blinks without a full window refresh and stops after inactivity; the frame hook is no longer a never-ending fyne.Animation. Patches the vendored Fyne (third_party/fyne: widget cursor animation, common canvas, driver refresh counter). Assisted-by: Claude Opus 5.5 low
Fyne cleared the measured text sizes with the icons on every theme change, and ThemeOverride reset every cache once per widget under it (thousands for the transcript). A new ResetThemeColourCaches drops the themed icons only, once per override apply. The theme folder is watched with fsnotify instead of polled (go.mod: fsnotify now direct). Assisted-by: Claude Opus 5.5 low
Conflict in glfw/loop.go settings listener: kept both the VariantOnly early return and the KeepFonts cache reset.
This was referenced Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #474. Stacked on
perf/audit(#477 audit, not merged yet).What changes
fyne.Animation. Patched in the vendored Fyne: cursor animation, common canvas, driver refresh counter.ResetThemeColourCachesdrops only the themed icons and keeps the measured text sizes, which are keyed by font and size.ThemeOverridenow resets caches once per apply instead of once per descendant widget (thousands under the transcript). When the fonts are unchanged,repaintkeeps the text that was already shaped.Measured on VM 111 (llvmpipe, 4,000 rows / 200 chats)
Not done (follow-ups in #474)
Checks: gofmt clean,
go vetandgo test ./internal/ui/pass. The touched Fyne packages have no tests.Assisted-by: Claude Opus 5.5 low
🤖 Generated with Claude Code