Repository navigation
Reject invalid burndown dimensions before generating bars - #4226
Merged
djmitche merged 1 commit intoNov 13, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #4224; follow-up to #4225 and the suggestion to reject invalid dimensions before generating dates.
An annual burndown at width 200 and height 1 can reach the date library's lower-year assertion before
render()rejects the short window. Unlimited or excessively tall heights take the same path before their size diagnostic.Extend the existing early guard in
Chart::generateBars()to cover the four size limits already used byrender(). Existing limits and diagnostic messages are preserved.Regression tests cover too-short, unlimited, and too-tall heights across all four report periods. Additional controls check the minimum and maximum drawable graph heights. The failing annual cases use a fixed clock so the regression remains reproducible as the current year changes.
Validation:
git diff --checkpass.Valid-size annual charts reaching the historical date boundary remain a separate problem. This PR does not claim to resolve every scenario in #4224.