Repository navigation
ui: give the console a flight-deck visual system (#547) - #911
Conversation
|
Written-by: HugoXK @HugoXK-bot open PR queue, oldest first:
Please take them in that order and name the blocking sentence when you request changes. |
HugoXK-bot
left a comment
There was a problem hiding this comment.
Verdict: REQUEST_CHANGES at 81ecfdd
Written-by: Fledge Platform Reviewer
Posted-by: HugoXK-bot
Blocking: public/app.css:725 paints the current setup step's 12 px step mark in --accent-ink (#f4f8f2) on --accent (#8fbfa8, src/ tokens at public/app.css:54), which is 1.92:1 in the dark scheme — under the 4.5:1 floor for text and under even the 3:1 large-text floor — because the flight-deck palette made --accent a light sage while leaving --accent-ink light; use --mark-ink there instead (#0b100e on #8fbfa8 = 9.3:1, and #ffffff on the light #2f6b57 = 6.25:1), and add the --accent-ink/--accent pair to the contrast loop at test/uiTokens.test.ts:322-325 so the AA test can catch it.
That is the only pair I found below AA. I scanned every rule that sets both color: and background(-color): from tokens, in both schemes, and the rest clears 4.5:1: --text on all eight surfaces 14.6–16.4:1, --accent as link ink 9.3:1 dark / 5.5:1 light, --accent-ink on --accent-strong 5.8:1 dark / 6.3:1 light, --danger 7.4:1 / 5.4:1, --warn 8.7:1 / 5.0:1.
Non-blocking notes, recorded so they are not lost:
.loop-rail .loop-step[data-state="done"] .dotand[data-state="current"] .dotsetcolorandbackgroundto the same token (public/app.css:905-906); harmless while the dot is an emptyaria-hiddenspan, invisible by construction the moment text goes in it.loopRail()(src/views/pages.ts:1015-1036) maps every kind outside setup/quota/questions/job/alert tomerge, so aclearnext action renders the rail with Merge as the current step.- The vendored
.agents/skills/**text (Apache-2.0 / MIT, licences kept) is 400+ lines of non-code; that is within rule 7, but it is now the tier basis (risk-tier: T2; basis: .agents/skills/README.md).
Ran:
npm run check— pass, exit 0,# tests 2434/# pass 2434/# fail 0node scripts/risk-gate.mjs --base 482488ad --head HEAD—risk-tier: T2; basis: .agents/skills/README.mdGITHUB_REPOSITORY=HugoXK/fledge GITHUB_EVENT_NAME=merge_group … node scripts/pr-lint.mjs --pr 911—pr-lint: ok (#911, T2, 20 files; tracks #547, closes nothing)node scripts/changelog.mjs check—changelog: 28 fragment(s) oknode scripts/version.mjs check—version: 0.4.0 oknode scripts/secret-scan.mjs—secret:scan: no suspected value in the tracked files- contrast computed from the token values in this tip's
public/app.cssfor everycolor/backgroundtoken pair, both schemes
Not run: the browser visual matrix, a real phone, the regenerated mock/ (it belongs to the release routine, per docs/deploy.md).
HugoXK-bot
left a comment
There was a problem hiding this comment.
Verdict: REQUEST_CHANGES at 81ecfdd
Written-by: HugoXK-bot
Posted-by: HugoXK-bot
Replaces: 5917419834 (same tip; its second line named a writer the policy does not list)
Blocking: public/app.css:725 paints the current setup step's 12 px step mark in --accent-ink (#f4f8f2) on --accent (#8fbfa8, src/ tokens at public/app.css:54), which is 1.92:1 in the dark scheme — under the 4.5:1 floor for text and under even the 3:1 large-text floor — because the flight-deck palette made --accent a light sage while leaving --accent-ink light; use --mark-ink there instead (#0b100e on #8fbfa8 = 9.3:1, and #ffffff on the light #2f6b57 = 6.25:1), and add the --accent-ink/--accent pair to the contrast loop at test/uiTokens.test.ts:322-325 so the AA test can catch it.
That is the only pair I found below AA. I scanned every rule that sets both color: and background(-color): from tokens, in both schemes, and the rest clears 4.5:1: --text on all eight surfaces 14.6–16.4:1, --accent as link ink 9.3:1 dark / 5.5:1 light, --accent-ink on --accent-strong 5.8:1 dark / 6.3:1 light, --danger 7.4:1 / 5.4:1, --warn 8.7:1 / 5.0:1.
Non-blocking notes, recorded so they are not lost:
.loop-rail .loop-step[data-state="done"] .dotand[data-state="current"] .dotsetcolorandbackgroundto the same token (public/app.css:905-906); harmless while the dot is an emptyaria-hiddenspan, invisible by construction the moment text goes in it.loopRail()(src/views/pages.ts:1015-1036) maps every kind outside setup/quota/questions/job/alert tomerge, so aclearnext action renders the rail with Merge as the current step.- The vendored
.agents/skills/**text (Apache-2.0 / MIT, licences kept) is 400+ lines of non-code; that is within rule 7, but it is now the tier basis (risk-tier: T2; basis: .agents/skills/README.md).
Ran:
npm run check— pass, exit 0,# tests 2434/# pass 2434/# fail 0node scripts/risk-gate.mjs --base 482488ad --head HEAD—risk-tier: T2; basis: .agents/skills/README.mdGITHUB_REPOSITORY=HugoXK/fledge GITHUB_EVENT_NAME=merge_group … node scripts/pr-lint.mjs --pr 911—pr-lint: ok (#911, T2, 20 files; tracks #547, closes nothing)node scripts/changelog.mjs check—changelog: 28 fragment(s) oknode scripts/version.mjs check—version: 0.4.0 oknode scripts/secret-scan.mjs—secret:scan: no suspected value in the tracked files- contrast computed from the token values in this tip's
public/app.cssfor everycolor/backgroundtoken pair, both schemes
Not run: the browser visual matrix, a real phone, the regenerated mock/ (it belongs to the release routine, per docs/deploy.md).
The current step's mark painted --accent-ink on --accent: 1.92:1 at the 12px mark, under the 4.5:1 AA floor, while --mark-ink on the same sage fill is 9.30:1. Only that foreground moves; the rest of the flight deck is untouched. test/uiTokens.test.ts widens the AA guard beyond the --muted-2 surfaces to every rule that paints a token colour on a token background, in both palettes, and reads the palette with the line-anchored reader because the :root block holds a semicolon inside a comment. The guard fails at 81ecfdd with 1.92:1 and passes with the swap. Written-by: HugoXK Fixed-by: Fledge Platform Dev-2
Brings the branch up to live main so the PR is mergeable and ci-ok can run. Seven conflicted paths, resolved without a judgement call: public/app.css keeps both sides (the branch's two media blocks, then main's #264 .review-merge rules), src/views/pages.ts takes main's import line because it is a superset of the branch's, and every release-machinery path (.github/workflows/daily-release.yml, .github/workflows/release.yml, docs/deploy.md, test/dailyRelease.test.ts, test/releasePublishGuard.test.ts, test/releaseTagPlan.test.ts, changelog.d/866-finish-half-made-release.fixed.md, scripts/lib/release-tag.mjs, scripts/lib/release-tag.d.mts) keeps main's side: the branch tree predates #866/#909 and would otherwise rewind merged release work. The two files of the fix (public/app.css setup-mark ink, the widened AA guard in test/uiTokens.test.ts) are unchanged, and the changelog fragment is in this tree. Written-by: HugoXK Fixed-by: Fledge Platform Dev-2
HugoXK-bot
left a comment
There was a problem hiding this comment.
Verdict: PASS at 2d6f4dd
Written-by: HugoXK-bot
Author: Fledge Platform Verdict
Replaces: 81ecfdd (REQUEST_CHANGES)
The only blocking pair is fixed: public/app.css:725 paints the current setup mark in --mark-ink (:61, :203, :249) on --accent — 9.30:1 dark, 6.25:1 light, against 1.92:1 at the old review.
The guard the review asked for is in and live: test/uiTokens.test.ts:126-153 scans every rule that sets both color: and background: from tokens in both palettes; putting --accent-ink back at :725 makes it fail by name with that same 1.92:1.
The tip cannot rewind main: the compare from 6097aa21 is 4 ahead / 0 behind with the same 21 files, so no release-machinery path (release.yml, scripts/lib/release-tag.mjs, test/releaseTagPlan.test.ts, changelog.d/866-*, changelog.d/909-*) is touched, and src/views/theme.ts:21 matches the new --bg in both palettes.
At this sha ci-ok has two success records (started 00:18:51Z, 00:19:27Z) with pr-lint, test (24), coverage, visual and codeql-required green; the only red is review-gate reporting the stale 81ecfdd0 conclusion this replaces.
Non-blocking: loopRail maps a clear next action to the merge stage (src/views/pages.ts:1040-1045), so the all-clear dashboard shows Merge as current; and the new scan reads :root plus [data-theme="light"] only, leaving the prefers-color-scheme light block unguarded against drift (its tokens are identical today).
Ran:
- node --test test/uiTokens.test.ts — 9/9 pass at this tip; with
:725reverted to--accent-inkthe same run is 8/9 and namesdark .setup-step.is-current .setup-mark: --accent-ink on --accent = 1.92:1 (needs 4.5) - node /tmp/scan911.mjs — 60 token ink/fill pairs over the dark, media-light and attribute-light palettes: 0 below 4.5:1, and the two light blocks agree on every token
Not run: npm ci and the full local suite (CI's test (24) and coverage cover this sha); the browser visual matrix, a real phone, and the regenerated mock/ (release routine).
Written-by: HugoXK
Part of #547. This is the flight-deck visual foundation, not the whole UI overhaul.
What changed:
.agents/skills/frontend-design(Apache-2.0) and.agents/skills/web-interface-guidelines(MIT), with their licences. A copy is on the server DSH at~/.dsh/skills.docs/design/flight-deck.mdrecords the brief, the skill review, the palette, the loop rail and the follow-ups.THEME_COLORSanddocs/ui.mdfollow.overscroll-behavior: contain, and reduced motion is respected.The generated
mock/is deliberately not regenerated here:docs/deploy.mdassigns the snapshot to the release routine once per release, andmock:checkis a release check, not a per-feature-PR gate. The committed mock stays the previous release snapshot until that routine runs.Large-PR: 20 files, ~1,418 changed lines; the review target is
public/app.css,src/views/pages.ts,src/views/theme.tsand the token/mock tests; the generatedmock/mirrors the CSS and views.Ran:
npm run check— 2432/2434 pass; the 2 failures are pre-existing macOS environment failures (test/gateBaseTree.test.ts,test/nginxCheck.test.ts) that also fail on a cleanmain.node scripts/risk-gate.mjs --base server-gh/server-deploy—risk-tier: T2(base482488a=main)node scripts/version.mjs check— oknpm run secret:scan— cleannode scripts/changelog.mjs check— 28 fragments okNot run:
visualjob will run it.Risk: T2; a PASS at the tip is required. I did not post a PASS, add
review:approved/agent-ready, or merge this branch.Fixed-by: Fledge Platform Dev-2
The setup-mark contrast fix and its widened AA guard sit at this tip, after the merge of main
6097aa21c9cc0a2ff0413f8b6014bb28cd9c578c.public/app.csspaints the current setup step's mark in--mark-inkon the--accentfill (9.30:1 in the dark palette; the pair it replaced was 1.92:1),test/uiTokens.test.tsnow scans every token ink painted on a token fill in both palettes (red at81ecfdd0:# fail 1, "dark .setup-step.is-current .setup-mark: --accent-ink on --accent = 1.92:1"), andchangelog.d/911-setup-mark-contrast.fixed.mdrecords the change.The merge of main keeps main's side of every release-machinery path (#866/#909:
.github/workflows/daily-release.yml,.github/workflows/release.yml,docs/deploy.md,test/dailyRelease.test.ts,test/releasePublishGuard.test.ts,test/releaseTagPlan.test.ts,changelog.d/866-finish-half-made-release.fixed.md,scripts/lib/release-tag.mjs,scripts/lib/release-tag.d.mts) because this branch's tree predates those commits and merging it as pushed would have rewound them.public/app.cssneeded both sides (the branch's two media blocks, then main's #264.review-mergerules);src/views/pages.tstakes main's import line without the two identifiers this branch's body no longer uses. At the new tip,git diffagainst main touches only the 21 design files.