Skip to content

ci: check the UI mock in the nightly release routine (#777) - #912

Merged
HugoXK merged 1 commit into
mainfrom
ops/mock-release-check
Nov 16, 2026
Merged

HugoXK merged 1 commit into
mainfrom
ops/mock-release-check

Conversation

@HugoXK

@HugoXK HugoXK commented Nov 16, 2026

Copy link
Copy Markdown
Owner

Written-by: HugoXK

Part of #777. Makes the generated mock a real release artifact instead of a silent local command.

What changed:

  • The nightly release planner runs npm ci and npm run mock:check after the opener precondition and before it pushes release/v<version>. A stale mock is a red night that names npm run mock:snapshot and the docs pull request.
  • docs/deploy.md says the nightly check is the gate; the release routine regenerates the snapshot in a docs pull request, and normal feature PRs do not touch mock/.
  • mock/ is regenerated from main at 482488a so the check is green at this tip. After the flight-deck UI (ui: give the console a flight-deck visual system (#547) #911) merges, a docs PR will regenerate the snapshot again; until then the nightly correctly reds instead of shipping a stale snapshot.

Why:

  • mock:check was a local-only command; no workflow called it, so the snapshot could drift silently.
  • Regenerating it in every UI PR was noisy and against docs/deploy.md; this keeps it once per release.

Ran:

  • npm run check — 2432/2434 pass; the 2 failures are pre-existing macOS environment failures (test/gateBaseTree.test.ts, test/nginxCheck.test.ts) that also fail on a clean main.
  • npm run mock:check — ok (12 files)
  • node scripts/risk-gate.mjs --base server-gh/server-deploy — risk-tier: T3 (base 482488a = main)
  • node scripts/version.mjs check — ok
  • npm run secret:scan — clean
  • node scripts/changelog.mjs check — 27 fragments ok

Not run:

  • A nightly run; the new step runs on the next planned release.
  • GitHub Actions (the PR runs CI).

Risk: T3 (.github/workflows/daily-release.yml). I did not post a PASS, add review:approved/agent-ready, or merge this branch.

@HugoXK

HugoXK commented Nov 16, 2026

Copy link
Copy Markdown
Owner Author

Written-by: HugoXK

@HugoXK-bot open PR queue, oldest first:

  1. feat: add a superadmin one-click release action #908 — T3 one-click release, all checks green except review-gate; needs PASS at the tip.
  2. fix(security): refuse a covering TRUST_PROXY and give unparseable addresses one bucket #910 — CHANGES_REQUESTED; re-review after the author updates the tip.
  3. ui: give the console a flight-deck visual system (#547) #911 — design/flight-deck.
  4. ci: check the UI mock in the nightly release routine (#777) #912 — ops/mock-release-check.

Please take them in that order and name the blocking sentence when you request changes.

@HugoXK-bot HugoXK-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: PASS at 73ee997
Written-by: Fledge Platform Reviewer
Posted-by: HugoXK-bot

I read the tip from the API this turn (73ee9971a494791d0bd84cdc5a50a2043b50839c, base 8213cec5, merge base 482488ad) and re-ran the gates myself rather than restating the body.

The gate itself is right: the new step sits after the opener precondition and is gated on steps.opener.outputs.ready == 'true' && inputs.dry_run != true (.github/workflows/daily-release.yml:359-370), so a dry run, a slot-shipped night and a publish night all skip it, and a stale snapshot exits 1 before the branch push — nothing is pushed and the slot is not consumed, which is the failure shape #333 wanted. set -euo pipefail plus the explicit ::error:: names the repair command. The step has no token in its environment: RELEASE_OPEN_TOKEN is referenced only in the opener step's env: even though the job is attached to the release environment, so npm ci never sees it. docs/deploy.md:342-348 matches the step.

Two notes that do not block this tip:

  • After the flight-deck UI lands (#911), mock/ is stale by construction and the next night reds until the docs pull request regenerates it; that is the documented policy, but it means the first night after that merge should be expected red rather than treated as an incident.
  • If npm ci itself fails, the step exits 1 without the ::error:: repair hint; the log still names the command, so it is readable.

Ran:

  • npm run check — pass, exit 0, # tests 2434 / # pass 2434 / # fail 0
  • npm run mock:check — mock-snapshot: ok (12 files)
  • node scripts/workflow-injection.mjs --workflows .github/workflows --allowlist .github/agent/workflow-injection-allowlist.json — workflow-injection: ok (9 workflow file(s), 2 allowlisted expression(s))
  • node scripts/risk-gate.mjs --base 482488ad --head HEAD — risk-tier: T3; basis: .github/workflows/daily-release.yml
  • GITHUB_REPOSITORY=HugoXK/fledge GITHUB_EVENT_NAME=merge_group … node scripts/pr-lint.mjs --pr 912 — pr-lint: ok (#912, T3, 12 files; tracks #777, closes nothing)
  • node scripts/changelog.mjs check — changelog: 27 fragment(s) ok
  • node scripts/version.mjs check — version: 0.4.0 ok
  • node scripts/secret-scan.mjs — secret:scan: no suspected value in the tracked files

Not run: a real nightly run (the step first executes on the next planned release), actionlint 1.7.12 (not installed here; the job's only new shell is npm ci plus the mock:check branch, with no ${{ }} inside it).

@HugoXK-bot HugoXK-bot added review:approved Issue reviewed and approved by the Fledge Platform Reviewer risk:T3 labels Nov 16, 2026

@HugoXK-bot HugoXK-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: PASS at 73ee997
Written-by: HugoXK-bot
Posted-by: HugoXK-bot
Replaces: 5917443193 (same tip; its second line named a writer the policy does not list)

I read the tip from the API this turn (73ee9971a494791d0bd84cdc5a50a2043b50839c, base 8213cec5, merge base 482488ad) and re-ran the gates myself rather than restating the body.

The gate itself is right: the new step sits after the opener precondition and is gated on steps.opener.outputs.ready == 'true' && inputs.dry_run != true (.github/workflows/daily-release.yml:359-370), so a dry run, a slot-shipped night and a publish night all skip it, and a stale snapshot exits 1 before the branch push — nothing is pushed and the slot is not consumed, which is the failure shape #333 wanted. set -euo pipefail plus the explicit ::error:: names the repair command. The step has no token in its environment: RELEASE_OPEN_TOKEN is referenced only in the opener step's env: even though the job is attached to the release environment, so npm ci never sees it. docs/deploy.md:342-348 matches the step.

Two notes that do not block this tip:

  • After the flight-deck UI lands (#911), mock/ is stale by construction and the next night reds until the docs pull request regenerates it; that is the documented policy, but it means the first night after that merge should be expected red rather than treated as an incident.
  • If npm ci itself fails, the step exits 1 without the ::error:: repair hint; the log still names the command, so it is readable.

Ran:

  • npm run check — pass, exit 0, # tests 2434 / # pass 2434 / # fail 0
  • npm run mock:check — mock-snapshot: ok (12 files)
  • node scripts/workflow-injection.mjs --workflows .github/workflows --allowlist .github/agent/workflow-injection-allowlist.json — workflow-injection: ok (9 workflow file(s), 2 allowlisted expression(s))
  • node scripts/risk-gate.mjs --base 482488ad --head HEAD — risk-tier: T3; basis: .github/workflows/daily-release.yml
  • GITHUB_REPOSITORY=HugoXK/fledge GITHUB_EVENT_NAME=merge_group … node scripts/pr-lint.mjs --pr 912 — pr-lint: ok (#912, T3, 12 files; tracks #777, closes nothing)
  • node scripts/changelog.mjs check — changelog: 27 fragment(s) ok
  • node scripts/version.mjs check — version: 0.4.0 ok
  • node scripts/secret-scan.mjs — secret:scan: no suspected value in the tracked files

Not run: a real nightly run (the step first executes on the next planned release), actionlint 1.7.12 (not installed here; the job's only new shell is npm ci plus the mock:check branch, with no ${{ }} inside it).

@HugoXK
HugoXK merged commit 433fbd9 into main Nov 16, 2026
39 of 41 checks passed
@HugoXK
HugoXK deleted the ops/mock-release-check branch November 16, 2026 09:23
HugoXK added a commit that referenced this pull request Nov 16, 2026
#921)

`daily-release.yml`'s mock-snapshot step was the only workflow install that
#916's sweep did not cover, because #912 landed while #916's checks were
computed against an earlier base. The step runs `npm run mock:check` over the
installed tree, so a dependency lifecycle script must not run first.

Docs-not-needed: the workflow's behaviour is unchanged; only the install flag
follows the rule the sweep already enforces.

Fixes #920
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved Issue reviewed and approved by the Fledge Platform Reviewer risk:T3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants