Repository navigation
feat(j5): choose which models custom Crew members can use - #757
bryantderosier merged 18 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
77ca1d6 to
5923fc3
Compare
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
4fa701e to
bd50f86
Compare
Panel review: #757Live (Astra, stack tip): with the list restricted, a custom member on an excluded model was refused on all four paths: propose, Process: FORK file table. Case 90 is written, but the file-table rows don't include it:
Docs nit: say the lists apply at creation only. Scope. #744 asked for models only. The reasoning-level list adds:
The panel would cut it or split it into its own PR. We've also raised it with Jackson. Nit: a persona seat can be refused after its route changes. Review panel for the #750–#762 stack, judged as the code that lands at |
bd50f86 to
423085c
Compare
476ed7d to
09dfd93
Compare
Add a project-scoped crewMemberModels setting (checked provider/model pairs, null until saved) and one J5 service that decides whether a resolved model may run a custom worker. Crew launches and additions, a plain j5_spawn_agent and a plain delegate_task call it; a persona that keeps its own model skips it. A refusal names the model, the project and the setting and lists what is eligible. delegate_task gets an optional authorizeTarget hook in upstream's delegateTask so the check sees the model the child will really run on. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…up (#744) A Models for custom members row in the Crews section of Agent Setup shows how many catalog models are checked, opens in place, lists each set-up provider's models with checkboxes, warns when a saved list leaves nothing eligible, and notes that personas and native subagents are outside the list. The roster card offers a custom member only the models its project allows. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…mits (#744) Rewrite the Crews definition, the agent tool contracts for j5_propose_crew, j5_request_crew_member, delegate_task and j5_spawn_agent, the persona follow-up note and the user guide. Record per provider that native subagents sit outside the list, and divergence D39 for the delegateTask hook. Each tool description gains one sentence on the eligible models. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
#744) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…#744) Cursor keeps it for the Claude models it lists. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
#744) A card that was drawn while the persona's primary provider was signed out freezes the fallback route into the seat. When the primary was back at approval the seat was compared with the primary alone and wrongly held to the models list. A persona seat now counts as unchanged when its provider and model match either of the persona's two routes; any other model is still checked. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…lies at creation only (#744) Add case 90 to the file-table rows of OrchestratorMcpService.ts, registration.test.ts and settings.ts, record projectSettings.test.ts, put D39's history line in date order, and say that a later model change, for example through t3_thread_configure, is not limited. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
09dfd93 to
76eabab
Compare
…-models layer The models decision moves to register D42 and FORK.md case 107, since j5/main took D39 and case 90 for other decisions. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…-models layer Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ch service (#744) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ing exported Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Summary
A Captain staffing a custom member, or an agent delegating to another provider, can pick any model in the catalog, and once additions and auto-approved launches skip the roster card I won't get a chance to correct it. This adds one list of the models custom workers may run on, and the platform enforces it everywhere a custom worker gets a model at creation. Closes #744.
This is stacked on #748, so the base is
j5/748-archive-removes-clean-worktrees. Reasoning levels are a separate follow-up in #770, stacked on this PR.crewMemberModels) holding checked(providerInstanceId, model)pairs. If nothing has been saved, every model is eligible, so nothing changes for existing users. Once I save a list, only checked models are eligible and a model that shows up in the catalog later starts unchecked. A saved list with nothing checked means nothing is eligible, and the row says so.crewAutoApprovein the mixed-scope state.CrewMemberModels.assertEligibleis called fromCrewLaunchService.resolveSelection(so preview, approval, auto-approve,j5_request_crew_memberand additions are all covered, including a custom seat that inherits the Captain's model), fromj5_spawn_agentwhen no persona is named, and fromdelegate_taskwhen no persona is named, including a model inherited from the parent.t3_thread_configure, is not limited. That's written in the docs.canUseToolsees the call and the requested model, but I couldn't confirm it fires in bypass mode and denying would need an adapter change, so it's written up as unverified and treated as not supported. crews.md says it per provider and the Agent Setup note says the list doesn't cover native subagents.Docs: crews.md AC24–AC28, the
j5_propose_crew,j5_request_crew_member,delegate_taskandj5_spawn_agentsections of agent-tools.md (one sentence each), and the persona docs' note on model allowlists.Evidence
At
76eabab0be, on top of #748, after the stack was rebased onto j5/main.vp run -r typecheck(the CI command) exits 0 here:cd apps/server && vp test run src/j5/a2a src/j5/agents src/mcpdelegate_task, a project override includingnull, a saved empty list, and an accepted retry. The persona case that failed on the old code is a fallback route frozen at proposal while the primary is back at approval. The real-orchestratordelegate_tasktest goes through the new hook.src/j5andsrc/components/settings), including a card test that a custom member's picker is filtered and a persona's isn't:cd apps/web && vp test run src/j5/crew src/j5/a2a src/components/settingsobservability.memorytest failed once under load and passes alone) (vp test runin each package).projectSettings.test.tsnow checks that a shorter list replaces rather than merges.Not verified: approving a roster card that holds an ineligible model by hand, auto-approve,
j5_request_crew_memberanddelegate_taskon a live server (unit tests cover them), and a project-scoped override. I didn't run repo-wide checks.Merge Danger
Door: two-way. It adds a setting that's null until someone saves it, and no migration, so a revert undoes it. A saved list would just sit unused.
Blast Radius: every path that gives a custom worker a model: Crew launch and additions,
j5_spawn_agent, anddelegate_task, but only in a project where someone has saved a list. With nothing saved, nothing changes.Things worth knowing:
delegate_taskwithout a target is refused, since the child would inherit that model. The refusal lists the eligible models so it can pass one intarget.settingsSearch.tsis upstream and I wanted exactly one upstream hook. It's a small follow-up if you want it.After merge: nothing.
UI changes
The Agent Setup row opens as one card per provider, and the roster card's model picker for a custom member is filtered. Both are new, so there's no before.
Live testing
Two live passes in isolated test homes from
j5-live-test, both before the stack was last rebased onto j5/main. Nothing touched my real install.The first ran on the whole stack at
1d4ff9bdf6, before I reworked the settings row. The second ran at73869cd83e, for the row.claude-opus-5-5.Not exercised live: the cases listed under Not verified, and Cursor and the other providers (not set up on the test host). The Claude native-subagent control is still "unverified", as written above.
Upstream impact
All recorded in
FORK.mdcase 107, plus register entry D42 indocs/j5/product/upstream.md:packages/contracts/src/settings.ts:crewMemberModelsadded in the same four places ascrewAutoApprove, plus the nullable-override list.apps/server/src/mcp/OrchestratorMcpService.ts: an optionalauthorizeTargethook indelegateTask, called right after the target resolves. About five lines. I approved this one in the issue discussion because J5's wrapper can't see the resolved model otherwise. With no hook, upstream behavior is unchanged.apps/server/src/mcp/toolkits/worktree/registration.test.ts(one stub line) andpackages/shared/src/projectSettings.test.ts(new cases).Checklist
FORK.md(case text and file-table row) in this PRdocs/j5/product/upstream.md— D42AGENTS.md) — the setting, picker and spawn refusal ran live on Claude; providers' native subagents are "not supported here"/unverified; the other paths are covered by testsdocs/j5/product/and user docs rewritten where this changes themClaude Sonnet 5.5 through the Claude Code harness in J5 Code.
🤖 Generated with Claude Code