Repository navigation
feat(j5): choose which reasoning levels custom Crew members can use - #770
Merged
bryantderosier merged 13 commits intoNov 3, 2026
Merged
bryantderosier merged 13 commits into
bryantderosier merged 13 commits into
Conversation
bryantderosier
requested review from
BastiHu,
Jacksondr5 and
tyler-barton-horizon
October 28, 2026 11:45
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
bryantderosier
added a commit
that referenced
this pull request
Oct 28, 2026
This was referenced Oct 28, 2026
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
bryantderosier
force-pushed
the
j5/crew-member-reasoning-levels
branch
from
October 28, 2026 12:06
39abaec to
e2715d4
Compare
bryantderosier
force-pushed
the
j5/crew-member-reasoning-levels
branch
from
October 28, 2026 15:33
e2715d4 to
8256c31
Compare
bryantderosier
force-pushed
the
j5/crew-member-reasoning-levels
branch
from
October 29, 2026 11:33
8256c31 to
b86e3af
Compare
…els (reasoning levels) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…oning levels) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…and the roster card (reasoning levels) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…K.md and the divergence register (reasoning levels) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ing levels) The persona seat comparison matches a route's model and level together, so a seat frozen on the fallback route at its level skips the lists, and the same model at another level is checked. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
bryantderosier
force-pushed
the
j5/crew-member-reasoning-levels
branch
from
October 29, 2026 12:26
b86e3af to
7774ddd
Compare
7 of 8 tasks
This was referenced Oct 31, 2026
…g-levels layer Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…g-levels layer Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ing exported Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…o fix/770 # Conflicts: # apps/server/src/j5/a2a/CrewLaunchService.ts
6 of 8 tasks
This was referenced Nov 3, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#757 lets me choose which models custom Crew members may run on, but a Captain or an agent can still pick any reasoning level on an allowed model, and once additions and auto-approved launches skip the roster card I won't get a chance to correct it. This adds a second list, the reasoning levels custom workers may use, and the platform enforces it at the same points as the model list. It's the part of #757 the review panel suggested splitting out, since #744 asked for models only. There's no tracking issue for it yet.
This is stacked on #757, so the base is
j5/744-custom-member-models, and #758 now sits on top of this branch.crewMemberReasoning, holding checked(providerInstanceId, level)pairs, shown in the same Agent Setup row as the models ("Models for custom members"). It works like the models list: nothing saved means every level is eligible, a saved list holds only checked levels, a level that shows up in the catalog later starts unchecked, and a saved empty list means no level is eligible. A provider's levels are the choices of its models' reasoning options, in the order they first appear.CrewMemberModels.assertEligiblenow checks the model, then the level, at every call site feat(j5): choose which models custom Crew members can use #757 already covers:CrewLaunchService.resolveSelection,j5_spawn_agentanddelegate_taskwithout a persona. The level checked is the seat's explicit reasoning value, or the model's default when none is set; a model with no reasoning option has nothing to check.Docs: crews.md acceptance criteria on levels, the four tool sections in agent-tools.md (one sentence each), and the persona docs' note on allowlists.
Evidence
At
7774ddda16, on top of #757.vp run -r typecheck(the CI command) exits 0 here:b8a42e0bc0) server 1300, web 835, contracts 736 and shared 1680 tests pass:cd apps/server && vp test run src/j5/a2a src/j5/agents src/mcpdelegate_task, and an accepted retry. The card test checks that a custom member's level picker is filtered and a persona's isn't.projectSettings.test.tschecks the second key overrides like the first.Not verified: approving a roster card that holds an ineligible level by hand, auto-approve,
j5_request_crew_memberanddelegate_taskon a live server (tests cover them), and a project-scoped override. I didn't run repo-wide checks.Merge Danger
Door: two-way. A setting that's null until someone saves it, no migration, so a revert undoes it. A saved list would just sit unused.
Blast Radius: every path that gives a custom worker a reasoning level: Crew launch and additions,
j5_spawn_agentanddelegate_task, but only in a project where someone has saved a list.Things worth knowing:
t3_thread_configureisn't limited.After merge: nothing.
UI changes
The Reasoning group on each card and the filtered reasoning picker are new, so there's no before.
Live testing
Ran on a stack tip from before the last restack, at
4fa701e9ee, in an isolated test home fromj5-live-test. Nothing touched my real install.Not exercised live: the cases listed under Not verified, and Cursor and the other providers (not set up on the test host). The commits have been rebased since this run; the rebase only moved them onto a newer
j5/main.Upstream impact
packages/contracts/src/settings.tsgets the second key in the same places ascrewMemberModels, five lines and an import, with no new hook, recorded inFORK.mdcase 107 and register entry D42, which now covers both settings. TheprojectSettings.test.tscase is listed there too.Checklist
FORK.md(case text and file-table row) in this PRdocs/j5/product/upstream.md— D42AGENTS.md) — the setting, picker and spawn refusal ran live on Claude and Codex; the other paths are covered by testsdocs/j5/product/and user docs rewritten where this changes themClaude Sonnet 5.5 through the Claude Code harness in J5 Code.
🤖 Generated with Claude Code