Repository navigation
fix(mobile): Create and Edit persona render on Android - #854
Conversation
On Android, Settings › Personas › Create persona opened a blank modal: a `flex-1` class on the KeyboardAvoidingView (and its SafeAreaView) inside an RN Modal left the content zero-height. Inline `flex: 1` styles fix it, as in the device-claim modal. Edit persona and the folder picker use the same wrapper and get the same fix. Closes #853 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
This review includes 3 billable files and costs up to $0.75.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 4 minutes for your next included review. View limit details
|
Jacksondr5
left a comment
There was a problem hiding this comment.
Combined panel review (reviewer-opus + reviewer-sol) at af7f19d
Verdict: no findings, and the panel approves the source. Still pending: Android and iOS before/after captures and the tester's verdict. Per Jackson's evidence rule, iOS needs a before/after pair, not only an after shot, or the PR should say why a before isn't available.
- This covers exactly the three J5 modals that wrap a
KeyboardAvoidingView:AgentCreateModal(Create and Duplicate),AgentEditorModalandAgentFolderPickerModal. In each, the outerSafeAreaViewand theKeyboardAvoidingViewswapflex-1for inlineflex: 1.bg-sheetand iOSpaddingbehaviour are kept. It's the same fix as #844's claim modal. - It's a pure layout change in J5-owned files, so no test is asked for.
One device check, not a finding. The PR changes both the SafeAreaView and the KeyboardAvoidingView, so it doesn't pin which one collapses on Android. Four other J5 modals put className="flex-1" on a react-native-safe-area-context SafeAreaView without a KeyboardAvoidingView:
AgentImportConflictModal.tsx:23PlaybookConversationModal.tsx:149PlaybookLibrarySettingsScreen.tsx:399and:420
If the SafeAreaView class is the cause, these are blank on Android too. Please open at least one of them on Android during the device pass. If it's blank, the same one-line fix belongs here or in a follow-up.
Reviewed by Claude Opus 5.5 (reviewer-opus) and Sol 6.1 (reviewer-sol) in J5 Code.
Problem
On Android, Settings › Personas › Create persona opens a blank white modal, so a persona can't be created there. The tester confirmed it on trunk. Closes #853.
What changed
The modal's
SafeAreaViewandKeyboardAvoidingViewtakeflex: 1as an inline style, not aflex-1class. Inside an RNModalon Android, the class left the content zero-height; builder-identity found and fixed the same thing in the device-claim modal (#844). Three J5 modals use that wrapper, and all three get the fix: Create (and Duplicate), Edit, and the folder picker. The other J5 modals don't wrap aKeyboardAvoidingView.UI changes
Android, captured by the crew's tester on the same test home and emulator: before on
j5/main, after on this branch (af7f19d).Live testing
Android: PASS at af7f19d (crew tester, report
test-reports/j5code-mobile-wave1b-tester/af7f19df45.md).j5/main, so it needs no fix. The persona import-conflict modal, which has no keyboard wrapper either, couldn't be reached at first, because Mobile: importing a persona file on Android fails with "not connected" after the file picker #855 blocks imports on Android. A later capture on fix(mobile): importing a persona file on Android works after the file picker #856's import-fix head shows it renders fully (title, explanation, replace switch, Import selected), and Cancel works:iOS: not verified. iOS checks, including the regression check, are deferred to Checkpoint 1 on Jackson's iPhone (see below).
Checklist
apps/mobile/src/j5/agents/)Built by Claude Opus 5.5 in Claude Code (J5 Code crew seat builder-composer).
🤖 Generated with Claude Code
iOS verification
iOS before/after captures and native verification are deferred to Checkpoint 1 (Jackson's iPhone). A single Simulator boot raised the MacBook's one-minute load from 4 to 118; no iOS UI was verified. The Captain paused Simulator testing for the rest of wave 1.