Skip to content

fix(mobile): Create and Edit persona render on Android - #854

Merged
Jacksondr5 merged 1 commit into
j5/mainfrom
j5code/mobile-persona-modal-height
Nov 1, 2026
Merged

Jacksondr5 merged 1 commit into
j5/mainfrom
j5code/mobile-persona-modal-height

Conversation

@Jacksondr5

@Jacksondr5 Jacksondr5 commented Nov 1, 2026 •

Copy link
Copy Markdown
Owner

Problem

On Android, Settings › Personas › Create persona opens a blank white modal, so a persona can't be created there. The tester confirmed it on trunk. Closes #853.

What changed

The modal's SafeAreaView and KeyboardAvoidingView take flex: 1 as an inline style, not a flex-1 class. Inside an RN Modal on Android, the class left the content zero-height; builder-identity found and fixed the same thing in the device-claim modal (#844). Three J5 modals use that wrapper, and all three get the fix: Create (and Duplicate), Edit, and the folder picker. The other J5 modals don't wrap a KeyboardAvoidingView.

UI changes

Android, captured by the crew's tester on the same test home and emulator: before on j5/main, after on this branch (af7f19d).

Before After
Create persona, Android Create persona modal blank, Android, before Create persona modal showing its form, Android, after
Edit persona, Android Edit persona modal blank, Android, before Edit persona modal showing its form, Android, after
Add folder (folder picker), Android Folder picker collapsed at the top of the screen, Android, before Folder picker listing directories with Choose folder, Android, after

Edited persona description saved and shown on reopening, Android, after

Live testing

Android: PASS at af7f19d (crew tester, report test-reports/j5code-mobile-wave1b-tester/af7f19df45.md).

Replace existing personas modal rendered in full, captured on #856's import fix, Android

iOS: not verified. iOS checks, including the regression check, are deferred to Checkpoint 1 on Jackson's iPhone (see below).

Checklist

  • One concern: the description has no "also"
  • Tests cover the changed behavior: visual only, so captures instead of tests (AGENTS.md)
  • UI changes: Android before/after are above. iOS is deferred to Checkpoint 1.
  • Live testing: the section above says what ran live and what did not
  • Upstream-owned files: none; all three are J5's (apps/mobile/src/j5/agents/)
  • Upstream product: no change
  • Surfaces: mobile only. iOS is checked for regression.
  • Docs: no doc describes this

Built by Claude Opus 5.5 in Claude Code (J5 Code crew seat builder-composer).

🤖 Generated with Claude Code

iOS verification

iOS before/after captures and native verification are deferred to Checkpoint 1 (Jackson's iPhone). A single Simulator boot raised the MacBook's one-minute load from 4 to 118; no iOS UI was verified. The Captain paused Simulator testing for the rest of wave 1.

On Android, Settings › Personas › Create persona opened a blank modal: a
`flex-1` class on the KeyboardAvoidingView (and its SafeAreaView) inside an
RN Modal left the content zero-height. Inline `flex: 1` styles fix it, as
in the device-claim modal. Edit persona and the folder picker use the same
wrapper and get the same fix.

Closes #853

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
j5-code Ready Ready Preview Nov 1, 2026 12:49am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Nov 1, 2026

Copy link
Copy Markdown

Warning

Review limit reached

  • Run on-demand review

This review includes 3 billable files and costs up to $0.75.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 4 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available. Your 51 included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between 31447c9 and af7f19d.

Files selected for processing: 3
  • apps/mobile/src/j5/agents/AgentCreateModal.tsx
  • apps/mobile/src/j5/agents/AgentEditorModal.tsx
  • apps/mobile/src/j5/agents/AgentFolderPickerModal.tsx
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@Jacksondr5 Jacksondr5 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Combined panel review (reviewer-opus + reviewer-sol) at af7f19d

Verdict: no findings, and the panel approves the source. Still pending: Android and iOS before/after captures and the tester's verdict. Per Jackson's evidence rule, iOS needs a before/after pair, not only an after shot, or the PR should say why a before isn't available.

  • This covers exactly the three J5 modals that wrap a KeyboardAvoidingView: AgentCreateModal (Create and Duplicate), AgentEditorModal and AgentFolderPickerModal. In each, the outer SafeAreaView and the KeyboardAvoidingView swap flex-1 for inline flex: 1. bg-sheet and iOS padding behaviour are kept. It's the same fix as #844's claim modal.
  • It's a pure layout change in J5-owned files, so no test is asked for.

One device check, not a finding. The PR changes both the SafeAreaView and the KeyboardAvoidingView, so it doesn't pin which one collapses on Android. Four other J5 modals put className="flex-1" on a react-native-safe-area-context SafeAreaView without a KeyboardAvoidingView:

  • AgentImportConflictModal.tsx:23
  • PlaybookConversationModal.tsx:149
  • PlaybookLibrarySettingsScreen.tsx:399 and :420

If the SafeAreaView class is the cause, these are blank on Android too. Please open at least one of them on Android during the device pass. If it's blank, the same one-line fix belongs here or in a follow-up.

Reviewed by Claude Opus 5.5 (reviewer-opus) and Sol 6.1 (reviewer-sol) in J5 Code.

@github-actions github-actions Bot added size:S 10-29 effective changed lines (test files excluded in mixed PRs). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Nov 1, 2026
@Jacksondr5
Jacksondr5 merged commit d30e293 into j5/main Nov 1, 2026
33 checks passed
@Jacksondr5
Jacksondr5 deleted the j5code/mobile-persona-modal-height branch November 1, 2026 01:41

This branch was successfully deployed

1 active deployment
Preview — af7f19df Deployed Nov 1, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 effective changed lines (test files excluded in mixed PRs). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mobile (Android): Create persona opens a blank modal

1 participant