Repository navigation
fix(mobile): J5's sheets follow the app theme in dark mode - #876
Conversation
The archive warning opened as a light sheet in dark mode, with its title and summary nearly invisible. Its surface was a className on react-native-safe-area-context's SafeAreaView, which uniwind doesn't theme, so the class was dropped and the Modal stayed white. Seven more J5 sheets had the same pattern, and some lost their flex-1 the same way. Every J5 sheet now puts its surface and flex on a View around the SafeAreaView, as upstream's sheets do, and the playbook sheets use mobile's colour names instead of web's. Closes #868 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Move sheet surfaces outside safe areas apps/mobile/src/j5/agents/AgentCreateModal.tsx, apps/mobile/src/j5/agents/AgentEditorModal.tsx, apps/mobile/src/j5/agents/AgentFolderPickerModal.tsx, apps/mobile/src/j5/agents/AgentImportConflictModal.tsx, apps/mobile/src/j5/archive/ArchiveWarningSheet.tsx, apps/mobile/src/j5/playbooks/PlaybookConversationModal.tsx, apps/mobile/src/j5/playbooks/PlaybookLibrarySettingsScreen.tsx, apps/mobile/src/j5/sharing/NameQuestion.tsx |
These sheets move their background and flex layout to a wrapping View outside SafeAreaView. Playbook explanatory, description, and error text color classes also changed. Existing sheet content and actions remain unchanged. |
Estimated code review effort: 2 (Simple) | ~12 minutes
Suggested reviewers: bryantderosier
Merge Risk: 
Minimal · up to 5e002
-
The sheet backgrounds now follow the app theme, with no identified issue requiring a merge delay.
Pre-merge checks: 
4
-
Check name Status Explanation Title check The title names the main change: J5 sheets in the mobile app now follow the app theme in dark mode, which matches the raw summary (sheet surfaces moved from SafeAreaView to a themed View across J5 she… Description check The description follows the template. Problem, What changed, UI changes, Live testing, Upstream impact, and Checklist are all present. The Problem section names the cause, links #868, and explains the…Linked Issues check [ #868] Requirement: the J5 archive warning sheet must follow the app theme in dark mode. Evidence: the whole-PR diff of apps/mobile/src/j5/archive/ArchiveWarningSheet.tsx at head 5e002b8 moves the …Out of Scope Changes check The PR changes eight files: ArchiveWarningSheet.tsx, AgentCreateModal.tsx, AgentEditorModal.tsx, AgentFolderPickerModal.tsx, AgentImportConflictModal.tsx, PlaybookConversationModal.tsx, PlaybookLibrar… Full details: Title check
-
Explanation
The title names the main change: J5 sheets in the mobile app now follow the app theme in dark mode, which matches the raw summary (sheet surfaces moved from SafeAreaView to a themed View across J5 sheets) and the linked issue
#868. It is a conventional-commit title and is specific enough for a teammate scanning history.
Full details: Description check
-
Explanation
The description follows the template. Problem, What changed, UI changes, Live testing, Upstream impact, and Checklist are all present. The Problem section names the cause, links
#868, and explains the affected users. What changed explains the className root cause and the fix across the listed sheets. UI changes has before/after captures for iOS and Android in light and dark modes. Live testing reports iOS and Android results and lists what was not exercised. Upstream impact is omitted, which the template allows when the PR only touches J5-owned paths, and the PR states upstream files were not edited. The checklist is filled in. The description ends with the model and harness, as the template asks. Minor gaps: the one-concern checklist item and the claim that the head update was not re-tested are noted but not resolved in the description itself.
Full details: Linked Issues check
-
Explanation
[
#868] Requirement: the J5 archive warning sheet must follow the app theme in dark mode. Evidence: the whole-PR diff of apps/mobile/src/j5/archive/ArchiveWarningSheet.tsx at head 5e002b8 moves the sheet surface from className="bg-sheet" on SafeAreaView (dropped, because react-native-safe-area-context is not themed by Uniwind) to a View with className="flex-1 bg-sheet" that wraps SafeAreaView. Title and body text keep text-foreground, which follows the theme. The title, scrollable facts, and Cancel/confirm controls are unchanged. The PR reports iOS and Android light/dark captures and live tests, which were not re-run here. The coding requirement is met by the code change. Light/dark visual verification and before/after captures are non-coding and are not assessed. No automated test is added; the issue does not request one.
Full details: Out of Scope Changes check
-
Explanation
The PR changes eight files: ArchiveWarningSheet.tsx, AgentCreateModal.tsx, AgentEditorModal.tsx, AgentFolderPickerModal.tsx, AgentImportConflictModal.tsx, PlaybookConversationModal.tsx, PlaybookLibrarySettingsScreen.tsx, and NameQuestion.tsx. All apply the same fix as the linked issue
#868: move the theme surface from className on SafeAreaView to a wrapping View. The other seven files are J5 sheets with the same dropped-className defect. Fixing them extends the#868fix to the same root cause in the same theme area, so they are connected to the objective. The playbook sheets also replace web color names (bg-background, text-destructive, text-muted-foreground) with mobile theme names inside those sheets. This is a dark-mode text and surface fix within the same sheets. The PR description states that the Personas page itself is left for#867, so that page is not changed here. The large line counts in several files are mostly reindentation from wrapping the content in a new View, as the description states; the wrapping is needed for the surface change. No unrelated change was found in the reviewed diff. Limit: the diffs for the seven non-archive files were not inspected line by line. This assessment relies on the file summaries and the PR description for those files.
-
Finishing Touches
-
Generate docstrings
-
- Commit to this branch
- Create a new PR
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Jacksondr5
left a comment
There was a problem hiding this comment.
Combined panel review (reviewer-opus + reviewer-sol) at 53522ec
Verdict: no findings, and the panel approves the source. Still pending: Android light and dark before/after captures of the sheets. iOS is deferred to Checkpoint 2.
- Cause and fix.
classNameonreact-native-safe-area-context'sSafeAreaViewis dropped, so the sheet surface never applied. All eight J5 sheets now put the surface andflex-1on aViewaroundSafeAreaView style={{ flex: 1 }}, as upstream'sThreadArrangementSheet.tsx:410–411does. This also explains #854: theflex-1class onSafeAreaViewnever applied there either. - Behaviour kept. The inline
flex: 1onKeyboardAvoidingView(#854's sizing fix) stays. The archive sheet keeps its ownSafeAreaProvider. NameQuestion stays full screen, can't be dismissed, and keepsbg-screen. - Playbook sheet tokens.
bg-background,text-muted-foregroundandtext-destructivemap to mobile'sbg-sheet,text-foreground-mutedandtext-danger-foreground. The same web names on the Playbooks page body (PlaybookLibrarySettingsScreen.tsx:42,:155,:191,:197, …) are left for #867, as the PR says. - No J5
<SafeAreaView … className>remains insrc/j5. - Reviewer-run: mobile
vp run typecheckexit 0, and lint clean onsrc/j5. It's visual only, so no tests are asked for.
When #873 rebases onto this, keep both the outer themed View and #873's identity behaviour in NameQuestion.tsx.
Reviewed by Claude Opus 5.5 (reviewer-opus) and Sol 6.1 (reviewer-sol) in J5 Code.
…ive-sheet-dark # Conflicts: # apps/mobile/src/j5/sharing/NameQuestion.tsx
Problem
At Checkpoint 1, with the phone in dark mode, the archive warning (#845) opened as a light sheet. Its title and summary were light grey on near-white and nearly invisible, while the ask cards inside were dark.
Closes #868
What changed
Cause. The sheet set its surface with
className="bg-sheet"onreact-native-safe-area-context'sSafeAreaView. Uniwind themes only React Native's own components (its Metro resolver rewritesreact-native), so thatclassNamewas silently dropped. TheModalstayed white, and the theme-coloured text sat on it. The same cause is behind the "Inline flex: on Android aflex-1class left this Modal's content zero-height" comments in several J5 sheets.Fix. Upstream's sheets (
ThreadArrangementSheet) put the surface on aViewwithSafeAreaViewinside it. Every J5 sheet with the pattern now does the same, as the Captain asked (same concern: J5's sheets follow the theme):ArchiveWarningSheet)AgentCreateModal)AgentEditorModal)AgentFolderPickerModal)AgentImportConflictModal)NameQuestion)PlaybookConversationModal)PlaybookLibrarySettingsScreen)The playbook sheets also used three web colour names that mobile's theme doesn't define. Inside those sheets they now use mobile's names:
bg-backgroundbecomesbg-sheet,text-destructivebecomestext-danger-foreground, andtext-muted-foregroundbecomestext-foreground-muted. Without a surface,bg-backgroundleft those sheets white too. The text classes only lost their tint, becauseAppTextdefaults totext-foreground. The same web names on the Personas page itself (outside any sheet) are left for #867, which owns that page's dark-mode text.The diff is mostly reindentation;
git diff -wshows the real change.UI changes
iOS (iOS 26.5 Simulator, same data on both sides; base
c2b7939de8, head53522ecc5b). In dark mode the sheets were white, with near-white title and summary text. After the fix they follow the app theme. Light mode shows no change.Android (Android 16 emulator, 1080×2400, same data on both sides; base
c2b7939de8, head53522ecc5b). All nine sheet surfaces in the eight files. In dark mode, every sheet was white or unthemed before; after, each has a dark surface with readable text, at full height. Light mode shows no change.Known limit: the status bar after a theme switch. These pairs switch the system to dark mode while the sheet is open, the same way on both sides. Android keeps the status-bar icon colour a
Modalhad when it opened (React Native copies the app's status-bar style into the sheet's window only at open). So a sheet left open across a light-to-dark switch shows dark icons on a dark sheet until it's reopened. A sheet opened in dark mode shows white icons, as here. This applies to every React Native sheet, upstream's included, and is not something this PR changes.Live testing
iOS: pass at
53522ecc5b, run by the crew's tester (GPT-6 Astra through Codex). The archive warning used a real open ask from a Claude Haiku agent. The archive warning, Create persona and Create playbook were captured in light and dark mode. Trunk reproduced the near-white text on a white sheet in dark mode; the head is readable and themed throughout. Cancel kept the agent. Report: project artifacttest-reports/j5code-mobile-wave1b-tester/53522ecc5b-ios.md.Not exercised on iOS: the other five sheets, and error or loading states. The Android pass covers all eight sheets.
Android: pass at
53522ecc5b, run by the wave-2 tester (GPT-6 Astra through Codex) against trunkc2b7939de8. Two real Claude Haiku turns supplied the artifact and open-ask data. All nine sheet surfaces opened on both sides, in light and dark, with matching data and viewport. Cancel and Back were exercised: archive Cancel kept the ask, and import-conflict Cancel left the existing persona intact. Report: project artifacttest-reports/mobile-wave2-android/53522ecc5b.md.The head was later updated from trunk (the Captain's merge commit). The eight changed files are identical to the tested commit, so that update wasn't re-tested.
Not exercised: the playbook import/copy/rename sheet in its Copy and Rename forms (only Import was captured; all three share one sheet); loading and server-error states; the "Who are you?" question for a brand-new owner (the unknown-device path was covered); tablet width; native video.
Checklist
WorkspaceFileWebPreview.tsxhas the same dropped-className pattern; it's on the give-back list.Built by Claude Opus 5.5 in J5 Code (Claude Code harness).
🤖 Generated with Claude Code