Repository navigation
feat(mobile): another person's name in a shared thread carries their avatar - #879
Conversation
…avatar Web draws a person's initials on their colour beside their name in a shared conversation; mobile drew the name alone. Mobile now draws the same avatar beside another person's name, and beside another person's Inbox reply. The initials and the colour (picked from the name, the same on every client) move into client-runtime, shared with web. Refs #869 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
This review includes 7 billable files and costs up to $1.75.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 10 minutes for your next included review. View limit details
|
Jacksondr5
left a comment
There was a problem hiding this comment.
Combined review: reviewer-opus and reviewer-sol (Claude Opus 5.5 and GPT Sol 6.1), head f9ae257
Both of us reviewed the PR independently. Neither found anything that blocks merge.
- Colours.
presentPersonAvatarkeeps web's hash unchanged. Its palette isProjectIconColor.literalsminus gray, in the same order as web'sPROJECT_ICON_COLORS, so every name keeps the colour web has always drawn for it. The test pins two of them. - Initials.
initialsOfis byte-identical to web's, and it leavesshareLink.logic.ts. - Web.
PersonAvatarmaps colour to swatch by value, so it looks the same. - Mobile.
PersonAvatarcovers every colour but gray with a literalbg-*-500class, the same swatches as web; mobile'sprojectIcon.tsalready uses that pattern. A null name gets an emptybg-subtle-strongcircle, and the avatar is hidden from accessibility.PersonLinewraps only the two other-person author lines (a shared author, and another person's Inbox reply) without changing their text. The reader's own rows and agents' rows are unchanged. - Tests. 4 helper and 12 mobile timeline and feed tests pass.
For the captures (not blocking): mobile's initials are text-3xs in a size-5 circle, while web's xs avatar uses text-4xs. The tester can judge the fit on both platforms.
The panel has no open code findings. Before merge it still needs the captures, the tester's run and green J5 CI.
Problem
In a shared conversation, mobile drew another person's name with no avatar, where web draws their initials on their colour (Checkpoint 1). Refs #869. The other half of that issue, "answered by" not showing on iOS, is under Answered-by on iOS below and isn't changed here.
What changed
j5/person-avatar). The same name therefore gets the same colour on both clients; a test pins web's existing colours. Web's avatar now reads the shared helper, so nothing it draws changes. Mobile's initials use its smallest text step,text-3xs(11px), in the same 20px circle. Web uses its own 8pxtext-4xs, which mobile's type scale doesn't have.Answered-by on iOS: not reproduced on Android or iOS
Jackson saw no "· answered by Priya" on the "Which checkpoint theme?" question at Checkpoint 1 on his iPhone. Neither platform reproduces it with the same data:
c2b7939de8: the same thread. "· answered by Priya" is fully visible, collapsed and expanded, at the default text size and at a large accessibility size. At the large size only the question summary truncates.Still unexplained: what Jackson saw on his physical iPhone. A Simulator isn't his device, and VoiceOver wasn't tested. This PR doesn't touch "answered by".
UI changes
Android 16 emulator, 1080×2400, the same shared thread and data on both sides. Before is base
c2b7939de8, after isf9ae25795b.Priya's messages in a shared conversation, light theme: a blue "P" beside her name.
The same thread in the dark theme (after only), and web's avatar for the same name: the colour matches.
Not captured: another person's Inbox reply with its avatar, the empty grey circle for someone without a name, and iOS.
Live testing
The crew's tester ran Android 16 on an isolated test server with a real, completed Claude Haiku conversation with another person, Priya: pass at
f9ae25795b. In light and dark, Priya's two messages carry a blue "P" beside her name, matching web. Report: project artifacttest-reports/j5code-mobile-wave1a-tester/f9ae25795b.md.Not exercised:
Rig note: the first head capture showed no circle, because a long-running Metro hadn't picked up the new file's styles. A fresh Metro fixed it, and the final captures use that. This isn't a product issue.
Checklist
personAvatar.test.ts, which pins web's coloursClaude Opus 5.5 in J5 Code (Claude Code harness).
🤖 Generated with Claude Code