Skip to content

feat(mobile): another person's name in a shared thread carries their avatar - #879

Merged
Jacksondr5 merged 2 commits into
j5/mainfrom
j5code/mobile-person-avatars
Nov 1, 2026
Merged

Jacksondr5 merged 2 commits into
j5/mainfrom
j5code/mobile-person-avatars

Conversation

@Jacksondr5

@Jacksondr5 Jacksondr5 commented Nov 1, 2026 •

Copy link
Copy Markdown
Owner

Problem

In a shared conversation, mobile drew another person's name with no avatar, where web draws their initials on their colour (Checkpoint 1). Refs #869. The other half of that issue, "answered by" not showing on iOS, is under Answered-by on iOS below and isn't changed here.

What changed

  • Mobile draws web's avatar beside another person's name: above their messages in a shared conversation, and beside another person's Inbox reply. It's the person's initials on a colour picked from their name; someone without a name gets an empty grey circle.
  • The initials and the colour choice move from web into client-runtime (j5/person-avatar). The same name therefore gets the same colour on both clients; a test pins web's existing colours. Web's avatar now reads the shared helper, so nothing it draws changes. Mobile's initials use its smallest text step, text-3xs (11px), in the same 20px circle. Web uses its own 8px text-4xs, which mobile's type scale doesn't have.

Answered-by on iOS: not reproduced on Android or iOS

Jackson saw no "· answered by Priya" on the "Which checkpoint theme?" question at Checkpoint 1 on his iPhone. Neither platform reproduces it with the same data:

  • The data is right. Read-only, on the preserved Checkpoint 1 home: the answer has its author record, the question is settled, and the request ids match.
  • Mobile draws that question as an ordinary work row outside the folded turn, the same path as feat(mobile): shared conversations name who wrote and who answered #859's tested rows, with no platform-specific branch.
  • Android: the tester opened that exact thread, on that home, with the Checkpoint 1 build. "· answered by Priya" is visible, collapsed and expanded.
  • iOS 26.5 Simulator, trunk c2b7939de8: the same thread. "· answered by Priya" is fully visible, collapsed and expanded, at the default text size and at a large accessibility size. At the large size only the question summary truncates.
Default text size Large accessibility text size
The answered question on iOS at the default text size, collapsed The answered question on iOS at a large accessibility text size, collapsed

Still unexplained: what Jackson saw on his physical iPhone. A Simulator isn't his device, and VoiceOver wasn't tested. This PR doesn't touch "answered by".

UI changes

Android 16 emulator, 1080×2400, the same shared thread and data on both sides. Before is base c2b7939de8, after is f9ae25795b.

Priya's messages in a shared conversation, light theme: a blue "P" beside her name.

Before After
Priya's messages in a shared conversation, before Priya's messages in a shared conversation, after

The same thread in the dark theme (after only), and web's avatar for the same name: the colour matches.

Android, dark theme, after Web, after
Priya's messages in the dark theme on Android, after Priya's message with her avatar on web, after

Not captured: another person's Inbox reply with its avatar, the empty grey circle for someone without a name, and iOS.

Live testing

The crew's tester ran Android 16 on an isolated test server with a real, completed Claude Haiku conversation with another person, Priya: pass at f9ae25795b. In light and dark, Priya's two messages carry a blue "P" beside her name, matching web. Report: project artifact test-reports/j5code-mobile-wave1a-tester/f9ae25795b.md.

Not exercised:

  • another person's Inbox reply;
  • someone without a name;
  • other names' colours (a test pins web's colours);
  • large accessibility text;
  • iOS.

Rig note: the first head capture showed no circle, because a long-running Metro hadn't picked up the new file's styles. A fresh Metro fixed it, and the final captures use that. This isn't a product issue.

Checklist

  • One concern: the description has no "also". The answered-by finding is a report only, with no code.
  • Tests cover the changed behavior: client-runtime personAvatar.test.ts, which pins web's colours
  • UI changes: before/after above (Android; iOS at the checkpoint)
  • Live testing: the section above says what ran live and what did not
  • Upstream-owned files: none touched
  • Upstream product: unchanged
  • Surfaces: mobile is the client, and web reads the same helper. No contract changes.
  • Docs: nothing to rewrite

Claude Opus 5.5 in J5 Code (Claude Code harness).

🤖 Generated with Claude Code

…avatar

Web draws a person's initials on their colour beside their name in a
shared conversation; mobile drew the name alone. Mobile now draws the
same avatar beside another person's name, and beside another person's
Inbox reply. The initials and the colour (picked from the name, the same
on every client) move into client-runtime, shared with web.

Refs #869

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
j5-code Ready Ready Preview Nov 1, 2026 8:15pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

  • Run on-demand review

This review includes 7 billable files and costs up to $1.75.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 10 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used all 3 included reviews currently available. Your 43 included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between edc4350 and a891267.

Files selected for processing: 7
  • apps/mobile/src/j5/a2a/timeline.tsx
  • apps/mobile/src/j5/sharing/PersonAvatar.tsx
  • apps/web/src/j5/sharing/PersonAvatar.tsx
  • apps/web/src/j5/sharing/shareLink.logic.ts
  • packages/client-runtime/package.json
  • packages/client-runtime/src/j5/personAvatar.test.ts
  • packages/client-runtime/src/j5/personAvatar.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@Jacksondr5 Jacksondr5 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Combined review: reviewer-opus and reviewer-sol (Claude Opus 5.5 and GPT Sol 6.1), head f9ae257

Both of us reviewed the PR independently. Neither found anything that blocks merge.

  • Colours. presentPersonAvatar keeps web's hash unchanged. Its palette is ProjectIconColor.literals minus gray, in the same order as web's PROJECT_ICON_COLORS, so every name keeps the colour web has always drawn for it. The test pins two of them.
  • Initials. initialsOf is byte-identical to web's, and it leaves shareLink.logic.ts.
  • Web. PersonAvatar maps colour to swatch by value, so it looks the same.
  • Mobile. PersonAvatar covers every colour but gray with a literal bg-*-500 class, the same swatches as web; mobile's projectIcon.ts already uses that pattern. A null name gets an empty bg-subtle-strong circle, and the avatar is hidden from accessibility. PersonLine wraps only the two other-person author lines (a shared author, and another person's Inbox reply) without changing their text. The reader's own rows and agents' rows are unchanged.
  • Tests. 4 helper and 12 mobile timeline and feed tests pass.

For the captures (not blocking): mobile's initials are text-3xs in a size-5 circle, while web's xs avatar uses text-4xs. The tester can judge the fit on both platforms.

The panel has no open code findings. Before merge it still needs the captures, the tester's run and green J5 CI.

@github-actions github-actions Bot added size:L 100-499 effective changed lines (test files excluded in mixed PRs). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Nov 1, 2026
@Jacksondr5
Jacksondr5 merged commit cbda841 into j5/main Nov 1, 2026
33 checks passed
@Jacksondr5
Jacksondr5 deleted the j5code/mobile-person-avatars branch November 1, 2026 20:45

This branch was successfully deployed

1 active deployment
Preview — a8912674 Deployed Nov 1, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 effective changed lines (test files excluded in mixed PRs). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant