Skip to content

fix(mobile): Agent Setup's persona section is titled Personas, and playbook details close like persona sheets - #989

Merged
Jacksondr5 merged 1 commit into
j5/mainfrom
j5code/mobile-agent-setup-labels
Nov 9, 2026
Merged

Jacksondr5 merged 1 commit into
j5/mainfrom
j5code/mobile-agent-setup-labels

Conversation

@Jacksondr5

@Jacksondr5 Jacksondr5 commented Nov 9, 2026 •

Copy link
Copy Markdown
Owner

Problem

At Checkpoint 3, Jackson found three things in mobile Settings, plus a question. Part of #963.

  1. The entry said "Personas", but the page holds Personas and Playbooks.
  2. "Library sources" didn't say whose library it was.
  3. The playbook details sheet closed differently from the persona sheets.
  4. Could a playbook start the way upstream's new chat does? That's a proposal only, and it's in the comment below rather than in this PR.

What changed

  1. Naming: the entry and page are now "Agent Setup", shared with web, where Bryant's feat(j5): add Agent Setup and configurable Crew approval #754 also put Crews settings. The persona list was titled "Agent Setup" too, and is now "Personas", so the page reads Agent Setup › Personas and Playbooks. The Captain chose this over renaming mobile alone, and Jackson can overrule it at Checkpoint 4.
  2. Library sources: the section is "Persona library sources". Playbook folders are separate, in playbooks.json.
  3. Close button: the playbook details sheet has the persona sheets' header, with the title and Done at the top, instead of Close at the bottom.

UI changes

iOS Simulator, iOS 26.5, same data: before on j5/main (3abc2ea8a7), after on f8ad6a54a7.

Before After
Agent Setup's section titles Agent Setup and Library sources section titles, iOS, before Personas and Persona library sources section titles, iOS, after
Playbook details sheet Playbook details closing with Close at the bottom, iOS, before Playbook details with Done at the top, iOS, after

Android 16, same data: before on 3abc2ea8a7, after on f8ad6a54a7.

Before After
Personas section title Personas section title, Android, before Personas section title, Android, after
Persona library sources title Persona library sources title, Android, before Persona library sources title, Android, after
Playbook details sheet Playbook details sheet, Android, before Playbook details sheet, Android, after

Live testing

iOS: PASS at f8ad6a54a7 (crew tester, report test-reports/pr-989/ios-f8ad6a54a7.md). Both section titles changed, and the playbook details sheet has Done at the top, which returns to the page.

Android: PASS at f8ad6a54a7 (crew tester, report test-reports/pr-989/f8ad6a54a7.md). Both section titles changed, and the playbook details sheet's Done at the top closes it, with no Close below the steps.

Not exercised: dark mode, tablets and a physical iPhone.

Checklist

  • One concern: the description has no "also". These are Mobile Settings: "Personas & Playbooks", playbook sheet close buttons, and starting a playbook like upstream's new chat #963's Settings labels and sheet.
  • Tests cover the changed behavior: no test. These are labels and a header, so captures are the proof.
  • UI changes: before/after above, on iOS and Android
  • Live testing: the section above says what ran live and what did not
  • Upstream-owned files: none
  • Upstream product: no change
  • Surfaces: mobile's Agent Setup page and its playbook details sheet
  • Docs: the guide's "Library sources" heading changes, which goes in the wave 4 docs PR

Built by Claude Opus 5.5 in Claude Code (J5 Code crew seat builder-composer).

🤖 Generated with Claude Code

…aybook details close like persona sheets

The page is Agent Setup, shared with web, and its persona list was also
titled Agent Setup; it's now Personas, beside Playbooks. Library sources are
labelled as the personas' own. The playbook details sheet puts Done at the
top, as the persona sheets do.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Nov 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
j5-code Ready Ready Preview Nov 9, 2026 4:46am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Nov 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

  • Run on-demand review

This review includes 2 billable files and costs up to $0.50.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 14 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available. Your 30 included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 3abc2ea and f8ad6a5.

Files selected for processing: 2

  • apps/mobile/src/j5/agents/AgentLibrarySettingsScreen.tsx
  • apps/mobile/src/j5/playbooks/PlaybookLibrarySettingsScreen.tsx
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@Jacksondr5 Jacksondr5 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Combined panel review (reviewer-opus + reviewer-sol) at f8ad6a5

Verdict: no findings, and the panel approves the source. Still pending: before/after captures and the tester's Done and back check.

  • Labels. The persona section on the Agent Setup page is now titled "Personas" (the Captain's choice over renaming the page). "Library sources" becomes "Persona library sources", since those folders hold personas only (agent-personas.json), as #963 item 2 notes. Playbooks stays its own section.
  • Playbook details sheet. It now has the persona sheets' header: the title, then Done at the top, outside the scroll view. Done calls the same setDetails(null) as the old bottom Close button. Android back (onRequestClose) is unchanged, and the themed View with an inline-flex SafeAreaView is kept.
  • #963 item 4 (starting a playbook like upstream's new chat) is investigate-first, and isn't in this PR. The guide's label update belongs to the wave-4 docs PR.

Reviewer-run: reactCompilerCoverage.test.ts passes (1081), mobile vp run typecheck exits 0, and lint and git diff --check are clean. It's labels and a header, so no UI test is asked for.

Reviewed by Claude Opus 5.5 (reviewer-opus) and Sol 6.1 (reviewer-sol) in J5 Code.

@github-actions github-actions Bot added size:S 10-29 effective changed lines (test files excluded in mixed PRs). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Nov 9, 2026
@Jacksondr5
Jacksondr5 merged commit 9659ae6 into j5/main Nov 9, 2026
33 checks passed
@Jacksondr5
Jacksondr5 deleted the j5code/mobile-agent-setup-labels branch November 9, 2026 06:43

This branch was successfully deployed

1 active deployment
Preview — f8ad6a54 Deployed Nov 9, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 effective changed lines (test files excluded in mixed PRs). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant