Repository navigation
fix(mobile): Agent Setup's persona section is titled Personas, and playbook details close like persona sheets - #989
Conversation
…aybook details close like persona sheets The page is Agent Setup, shared with web, and its persona list was also titled Agent Setup; it's now Personas, beside Playbooks. Library sources are labelled as the personas' own. The playbook details sheet puts Done at the top, as the persona sheets do. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
This review includes 2 billable files and costs up to $0.50.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 14 minutes for your next included review. View limit details
|
Jacksondr5
left a comment
There was a problem hiding this comment.
Combined panel review (reviewer-opus + reviewer-sol) at f8ad6a5
Verdict: no findings, and the panel approves the source. Still pending: before/after captures and the tester's Done and back check.
- Labels. The persona section on the Agent Setup page is now titled "Personas" (the Captain's choice over renaming the page). "Library sources" becomes "Persona library sources", since those folders hold personas only (
agent-personas.json), as #963 item 2 notes. Playbooks stays its own section. - Playbook details sheet. It now has the persona sheets' header: the title, then Done at the top, outside the scroll view. Done calls the same
setDetails(null)as the old bottom Close button. Android back (onRequestClose) is unchanged, and the themedViewwith an inline-flexSafeAreaViewis kept. - #963 item 4 (starting a playbook like upstream's new chat) is investigate-first, and isn't in this PR. The guide's label update belongs to the wave-4 docs PR.
Reviewer-run: reactCompilerCoverage.test.ts passes (1081), mobile vp run typecheck exits 0, and lint and git diff --check are clean. It's labels and a header, so no UI test is asked for.
Reviewed by Claude Opus 5.5 (reviewer-opus) and Sol 6.1 (reviewer-sol) in J5 Code.
Problem
At Checkpoint 3, Jackson found three things in mobile Settings, plus a question. Part of #963.
What changed
playbooks.json.UI changes
iOS Simulator, iOS 26.5, same data: before on
j5/main(3abc2ea8a7), after onf8ad6a54a7.Android 16, same data: before on
3abc2ea8a7, after onf8ad6a54a7.Live testing
iOS: PASS at
f8ad6a54a7(crew tester, reporttest-reports/pr-989/ios-f8ad6a54a7.md). Both section titles changed, and the playbook details sheet has Done at the top, which returns to the page.Android: PASS at
f8ad6a54a7(crew tester, reporttest-reports/pr-989/f8ad6a54a7.md). Both section titles changed, and the playbook details sheet's Done at the top closes it, with no Close below the steps.Not exercised: dark mode, tablets and a physical iPhone.
Checklist
Built by Claude Opus 5.5 in Claude Code (J5 Code crew seat builder-composer).
🤖 Generated with Claude Code