Repository navigation
feat(mobile): start a playbook from upstream's new chat, picking the project in its heading - #990
Conversation
…project in its heading Create playbook and Prepare chat opened a J5 page with its own project menu. Both now open upstream's new chat on a prepared draft, where the project is picked from the "What should we build in <project>?" heading: Prepare chat fills "Start playbook <name>", and Create picks Playbook Author with its opening prompt, so it now needs a Send. A playbook missing on the chosen project's server fails with a message that says so. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
This review includes 9 billable files and costs up to $2.25.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 6 minutes for your next included review. View limit details
|
Jacksondr5
left a comment
There was a problem hiding this comment.
Combined panel review (reviewer-opus + reviewer-sol) at de5a367
Verdict: no correctness findings, and the panel approves the source. Still pending: a live run with real agents (Create and Prepare chat, picking the project from the new-chat heading), the cross-server not-found case, captures, and J5 CI.
The builder's four points
- Create's model: same route. The old
playbookAuthorLaunchand the new draft both carryplaybook-authoras the persona in the thread's creation. The server resolves the route through the sameresolveAgentPersonaLaunch→prepareAgentPersonaLaunch, ignoring the client's model selection, so the model doesn't change.ensurePlaybookAuthorre-reads the catalog after creating the persona, which refreshes the shared catalog atom the draft's persona row reads, so a first-ever Create shows its agent row. A project change in the heading keeps the same draft key, so the prompt and the chosen persona carry over. - Runtime mode. The thread's stored mode now follows the composer, whose default is
full-access, where the old launch hard-codedauto-accept-edits. But a persona's effective policy comes from its access level:workspace-writetranslates toauto-accept-editsplus a workspace-write sandbox inagentPersonaRuntime.tsandproviderPolicy.ts. So Playbook Author doesn't get full access just because the composer says so. - The removed route has no consumers.
SettingsPlaybookConversationandPlaybookConversationScreenhave no remaining references, and FORK.md case 103 is updated. Web keepsplaybookAuthorLaunchin its own dialog.PLAYBOOK_AUTHOR_PROMPTis the old text, byte for byte. - Error text and evals. The two
not_foundmessages inPlaybookStore.tsandPlaybookLibrary.tsonly gain "on this server". That's J5's own tool text, not upstream's model-facing text, and not a model-behaviour fix, so the evals rule doesn't call for a run. A live wrong-server run is the useful proof. Optional: in the PR body, give that narrow reason instead of a blanket "J5 doesn't run paid evals".
Reviewer-run checks
- server
src/j5/playbooks: 93 passed in 7 files. MobilereactCompilerCoverage.test.tsandupstreamSeams.test.ts: 1131 (reviewer-opus). Reviewer-sol: 99 draft, shared-playbook and server-store tests plus 4 targeted mobile compiler checks. vp run typecheck: mobile and server exit 0- lint: clean on the changed files;
git diff --check: clean
The guide update belongs to the wave-4 docs PR.
Reviewed by Claude Opus 5.5 (reviewer-opus) and Sol 6.1 (reviewer-sol) in J5 Code.
Problem
At Checkpoint 3, Jackson asked whether starting a playbook could use upstream's new chat, which picks the project from its "What should we build in ?" heading, instead of J5's page with its own project menu. Closes #963, together with #989.
What changed
playbook-authorpersona in the thread's creation, and the server resolves the persona's route there.ensurePlaybookAuthorstill runs first, creating or updating the author as before.agentPersonaRuntime.ts,providerPolicy.ts), as the old launch did.PlaybookConversationScreenand itsSettingsPlaybookConversationroute, from fix(mobile): the Playbook conversation form is a pushed page, so Android's picker opens #906. FORK.md case 103 is updated, andStack.tsxis unchanged.UI changes
Android 16, two projects and a second server: before on
3abc2ea8a7, after onde5a367b65. Before, both actions open J5's page with a project menu. After, they open upstream's new chat, with the project in its heading.After only:
Prepare chat: the unsent draft kept, the project chosen from the heading, and the run completing (excerpts):
prepare-retention-project-de5a367-after.mp4
Create playbook: the project chosen from the heading, Send, and Playbook Author's reply (excerpts):
create-project-send-excerpts-de5a367-after.mp4
Prepare chat on another server's project: the prompt kept, and the missing-playbook result (excerpts):
wrong-server-excerpts-de5a367-after.mp4
Live testing
Android: PASS at
de5a367b65(crew tester, reporttest-reports/pr-990/de5a367b65.md), with real turns.ensurePlaybookAuthorset up, by asking what the playbook should accomplish.Not exercised: iOS, which waits for Checkpoint 4, and dark mode.
Checklist
Built by Claude Opus 5.5 in Claude Code (J5 Code crew seat builder-composer).
🤖 Generated with Claude Code