Skip to content

Make the Pickup settling wait configurable (default 30 minutes) - #576

Merged
JacobStephens2 merged 2 commits into
mainfrom
issue-573
Oct 8, 2026
Merged

JacobStephens2 merged 2 commits into
mainfrom
issue-573

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 8, 2026 •

Copy link
Copy Markdown
Owner

Summary

Give the Day shift thirty minutes to attach Tickets before a Pickup run takes an issue. pickup.wait_minutes controls the settling window used by the shared Ready issue search; 0 disables waiting.

 Ready issue search (Pickup and Architect runs)
-  require ten minutes since the latest label, sub-issue, or blocker change
+  require pickup.wait_minutes since the latest change (default 30)
+  at zero, bypass the settling comparison
 Setup
+  write wait_minutes = 30; preserve a configured value

Closes #573

Test seams

  • Command-line interface: Pickup dispatch or skip after shaping events and User config overrides, including zero; invalid config is rejected before work. Architect runs use the same Ready issue rule.
  • Setup's command-line interface: write the default and preserve a configured wait when completing an existing User config.

Evidence

  • Before: an_issue_labelled_ready_for_agent_less_than_thirty_minutes_ago_is_not_taken failed: the old code dispatched an issue labelled 29 minutes ago.
    After: passes; the issue is skipped until thirty minutes have passed.
  • Before: Spec P1's exact regression, cargo test --test pickup_run zero_pickup_wait_ignores_server_timestamps_ahead_of_local_clock -- --exact, failed with zero sessions and “less than 0 minutes ago”.
    After: passes with a dispatched Run and a ready-for-review PR; the regression is retained.
  • Override tests cover shorter, longer, and zero waits for labels, sub-issue additions/removals, and blocker additions/removals. Invalid values fail before work; Setup retains a custom 60-minute wait.
  • Validation: cargo check --all-targets, cargo fmt --check, and cargo clippy --all-targets -- -D warnings passed. Full cargo test passed.

Review

Reviewed against main with thirdshift-code-review. Standards: 0 findings. Spec: 1 behavioral finding, reproduced as written and fixed; the reviewer confirmed the fix. Both reviewers read all 11 changed files, including the final correction. No changed files were left unread by either axis.

Unaddressed findings

  • Standards: none.
  • Spec: none.

Merge Danger

Door: two-way

Blast Radius: passes

The default adds twenty minutes before an issue becomes a Ready issue, including the Architect gate. Set pickup.wait_minutes = 10 to retain the previous window.

Built with codex · gpt-6.1-sol · xhigh

@JacobStephens2
JacobStephens2 merged commit a4342b3 into main Oct 8, 2026
17 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-573 branch October 8, 2026 14:47
@JacobStephens2 JacobStephens2 mentioned this pull request Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant