Repository navigation
Make the Pickup settling wait configurable (default 30 minutes) - #576
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Give the Day shift thirty minutes to attach Tickets before a Pickup run takes an issue.
pickup.wait_minutescontrols the settling window used by the shared Ready issue search;0disables waiting.Closes #573
Test seams
Evidence
an_issue_labelled_ready_for_agent_less_than_thirty_minutes_ago_is_not_takenfailed: the old code dispatched an issue labelled 29 minutes ago.After: passes; the issue is skipped until thirty minutes have passed.
cargo test --test pickup_run zero_pickup_wait_ignores_server_timestamps_ahead_of_local_clock -- --exact, failed with zero sessions and “less than 0 minutes ago”.After: passes with a dispatched Run and a ready-for-review PR; the regression is retained.
cargo check --all-targets,cargo fmt --check, andcargo clippy --all-targets -- -D warningspassed. Fullcargo testpassed.Review
Reviewed against
mainwiththirdshift-code-review. Standards: 0 findings. Spec: 1 behavioral finding, reproduced as written and fixed; the reviewer confirmed the fix. Both reviewers read all 11 changed files, including the final correction. No changed files were left unread by either axis.Unaddressed findings
Merge Danger
Door: two-way
Blast Radius: passes
The default adds twenty minutes before an issue becomes a Ready issue, including the Architect gate. Set
pickup.wait_minutes = 10to retain the previous window.Built with codex · gpt-6.1-sol · xhigh