Skip to content

GEOPY-3100: Crash on active cells of DC2D inversion - #492

Merged
domfournier merged 15 commits into
developfrom
GEOPY-3100
Oct 13, 2026
Merged

domfournier merged 15 commits into
developfrom
GEOPY-3100

Conversation

@domfournier

@domfournier domfournier commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

GEOPY-3100 - Crash on active cells of DC2D inversion

Copilot AI balanced review requested due to automatic review settings October 13, 2026 14:00
@github-actions github-actions Bot changed the title GEOPY-3100 GEOPY-3100: Crash on active cells of DC2D inversion Oct 13, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Unreferenced electrode vertices retain uninitialized coordinates that can still crash active-cell expansion.

1 open finding
What changed in this PR

Updates DC/IP 2D electrode draping to account for multiple survey-line mesh parts and refreshes dependencies.

Changes:

  • Drapes receiver/source electrodes per survey part.
  • Reuses draped locations for surveys and active-cell expansion.
  • Refreshes Python 3.12/3.13 lockfiles and geoh5py compatibility.
File Description
simpeg_drivers/​components/​data.py Implements part-aware electrode draping.
simpeg_drivers/​components/​factories/​survey_factory.py Uses combined draped locations.
simpeg_drivers/​utils/​utils.py Uses draped electrodes for containing cells.
simpeg_drivers/​components/​topography.py Updates the Entity import path.
py-3.13.conda-lock.yml Refreshes consolidated Python 3.13 dependencies.
environments/​py-3.13-win-64.conda.lock.yml Refreshes Python 3.13 Windows runtime lock.
environments/​py-3.13-win-64-dev.conda.lock.yml Refreshes Python 3.13 Windows development lock.
environments/​py-3.13-linux-64.conda.lock.yml Refreshes Python 3.13 Linux runtime lock.
environments/​py-3.13-linux-64-dev.conda.lock.yml Refreshes Python 3.13 Linux development lock.
environments/​py-3.12-win-64.conda.lock.yml Refreshes Python 3.12 Windows runtime lock.
environments/​py-3.12-win-64-dev.conda.lock.yml Refreshes Python 3.12 Windows development lock.
environments/​py-3.12-linux-64.conda.lock.yml Refreshes Python 3.12 Linux runtime lock.
environments/​py-3.12-linux-64-dev.conda.lock.yml Refreshes Python 3.12 Linux development lock.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread simpeg_drivers/components/data.py
benk-mira
benk-mira previously approved these changes Oct 13, 2026
@codecov

codecov Bot commented Oct 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.51%. Comparing base (caac6e5) to head (7645523).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #492      +/-   ##
===========================================
+ Coverage    90.47%   90.51%   +0.03%     
===========================================
  Files          111      111              
  Lines         7126     7134       +8     
  Branches       884      886       +2     
===========================================
+ Hits          6447     6457      +10     
+ Misses         457      456       -1     
+ Partials       222      221       -1     
Files with missing lines Coverage Δ
simpeg_drivers/components/data.py 96.00% <100.00%> (+0.39%) ⬆️
...peg_drivers/components/factories/survey_factory.py 94.92% <100.00%> (-0.03%) ⬇️
simpeg_drivers/components/topography.py 96.49% <100.00%> (+3.50%) ⬆️
simpeg_drivers/driver.py 87.04% <100.00%> (ø)
simpeg_drivers/electromagnetics/base_1d_driver.py 88.46% <100.00%> (+0.14%) ⬆️
simpeg_drivers/utils/utils.py 61.56% <100.00%> (-1.17%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@domfournier
domfournier merged commit f6929c3 into develop Oct 13, 2026
20 of 21 checks passed
@domfournier
domfournier deleted the GEOPY-3100 branch October 13, 2026 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants