Repository navigation
GEOPY-3100: Crash on active cells of DC2D inversion - #492
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Unreferenced electrode vertices retain uninitialized coordinates that can still crash active-cell expansion.
1 open finding
What changed in this PR
Updates DC/IP 2D electrode draping to account for multiple survey-line mesh parts and refreshes dependencies.
Changes:
- Drapes receiver/source electrodes per survey part.
- Reuses draped locations for surveys and active-cell expansion.
- Refreshes Python 3.12/3.13 lockfiles and geoh5py compatibility.
| File | Description |
|---|---|
simpeg_drivers/components/data.py |
Implements part-aware electrode draping. |
simpeg_drivers/components/factories/survey_factory.py |
Uses combined draped locations. |
simpeg_drivers/utils/utils.py |
Uses draped electrodes for containing cells. |
simpeg_drivers/components/topography.py |
Updates the Entity import path. |
py-3.13.conda-lock.yml |
Refreshes consolidated Python 3.13 dependencies. |
environments/py-3.13-win-64.conda.lock.yml |
Refreshes Python 3.13 Windows runtime lock. |
environments/py-3.13-win-64-dev.conda.lock.yml |
Refreshes Python 3.13 Windows development lock. |
environments/py-3.13-linux-64.conda.lock.yml |
Refreshes Python 3.13 Linux runtime lock. |
environments/py-3.13-linux-64-dev.conda.lock.yml |
Refreshes Python 3.13 Linux development lock. |
environments/py-3.12-win-64.conda.lock.yml |
Refreshes Python 3.12 Windows runtime lock. |
environments/py-3.12-win-64-dev.conda.lock.yml |
Refreshes Python 3.12 Windows development lock. |
environments/py-3.12-linux-64.conda.lock.yml |
Refreshes Python 3.12 Linux runtime lock. |
environments/py-3.12-linux-64-dev.conda.lock.yml |
Refreshes Python 3.12 Linux development lock. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
benk-mira
previously approved these changes
Oct 13, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #492 +/- ##
===========================================
+ Coverage 90.47% 90.51% +0.03%
===========================================
Files 111 111
Lines 7126 7134 +8
Branches 884 886 +2
===========================================
+ Hits 6447 6457 +10
+ Misses 457 456 -1
+ Partials 222 221 -1
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

GEOPY-3100 - Crash on active cells of DC2D inversion