Skip to content

feat: add D-Bus media console and notification feed - #8

Merged
MoazMustafa-stack merged 16 commits into
mainfrom
dbus-media-core
Sep 26, 2026
Merged

MoazMustafa-stack merged 16 commits into
mainfrom
dbus-media-core

Conversation

@MoazMustafa-stack

@MoazMustafa-stack MoazMustafa-stack commented Sep 18, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • add the session-bus D-Bus capability probe and protocol v5 media/notification models
  • add signal-driven MPRIS discovery, bounded authoritative media state, and six-verb fail-closed controls
  • add an opt-in, memory-only notification monitor with 32-entry and 4 KiB drop-oldest bounds
  • publish live media and notification changes over IPC after the initial frontend request
  • add keyboard-only media console and notification feed panels for the 320 x 180 interface
  • add private-bus scale, fault, parser, denial, churn, coalescing, and disconnect validation
  • add the cumulative Phase 5 security and resource release gate

Privacy and safety

  • notification monitoring defaults to disabled and requires VELORA_NOTIFICATIONS_ENABLED=true
  • media has an independent VELORA_MEDIA_ENABLED gate
  • automated tests use disabled integrations or a private dbus-daemon, never the live session bus
  • Godot never executes OS commands
  • Core accepts only opaque player handles and six fixed MPRIS verbs
  • no arbitrary D-Bus destination, method, argument, shell command, or notification action crosses IPC
  • notification state remains memory-only

Automated validation

  • cargo fmt --all --check
  • 223 Rust tests: 196 Core, 24 protocol, 3 bridge
  • cargo clippy --workspace --all-targets -- -D warnings
  • complete headless Godot validation, including P5.07, P5.08, and P5.10
  • cumulative static security and D-Bus allowlist checks
  • isolated development-supervisor lifecycle test
  • native IPC shutdown/restart/reconnect test
  • Phase 4 resource gate
  • Phase 5 private-D-Bus resource gate: 0.0% sampled idle CPU, about 1.8 MiB fixed RSS overhead, 0 KiB growth over five seconds
  • git diff --check

GitHub CI status

GitHub Actions run 35400044414 is red without executing any steps. Its check
annotation states: "The job was not started because your account is locked due
to a billing issue." This is an account/runner failure, not a repository test
failure; the complete local gate above is the current source of truth.

Manual acceptance before merge

  • run Velora inside the real Hyprland session
  • confirm the media console follows a real MPRIS player
  • exercise supported media controls using only the keyboard
  • confirm notifications remain unavailable with the default privacy setting
  • run with VELORA_NOTIFICATIONS_ENABLED=true and confirm the feed updates live
  • stop/restart Core and confirm media/notification recovery without restarting Godot
  • exit Velora and confirm normal Hyprland behavior

Do not merge until the manual acceptance checklist has been completed.

@MoazMustafa-stack

Copy link
Copy Markdown
Owner Author

Review and acceptance update — 2026-09-26

The owner confirmed all real-session manual acceptance items in the Codex task: Hyprland runtime, live MPRIS metadata and supported keyboard controls, default-disabled notifications, explicit opt-in feed updates, Core restart recovery without restarting Godot, and clean exit. This is user-reported acceptance, not an automated reproduction of the live session.

Review found and fixed an IPC cancellation bug: partial requests lost their prefix when a pushed snapshot interrupted the read. The frame accumulator now belongs to the connection. A deterministic poll/cancel/resume regression verifies the complete request and next frame survive.

Fresh local ./scripts/velora.sh gate passed after that fix: 224 Rust tests (197 Core, 24 protocol, 3 bridge), formatting, strict Clippy, all headless Godot suites, security checks, and resource gates. Idle Core CPU 0.0%, sampled RSS growth 20 KiB; private-D-Bus overhead 1912 KiB and 0 KiB growth. git diff --check passed.

GitHub CI run 36167345854 did not execute: “The job was not started because your account is locked due to a billing issue.” CI has not passed; local gate evidence is used as authorized by the owner.

Review outcome: the identified defect is resolved and the Phase 5 merge checkpoint is met. No private docs or unrelated media are included.

@MoazMustafa-stack
MoazMustafa-stack merged commit 5bdf1dc into main Sep 26, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant