Repository navigation
Extracted geometry: commissioning v01/v02 become extracted v05/v06, default v06 - #2082
Merged
Merged
Conversation
…efault v06 geom_common_commissioning_v01.txt (run 123680) and _v02.txt (runs 125470 and later) are renamed geom_common_extracted_v05.txt and _v06.txt, so the KPP setups form one versioned family. Each now includes geom_common_extracted_v04.txt directly instead of the geom_common_extracted.txt pointer, which keeps the versions fixed and avoids an include loop. The pointer geom_common_extracted.txt moves from v04 to v06, the detectors where they are now; the CRV is unchanged, only the tracker, calorimeter, MBS and DS3 extension move. The v06 calorimeter comment, copied from v01, now matches its values. The gdmldump configs are renamed with the files. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014osFTVFtXjUZ6SdxpwLCHo
Collaborator
|
☀️ The build tests passed at 792c73b.
N.B. These results were obtained from a build of this Pull Request at 792c73b after being merged into the base branch at 97cd5c9. For more information, please check the job page here. |
brownd1978
approved these changes
Oct 29, 2026
bonventre
approved these changes
Oct 29, 2026
This was referenced Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The two commissioning geometries from #2051 join the extracted family as versions v05 and v06. The extracted pointer moves to v06, so the extracted configs use the detectors where they are now.
geom_common_extracted_v04.txtdirectly, not thegeom_common_extracted.txtpointer. So the versions stay fixed, and pointing the pointer at them doesn't make an include loop.geom_common_extracted.txt, or Production'sgeom_cosmic_extracted.txt, now gets these positions:Tracker/TrkRecoFromDigi.fcl, which brings inCombined_Pass1;gdmldump_extracted.fcl;geom_cosmic_commissioning_v02.txt, replaced in cosmic: geom_cosmic_extracted_v06.txt replaces the commissioning wrapper, add a pinned v04 Production#593.Evidence
The tests ran on the main CI build 78517a3, with this branch on top. Main has since gained only #2079, a magnetic-field map scaling change; the branch is rebased on it.
Before / After: resolved geometry. I printed it with
services.GeometryService.printConfig : true.geom_common_extracted_v05.txtgeom_common_commissioning_v01.txtgeom_common_extracted_v06.txtgeom_common_commissioning_v02.txtgeom_common_extracted.txtgeom_common_commissioning_v02.txtgeom_common_extracted_v04.txtgeom_common_extracted_v04.txtgeom_common_extracted.txtbefore and after differs only in these values:tracker.z0tracker.mother.z0mu2e.detectorSystemZ0calorimeter.caloMotherZ0calorimeter.caloMotherZ1calorimeter.calorimeterZFrontmbs.MBSCZgarage.ds3UpstreamExtensionGeant4 surface check on the same build, which includes the calorimeter update #2059:
geom_common_extracted.txt(now v06): 9,195 volume checks, 0 overlaps.geom_common_extracted_v05.txt: 9,195 volume checks, 0 overlaps.Merge Danger
Door: two-way
Reverting one line of
geom_common_extracted.txtrestores v04.Blast Radius: every extracted job
services.GeometryService.inputFile : "Offline/Mu2eG4/geom/geom_common_extracted_v04.txt". cosmic: geom_cosmic_extracted_v06.txt replaces the commissioning wrapper, add a pinned v04 Production#593 adds the cosmic wrappergeom_cosmic_extracted_v04.txtfor them.geom_common_commissioning_v02.txt.🤖 Generated with Claude Code
https://claude.ai/code/session_014osFTVFtXjUZ6SdxpwLCHo