Repository navigation
cosmic: geom_cosmic_extracted_v06.txt replaces the commissioning wrapper, add a pinned v04 - #593
Merged
Merged
Conversation
…per, add a pinned v04 Follows the Offline rename of geom_common_commissioning_v02.txt to geom_common_extracted_v06.txt: geom_cosmic_commissioning_v02.txt becomes geom_cosmic_extracted_v06.txt. geom_cosmic_extracted.txt follows the Offline pointer, which moves to v06, so the new geom_cosmic_extracted_v04.txt keeps the previous positions for jobs that read samples simulated with them, e.g. MDC2025as. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014osFTVFtXjUZ6SdxpwLCHo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion of Mu2e/Offline#2082, which renames the commissioning geometries to extracted v05 and v06 and moves the extracted pointer to v06.
geom_cosmic_extracted_v06.txtreplacesgeom_cosmic_commissioning_v02.txtfrom cosmic: share the world margins, add geom_cosmic_commissioning_v02.txt #592. It wraps the renamed Offline file, with the shared world margins.geom_cosmic_extracted_v04.txtkeeps the previous positions. It's for jobs that read samples simulated with them, such as MDC2025as.geom_cosmic_extracted.txtitself follows the Offline pointer and now gives v06.ExtractedCRY.fcl,ExtractedCORSIKA.fcl, and the extracted digitize, reco and recoMC configs keep using the pointer files, so they pick up v06.Evidence
The tests ran on the main CI build 78517a34, with Mu2e/Offline#2082 and this branch on top. I printed the resolved geometry with
services.GeometryService.printConfig : true.geom_cosmic_commissioning_v02.txt= Offlinegeom_common_commissioning_v02.txtplus the four 500 m world margins.geom_cosmic_extracted.txtgeom_cosmic_extracted_v06.txtgeom_cosmic_extracted_v06.txtgeom_common_extracted_v06.txtgeom_cosmic_extracted_v04.txtgeom_common_extracted_v04.txtOffline
geom_common_extracted_v06.txthas the same 7,064 parameters as the oldgeom_common_commissioning_v02.txt, so the wrapper for the remake keeps its content.Merge Danger
Door: two-way
Blast Radius: cosmic wrappers
Merge together with Mu2e/Offline#2082:
geom_cosmic_extracted_v06.txtincludes a file that doesn't exist yet.geom_cosmic_commissioning_v02.txtincludes a removed file.Neither file is used by a config in this repository.
🤖 Generated with Claude Code
https://claude.ai/code/session_014osFTVFtXjUZ6SdxpwLCHo