Repository navigation
Fix exact-ID explain assertions across MongoDB plans - #105
Merged
Merged
Conversation
Extract the existing explain reader without changing its index-name-only decision, then cover IDHACK, classic, SBE, EXPRESS and rejected plans. Co-authored-by: Alessandro Giorgetti <alessandro.giorgetti@live.com> Co-authored-by: Codex (OpenAI) <codex@openai.com>
Accept the implicit built-in IDHACK access path without coupling the audit to one engine layout. Verify the index catalog, one returned document, one examined key/document, and no COLLSCAN. Add a forced-natural-scan negative control and changelog entry. Production behavior and MongoDB 4.2 minimum are unchanged. Co-authored-by: Alessandro Giorgetti <alessandro.giorgetti@live.com> Co-authored-by: Codex (OpenAI) <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #94.
_id_index definition, exactly one returned document/key/document examined, and no COLLSCAN for the seeded exact-ID lookup.Test-first validation
Regression commit
9486d022d23ae0dd10ebe81fbf790209d6b5a1e1preserved the old decision. CI run 41856735204 built on Ubuntu and Windows, then produced exactly the two new IDHACK failures on each of net8.0/net9.0/net10.0: 582 passed, 2 failed, 0 skipped per target.With the fix:
NumPossibleCPUsNoCache). No live MongoDB 8 result is claimed.1f8bb2cca135c459f3586e18ac946c49acd163b9: Ubuntu/Windows builds and all MongoDB 9.0.4 test jobs. Each of net8.0/net9.0/net10.0 passed 585 tests, 0 failed, 0 skipped. Existing CI is unchanged. net472 runtime tests were not run.Co-authored by Alessandro Giorgetti and Codex (OpenAI).