Repository navigation
Fix the sysvinit scripts of the chromium and qt-kiosk-browser launchers - #144
Merged
otavio merged 4 commits intoNov 11, 2026
Conversation
…name
INITSCRIPT_NAME was "${BPM}", an undefined variable, so update-rc.d
registered a script literally named "${BPM}" and the installed
/etc/init.d/chromium-ozone-wayland never started. Tested: package_qa
with DISTRO=oel-tiny + sysvinit; the postinst now runs update-rc.d on
chromium-ozone-wayland.
Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
…ript meta-browser installs the browser only as /usr/bin/chromium; there is no /usr/bin/chromium-ozone-wayland, so the "[ -x $DAEMON ] || exit 0" guard made the sysvinit script a silent no-op. The systemd unit already runs /usr/bin/chromium. NAME stays, as it names the pidfile and the /etc/default file. Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
The script was installed as /etc/init.d/kiosk while INITSCRIPT_NAME, the systemd unit and the /etc/default file all use qt-kiosk-browser, so update-rc.d linked a script that does not exist. Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
…onfig NAME was "qt-kiosk-browser-init", so the script looked for /usr/bin/qt-kiosk-browser-init and /etc/qt-kiosk-browser-init.conf; neither exists, and "test -x || exit 0" made it a silent no-op. It also never read /etc/default/qt-kiosk-browser, which carries WAYLAND_DISPLAY, XDG_RUNTIME_DIR and QTWEBENGINE_CHROMIUM_FLAGS for the systemd unit. Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
lucianogdittgen
marked this pull request as draft
November 10, 2026 18:31
lucianogdittgen
marked this pull request as ready for review
November 10, 2026 19:11
This was referenced Nov 11, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both sysvinit scripts were silent no-ops:
INITSCRIPT_NAMEwas${BPM}, an undefined variable, so update-rc.d registered a script with that literal name.DAEMONpointed at/usr/bin/chromium-ozone-wayland, but meta-browser installs only/usr/bin/chromium(which is what the systemd unit already runs)./etc/init.d/kiosk, whileINITSCRIPT_NAME, the systemd unit and/etc/defaultuseqt-kiosk-browser.NAMEmade it look for a binary and config that do not exist, and it never read/etc/default/qt-kiosk-browser(WAYLAND_DISPLAY, XDG_RUNTIME_DIR, QTWEBENGINE_CHROMIUM_FLAGS).Tested with stub browser layers: package_qa passes for oel, oel + sysvinit and oel-tiny + sysvinit, systemd packaging is unchanged, and the sysvinit postinst runs update-rc.d on the real script names.