Repository navigation
Conversation
The workflow took the lint shell from the tip of yocto-env.nix, so the oelint-adv 9.11.3 bump there (oelint.task.nocopy) failed OE Lint on master and on every open pull request at once, with no change in this layer. Pin the yocto-env.nix revision instead; a bump becomes its own pull request, which lints the layer with the new oelint-adv first. The layer has no flake.* for nix-actions to hash, so the store cache key was a constant 'nix-Linux-'. The first cache saved was never replaced, and every run built oelint-adv from source again. Append the pinned revision to the key, so each bump saves a cache with its tools. Save it only from master pushes; pull requests restore master's cache instead of each saving a private copy. Also limit the token to 'contents: read'; the job only reads the tree. Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
lucianogdittgen
force-pushed
the
ci/oelint-pin-yocto-env
branch
from
November 10, 2026 18:46
dbd6c9c to
a3a9ee3
Compare
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OE Lint took its tools from the tip of
OSSystems/yocto-env.nix#lint. The oelint-adv 9.11.3 bump there (oelint.task.nocopy) failed master and every open pull request (#134 to #147) at once, with no change in this layer. This pins the yocto-env.nix revision (e181bff, oelint-adv 9.11.3), so an oelint-adv bump becomes its own pull request, which lints the layer before it lands.It also fixes the Nix store cache. The layer has no
flake.*for nix-actions to hash, so the key was alwaysnix-Linux-, the cache saved in August was never replaced, and every run built oelint-adv from source. The key now ends in the pinned revision, and only master pushes save it; pull requests restore master's cache. The job token is limited tocontents: read.Checked: actionlint is clean, and
contrib/oelint/run-oelint.shin the pinned shell passes on master + #148. This needs #148 merged first to go green, since it lints the same master tree.wrynosehas the same workflow, hence thebackport wrynoselabel.