Repository navigation
Select compact sensor decoding from the actual firmware version - #156
Merged
Merged
Conversation
|
Visit the preview URL for this PR (updated for commit 07456ab): https://open-earable-lib-web-example--pr156-codex-select-ble-f-l33flavo.web.app (expires Sun, 01 Nov 2026 21:11:17 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 7f6db4d9d00b851ad49af109fa949061904b3151 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Real-device testing found that the factory's historically named firmware getter actually reads hardware generation UUID
45622512. Passing this value to the new transport selector made firmware 2.3.0 use the legacy decoder: IMU CSVs contained NaNs and PPG readings exceeded the 19-bit range.Keep hardware generation for V1/V2 device identification. Read firmware UUID
45622513separately before selecting the sensor parser on each connection. This also supports development firmware labels without changing generation matching.Validation: the factory/GATT regression test fails before this fix and passes afterward across 2.2.9 → 2.3.0 → prerelease → 2.2.9. All 47 library tests pass and analysis is clean. Live Android Recorder repeat passes: firmware 2.3.0 delivers 99.67 Hz IMU and 512.27 Hz PPG in separate 30-second windows, with finite values, valid PPG range, no backward timestamps and zero app parsing exceptions. A connected legacy-firmware earphone remains correct. Full 2.2.9 and paired 2.3.0 release testing continues.