Read saved LED state on firmware 2.3.0 - #157
Merged
Merged
Conversation
|
Visit the preview URL for this PR (updated for commit 6b9f4d4): https://open-earable-lib-web-example--pr157-codex-led-state-re-o03a06c2.web.app (expires Mon, 02 Nov 2026 02:13:57 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 7f6db4d9d00b851ad49af109fa949061904b3151 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose an optional LED state reader for firmware 2.3.0 so the app can restore the saved status/manual mode and RGB color when reopening device controls. Older firmware keeps its existing write-only controls and receives no LED reads.
Validation: 49 library tests pass, including factory capability selection across 2.2.9, 2.3.0, development firmware and downgrade; analysis clean. Invalid readback is rejected. Live Pixel app validation passed on both 2.3.0 earphones: disabled state and RGB color restored after reopening. Both official 2.2.9 ears retain working write-only controls. Firmware read/notify verified independently.