Repository navigation
Add dbt-run and dbt-version facets validation - #257
Closed
pawelmarut wants to merge 1 commit into
Closed
pawelmarut wants to merge 1 commit into
pawelmarut wants to merge 1 commit into
Conversation
Signed-off-by: Pawel Marut <pawel.marut@xebia.com>
pawelmarut
force-pushed
the
feature/dbt-validation
branch
from
January 29, 2026 15:23
8e62d25 to
2dddf25
Compare
tnazarew
added a commit
that referenced
this pull request
Nov 4, 2026
Load dbt-version-run-facet.json and dbt-run-run-facet.json from the common package so the dbt_version and dbt_run facets are schema-validated instead of skipped. They stay in the skip list as a fallback for OpenLineage releases before 1.40, whose schemas live outside the src/ layout that the spec collection copies. dbt_model stays skipped, it has no published schema. Folds in #257. Co-authored-by: Pawel Marut <pawel.marut@xebia.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: tnazarew <tomasz.nazarewicz@getindata.com>
Collaborator
|
folded into #337, closing |
Collaborator
|
Thanks for this! The facet-validation change is in #337, which also had to touch One difference: |
tnazarew
added a commit
that referenced
this pull request
Nov 4, 2026
* Skip schema validation of the dbt_model dataset facet openlineage-dbt emits dbt_model (DbtModelDatasetFacet) with _schemaURL .../integration/common/openlineage/schema/dbt-model-dataset-facet.json, but that file is not published at any OpenLineage tag or on main; the facet exists only in facets.py. Syntax validation therefore fails with "facet type dbt_model not recognized". Treat it like dbt_version and dbt_run until upstream publishes the schema. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: tnazarew <tomasz.nazarewicz@getindata.com> * dbt: validate dbt_run and dbt_version facets against their schemas Load dbt-version-run-facet.json and dbt-run-run-facet.json from the common package so the dbt_version and dbt_run facets are schema-validated instead of skipped. They stay in the skip list as a fallback for OpenLineage releases before 1.40, whose schemas live outside the src/ layout that the spec collection copies. dbt_model stays skipped, it has no published schema. Folds in #257. Co-authored-by: Pawel Marut <pawel.marut@xebia.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: tnazarew <tomasz.nazarewicz@getindata.com> --------- Signed-off-by: tnazarew <tomasz.nazarewicz@getindata.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Pawel Marut <pawel.marut@xebia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.