Repository navigation
dbt: validate dbt_run/dbt_version facets, skip dbt_model - #337
Merged
Merged
Conversation
openlineage-dbt emits dbt_model (DbtModelDatasetFacet) with _schemaURL .../integration/common/openlineage/schema/dbt-model-dataset-facet.json, but that file is not published at any OpenLineage tag or on main; the facet exists only in facets.py. Syntax validation therefore fails with "facet type dbt_model not recognized". Treat it like dbt_version and dbt_run until upstream publishes the schema. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: tnazarew <tomasz.nazarewicz@getindata.com>
tnazarew
force-pushed
the
dbt/skip-dbt-model-facet-schema
branch
from
November 4, 2026 17:08
30d77d5 to
0bc0e38
Compare
Load dbt-version-run-facet.json and dbt-run-run-facet.json from the common package so the dbt_version and dbt_run facets are schema-validated instead of skipped. They stay in the skip list as a fallback for OpenLineage releases before 1.40, whose schemas live outside the src/ layout that the spec collection copies. dbt_model stays skipped, it has no published schema. Folds in #257. Co-authored-by: Pawel Marut <pawel.marut@xebia.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: tnazarew <tomasz.nazarewicz@getindata.com>
tnazarew
changed the title
tnazarew
marked this pull request as ready for review
November 4, 2026 19:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
dbt syntax validation fails on recent openlineage-dbt releases with
facet type dbt_model not recognized.openlineage-dbt has emitted the
dbt_modeldataset facet (DbtModelDatasetFacet) since about 1.47, with_schemaURL…/integration/common/openlineage/schema/dbt-model-dataset-facet.json. That schema file doesn't exist at any OpenLineage tag or onmain: the facet is defined only inintegration/common/src/openlineage/common/provider/dbt/facets.py. The validator has no schema to load, so the facet is reported as unrecognized.At the same time
dbt_runanddbt_versionwere skipped although their schemas are published (#257).Change
dbt-model-dataset, next to the other dbt common facets. Revert once upstream publishes the schema.dbt-version-run-facet.jsonanddbt-run-run-facet.jsoninis_facet, sodbt_versionanddbt_runare validated against their schemas.dbt-version-runanddbt-run-runstay in the skip list as a fallback. The skip list is only used when no schema is loaded, and for OpenLineage < 1.40 the schemas live inintegration/common/openlineage, which the spec collection inrun_event_validationdoesn't copy. Removing them would make those releases fail withnot recognized.producer/dbt/runner/openlineage.ymlpath change is left out: CI doesn't use that file (run.shwrites its own config).Verification
dbt_modelskip.openlineage-integration-common==1.55.0, validated against the 1.55.0 spec collected the way CI does:dbt_run/dbt_versionschema-validated,dbt_modelskippeddbt_model not recognizeddbt_modelnot recognizedThe PR checks skip the dbt job when only
scripts/changes, so the first CI run of this is the next dbt release check.Supersedes #257.
🤖 Generated with Claude Code