Repository navigation
fix(cache): define the doctrine_cache redis connection used by the Doctrine result cache #642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| <?php namespace Tests\Unit\Services; | ||
| /** | ||
| * Copyright 2026 OpenStack Foundation | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| **/ | ||
|
|
||
| use App\Models\Foundation\Main\IGroup; | ||
| use models\summit\SummitAttendee; | ||
| use Tests\InsertMemberTestData; | ||
| use Tests\InsertSummitTestData; | ||
| use Tests\TestCase; | ||
|
|
||
| /** | ||
| * Class DoctrineResultCacheTest | ||
| * The result cache of the model entity manager goes to the doctrine_redis store, whose connection | ||
| * (doctrine_cache) must exist: Symfony's cache adapter swallows the "connection not configured" | ||
| * exception, so a missing connection shows up only as a cache that never stores anything. | ||
| */ | ||
| class DoctrineResultCacheTest extends TestCase | ||
| { | ||
| use InsertSummitTestData; | ||
| use InsertMemberTestData; | ||
|
|
||
| protected function setUp(): void | ||
| { | ||
| parent::setUp(); | ||
| self::insertMemberTestData(IGroup::TrackChairs); | ||
| self::$defaultMember = self::$member; | ||
| self::insertSummitTestData(); | ||
| } | ||
|
|
||
| public function tearDown(): void | ||
| { | ||
| self::clearSummitTestData(); | ||
| self::clearMemberTestData(); | ||
| parent::tearDown(); | ||
| } | ||
|
|
||
| private function resultCache() | ||
| { | ||
| return self::$em->getConfiguration()->getResultCache(); | ||
| } | ||
|
|
||
| private function badgeFeaturesKey(int $attendee_id): string | ||
| { | ||
| return sprintf("ATTENDEES_%s_BADGE_FEATURES", $attendee_id); | ||
| } | ||
|
|
||
| public function testResultCacheSavesAndServesAnItem() | ||
| { | ||
| $cache = $this->resultCache(); | ||
| $key = 'result-cache-test'; | ||
| $cache->deleteItem($key); | ||
|
|
||
| $item = $cache->getItem($key); | ||
| $this->assertFalse($item->isHit()); | ||
| $item->set('value')->expiresAfter(60); | ||
| $this->assertTrue($cache->save($item), 'the result cache must be able to store an item'); | ||
|
|
||
| $this->assertTrue($cache->getItem($key)->isHit()); | ||
| $this->assertSame('value', $cache->getItem($key)->get()); | ||
|
|
||
| $cache->deleteItem($key); | ||
| $this->assertFalse($cache->getItem($key)->isHit()); | ||
| } | ||
|
|
||
| public function testAllowedBadgeFeaturesAreCachedAndEvicted() | ||
| { | ||
| $attendee_id = self::$summit->getAttendees()[0]->getId(); | ||
| $attendee = self::$em->find(SummitAttendee::class, $attendee_id); | ||
| $cache = $this->resultCache(); | ||
| $key = $this->badgeFeaturesKey($attendee_id); | ||
| $cache->deleteItem($key); | ||
|
|
||
| $attendee->getAllowedBadgeFeatures(); | ||
| $this->assertTrue($cache->getItem($key)->isHit(), 'getAllowedBadgeFeatures must leave its entry in the result cache'); | ||
|
|
||
| $attendee->evictAllowedBadgeFeaturesCache(); | ||
| $this->assertFalse($cache->getItem($key)->isHit(), 'evictAllowedBadgeFeaturesCache must remove the entry'); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.