Repository navigation
Held-out data registry: round 7's follow-ups (unset event path, record ids, zero push boundary) - #580
Merged
Merged
Conversation
Round 7 of #560's review approved it and left two low findings and one optional hardening. This commit answers the first and the hardening: - With GITHUB_EVENT_PATH unset, removing TypeError from _event's handler survived both registry modules. test_an_unset_event_path_raises covers a push and a pull_request event with the path unset; each raises LookupError. - base_commit lets an all-zero before commit fall back to the merge base only when the push event also sets created to true, as GitHub does when a push creates its branch. Any other all-zero push raises LookupError rather than check less history. test_a_zero_push_boundary_needs_a_created_branch covers created missing, false, "true" and 1; three more payloads join test_a_push_without_a_resolvable_before_raises. The second finding (truncated ids in the mutation record) is answered by rerunning the record with ids taken from pytest's report node ids, in a later commit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Brings in #582, the pull-request history check from the fork point. It changed history_problems and the landed union; this branch changes _event and base_commit, so git merged both cleanly. The tier counts are master's until the recount. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
After the master merge, check 25's target also matches the new union readiness check, and check 69's line was renamed. Check 25 now carries its following line so it names the append-only site alone; check 69 targets the renamed line. Results are rerun in the next commit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Master brings #587 (ledger delta), #575 (D1a) and #570 (SM1). None of them changes the registry module, its tests or its mutation specs, and the registry module imports only the standard library and yaml. The tier conflict resolves to master's counts plus this branch's nine unit tests: unit 18,549 + 9 = 18,558, total 25,128. The README tier table now matches the tier file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
3 of 7 tasks
All 77 checks are killed. The two new checks cover this branch's changes: an unset event path that leaks TypeError (check 75) and a zero push boundary that falls back without `created` (check 76). Every failed id now comes from pytest's own report node id, so check 73's parametrized ids keep their nested brackets. The restored registry source's SHA-256 is 9ca7fc52839d637f29596f369578ff255a528114fe8956c767e4fb3d84ddac5d. The run was resumable: each check was saved as it finished, and a host disk hold and a memory-pressure stop each restarted it from the saved checks, against the same source SHA-256. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Master brings #566 (OP1: the open_population package and its evidence), #589 (OP1's report) and changes to the birth-evidence script and its artifact test. None of it changes the registry module, its two test modules or its mutation specs, and the registry module imports only the standard library and yaml. The tier conflict resolves to master's counts plus this branch's nine unit tests: unit 18,780 + 9 = 18,789, total 25,359. The README tier table matches the tier file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MaxGhenis
marked this pull request as ready for review
October 26, 2026 09:31
Contributor
Author
|
Merged at head
This PR held the tier-count slot. The next slot holder re-merges master and recounts. |
This was referenced Oct 26, 2026
MaxGhenis
added a commit
that referenced
this pull request
Oct 26, 2026
Master brings #589, #590 and #580: an OP1 report section, a docs ledger, and the held-out registry's module, tests and mutation record. None is a B0.2 file or anything B0.2's script imports. The tier files conflicted. Resolved as master's counts plus this branch's unit delta: 18,789 + 236 = 19,025 unit, total 25,595. The other tiers are unchanged, and the README table matches. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MaxGhenis
added a commit
that referenced
this pull request
Oct 26, 2026
Master brings #566, #589, #590 and #580. Git auto-merged scripts/first_estimates_birth_evidence.py and tests/estimates/test_birth_evidence_artifact.py, which both branches changed: against each parent the merged files only add lines, so the merge keeps master's OP1 exclusions and CE1's exclusions and removes no line from either side. No CE1 path changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups to #560, whose round-7 review approved it and left two low findings and one optional hardening.
Changes
GITHUB_EVENT_PATHunset, removingTypeErrorfrom_event's handler survived both registry test modules.test_an_unset_event_path_raisesnow covers apushand apull_requestevent with the path unset; each raisesLookupError.base_commitlets an all-zerobeforefall back to the merge base only when the push event also hascreated: true, which is how GitHub marks a push that creates its branch. Any other all-zero push raisesLookupError, so the check never compares with a nearer commit and checks less history.test_a_zero_push_boundary_needs_a_created_branchcoverscreatedmissing,false,"true"and1.report.nodeidthrough a small reporting plugin. The whole record is rerun on the merged source (4688ec5c), with two new checks for the changes above: 77 in all, all killed.Plan
b111ad9f: 216 passed; 8 passed, 2 skipped; 13 passed (237 passed, 2 skipped)4688ec5c): 77 of 77 killed; restored-source SHA-2569ca7fc52839d637f29596f369578ff255a528114fe8956c767e4fb3d84ddac5d. The run was resumable and restarted twice from its saved checks (a host disk hold and a memory-pressure stop), against the same source SHA-256, which the master merges leave unchanged.9967dfd6, merged at8e195c41and recounted at2545856b(whole-suite--collect-only -m unit: 18,348 of 24,897)d8302233(Parity ledger: CE0, OP0.1, the registry, U2's evidence record and F0/F1 status #587, PSID income and wealth readers and field registry (D1a) #575, SM1: differential mortality by lifetime earnings, education and race (normalized within age-sex-year cells) #570) at9ccbbb12: unit 18,549 + 9 = 18,558, total 25,128, README table matched; CI green at9ccbbb12, its full collection confirming the count. Master's changes touch neither the registry module (standard library and yaml imports only) nor its tests or specs.0f69bbb2(OP1: open-population harness around the sealed loop #566, Fix review r10's report findings for OP1 #589) atb111ad9f: unit 18,780 + 9 = 18,789, total 25,359, README table matched. CI's full collection confirmed it: green atb111ad9f. Master has since moved to9cced8ff(Ledger: SM1, OP1 and D1's first part merged, with the in-review PRs they touch #590), which changes one docs file and neither tier file.b111ad9f: APPROVE (Opus 5.5; the Sol attempt stopped when the model was at capacity). All three round-7 items are resolved in substance. It left two low, nonblocking findings for a follow-up:_eventlets aRecursionErrorthrough on a deeply nested payload (unchanged since Track B: held-out data registry for every Track B and open-population gate #560, and it fails closed), and the 64-digit all-zerobeforehas no test.Invariants
beforecommit when it resolves, the merge base only on a push that creates its branch, andLookupErrorotherwise. No payload selects a nearer boundary.LookupErroron bothpushandpull_request, never another exception type and never a silent skip.axiom: n/a: test infrastructure for the held-out data registry
Check numbering: the messages of
4688ec5candfca34901count checks from 0. Counting from 1, as the record and the reviews do, the two new checks are 76 and 77, and the re-anchored ones are 26 and 70.🤖 Generated with Claude Code