Skip to content

Held-out data registry: round 7's follow-ups (unset event path, record ids, zero push boundary) - #580

Merged
MaxGhenis merged 10 commits into
masterfrom
trackb-registry-r7-followups
Oct 26, 2026
Merged

MaxGhenis merged 10 commits into
masterfrom
trackb-registry-r7-followups

Conversation

@MaxGhenis

@MaxGhenis MaxGhenis commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Follow-ups to #560, whose round-7 review approved it and left two low findings and one optional hardening.

Changes

  1. Unset event path. With GITHUB_EVENT_PATH unset, removing TypeError from _event's handler survived both registry test modules. test_an_unset_event_path_raises now covers a push and a pull_request event with the path unset; each raises LookupError.
  2. Zero push boundary (hardening). base_commit lets an all-zero before fall back to the merge base only when the push event also has created: true, which is how GitHub marks a push that creates its branch. Any other all-zero push raises LookupError, so the check never compares with a nearer commit and checks less history. test_a_zero_push_boundary_needs_a_created_branch covers created missing, false, "true" and 1.
  3. Mutation record ids. Check 73 recorded two parametrized ids cut at a nested bracket. The runner now takes each failed id from pytest's own report.nodeid through a small reporting plugin. The whole record is rerun on the merged source (4688ec5c), with two new checks for the changes above: 77 in all, all killed.

Plan

Invariants

  • A push is compared with its own boundary: the event's before commit when it resolves, the merge base only on a push that creates its branch, and LookupError otherwise. No payload selects a nearer boundary.
  • An event that cannot be read raises LookupError on both push and pull_request, never another exception type and never a silent skip.

axiom: n/a: test infrastructure for the held-out data registry

Check numbering: the messages of 4688ec5c and fca34901 count checks from 0. Counting from 1, as the record and the reviews do, the two new checks are 76 and 77, and the re-anchored ones are 26 and 70.

🤖 Generated with Claude Code

Round 7 of #560's review approved it and left two low findings and one
optional hardening. This commit answers the first and the hardening:

- With GITHUB_EVENT_PATH unset, removing TypeError from _event's handler
  survived both registry modules. test_an_unset_event_path_raises covers
  a push and a pull_request event with the path unset; each raises
  LookupError.
- base_commit lets an all-zero before commit fall back to the merge base
  only when the push event also sets created to true, as GitHub does
  when a push creates its branch. Any other all-zero push raises
  LookupError rather than check less history.
  test_a_zero_push_boundary_needs_a_created_branch covers created
  missing, false, "true" and 1; three more payloads join
  test_a_push_without_a_resolvable_before_raises.

The second finding (truncated ids in the mutation record) is answered
by rerunning the record with ids taken from pytest's report node ids,
in a later commit.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
social-security-model Ready Ready Preview Oct 26, 2026 6:59am UTC

Request Review

Brings in #582, the pull-request history check from the fork point.
It changed history_problems and the landed union; this branch changes
_event and base_commit, so git merged both cleanly. The tier counts
are master's until the recount.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
After the master merge, check 25's target also matches the new union
readiness check, and check 69's line was renamed. Check 25 now carries
its following line so it names the append-only site alone; check 69
targets the renamed line. Results are rerun in the next commit.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MaxGhenis and others added 2 commits October 25, 2026 03:17
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A whole-suite --collect-only -m unit at 8e195c4 gives 18,348 of
24,897 (6,549 deselected): master 9967dfd's 18,339 plus this branch's
nine.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MaxGhenis and others added 2 commits October 25, 2026 04:53
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Master brings #587 (ledger delta), #575 (D1a) and #570 (SM1). None of
them changes the registry module, its tests or its mutation specs, and
the registry module imports only the standard library and yaml.

The tier conflict resolves to master's counts plus this branch's nine
unit tests: unit 18,549 + 9 = 18,558, total 25,128. The README tier
table now matches the tier file.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MaxGhenis and others added 2 commits October 25, 2026 23:56
All 77 checks are killed. The two new checks cover this branch's changes:
an unset event path that leaks TypeError (check 75) and a zero push
boundary that falls back without `created` (check 76). Every failed id
now comes from pytest's own report node id, so check 73's parametrized
ids keep their nested brackets. The restored registry source's SHA-256
is 9ca7fc52839d637f29596f369578ff255a528114fe8956c767e4fb3d84ddac5d.

The run was resumable: each check was saved as it finished, and a host
disk hold and a memory-pressure stop each restarted it from the saved
checks, against the same source SHA-256.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Master brings #566 (OP1: the open_population package and its evidence),
#589 (OP1's report) and changes to the birth-evidence script and its
artifact test. None of it changes the registry module, its two test
modules or its mutation specs, and the registry module imports only the
standard library and yaml.

The tier conflict resolves to master's counts plus this branch's nine
unit tests: unit 18,780 + 9 = 18,789, total 25,359. The README tier
table matches the tier file.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@MaxGhenis
MaxGhenis marked this pull request as ready for review October 26, 2026 09:31
@MaxGhenis
MaxGhenis merged commit 172f690 into master Oct 26, 2026
12 checks passed
@MaxGhenis

MaxGhenis commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor Author

Merged at head b111ad9f with --match-head-commit, as merge commit 172f690f.

  • Checks. Every check passed on that head (gh pr checks exit 0; deploy skipped). The PR was MERGEABLE and CLEAN, not a draft, with no change requests.
  • Review. Round 8, by an independent Opus 5.5 reviewer run through Subfleet, approved b111ad9f. It raised two low, nonblocking findings, which go to a follow-up PR:
    • L1: a payload nested 200,000 levels deep raises RecursionError, which fails closed;
    • L2: no test covers a zero before.
  • Tier counts. Unit 18,789 and total 25,359, as tests/tier_counts.json records. The three commits on master that this head lacks all come from Ledger: SM1, OP1 and D1's first part merged, with the in-review PRs they touch #590 and change only docs/parity-ledger.md, so the count holds without a re-merge.

This PR held the tier-count slot. The next slot holder re-merges master and recounts.

MaxGhenis added a commit that referenced this pull request Oct 26, 2026
Master brings #589, #590 and #580: an OP1 report section, a docs
ledger, and the held-out registry's module, tests and mutation record.
None is a B0.2 file or anything B0.2's script imports.

The tier files conflicted. Resolved as master's counts plus this
branch's unit delta: 18,789 + 236 = 19,025 unit, total 25,595. The
other tiers are unchanged, and the README table matches.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MaxGhenis added a commit that referenced this pull request Oct 26, 2026
Master brings #566, #589, #590 and #580. Git auto-merged
scripts/first_estimates_birth_evidence.py and
tests/estimates/test_birth_evidence_artifact.py, which both branches
changed: against each parent the merged files only add lines, so the
merge keeps master's OP1 exclusions and CE1's exclusions and removes no
line from either side. No CE1 path changes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch was successfully deployed

1 active deployment
Preview — b111ad9f Deployed Oct 26, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant