Repository navigation
Conversation
… the 64-digit zero before Round 8's review of #580 (APPROVE at b111ad9) left two low findings: - L1: _event let RecursionError through on an event nested too deeply for the JSON parser (200,000 levels), against the module's own rule that an unreadable event raises LookupError. It failed closed, since resolved_base() catches only LookupError. _event now catches RecursionError as _parse_registry already does. test_a_too_deeply_nested_event_raises covers a push and a pull_request whose payloads would otherwise resolve. - L2: only the 40-digit all-zero before was tested, so a fallback limited to 40 digits survived both modules. test_a_zero_push_boundary_needs_a_created_branch now runs on 40 and 64 digits. It also corrects base_commit's docstring (round 8's N3): the zero before falls back only with created set to true. Both new tests fail on their mutants and pass on the fix. Tiers: unit 18,789 + 6 = 18,795, total 25,365. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Reran all 79 checks on holdout_registry.py at 0b31ff14 (afcbf82), one check at a time in a clean clone, single core at nice 10; 79 killed, none survived, and the source was restored to 0b31ff14 after each. - Check 76 ("an unset event path leaks TypeError") is re-anchored to the handler tuple that now includes RecursionError. - New check "a too deeply nested event leaks RecursionError" drops RecursionError from that handler: 2 tests fail. - New check "a 64-digit zero push boundary falls back without created" limits the created check to 40-digit boundaries: 4 tests fail. - The zero-boundary check's failed ids now carry the 40/64 parameter. - Every other check's failed-test list is unchanged. - restored_source_sha256 moves from 9ca7fc52 to 0b31ff14. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MaxGhenis
marked this pull request as ready for review
October 27, 2026 17:06
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Round 8's two low findings on #580 (merged as
172f690f), with the mutation record rerun on the new source.Changes
_eventturns aRecursionErrorfrom the JSON parser intoLookupError, as_parse_registryalready does. Before, an event nested about 200,000 levels deep letRecursionErrorthrough. That broke the rule that an unreadable event raisesLookupError, though it failed closed. New testtest_a_too_deeply_nested_event_raisescovers a push and a pull_request.test_a_zero_push_boundary_needs_a_created_branchnow runs on 40- and 64-digit all-zerobefores. Before, a fallback limited to 40 digits survived both modules.base_commit's docstring now says the zerobeforefalls back only withcreatedset to true.Invariants (unchanged)
LookupErrorand never another exception type.before, or the merge base only for an all-zerobeforewithcreated: true.Checks
RecursionErrordropped from the handler: 2 failed;afcbf820.gh pr checksexits 0 ate83fb252.docs/design/track_b_holdout_registry_mutations.json(e83fb252): all 79 checks rerun on the source atafcbf820(SHA-2560b31ff14…), one at a time in a clean clone, single core at nice 10. 79 killed, none survived; the source was restored after each.RecursionError.e83fb252.LookupError, including arrays 100,000 to 5,000,000 deep._event's handler tuple.created: truefallback for a 64-digit all-zerobefore, so a zero check that knows only 40 digits survives. It fails closed, and this repository uses SHA-1. It goes to a follow-up with nit N-C (each check'scommandomits the id-recording plugin).🤖 Generated with Claude Code