Skip to content

Held-out registry: deeply nested events raise LookupError; test the 64-digit zero before #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MaxGhenis wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Held-out registry: deeply nested events raise LookupError; test the 64-digit zero before #592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
afcbf82
Held-out registry: a too deeply nested event raises LookupError; test…
MaxGhenis Oct 26, 2026
e83fb25
Held-out registry: rerun the mutation record on the new source
MaxGhenis Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 35 additions & 7 deletions docs/design/track_b_holdout_registry_mutations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"admitted_scope": "The held-out data registry's rules on invented registries, temporary git repositories and the committed registry; no population, behavioral or forecast claim.",
"mutation_method": "One deliberate production-line change per check; both registry test modules run in full and are expected to fail; original bytes restored before the next check. Failed test ids are pytest's own report node ids, written by a reporting plugin, not parsed from summary lines. No mutated implementation is committed.",
"restored_source_sha256": {
"src/populace_dynamics/track_b/holdout_registry.py": "9ca7fc52839d637f29596f369578ff255a528114fe8956c767e4fb3d84ddac5d"
"src/populace_dynamics/track_b/holdout_registry.py": "0b31ff1446e26562b29294bd1ef48c8be7f6d6587c1f8e99881bbacf4da240cf"
},
"checks": [
{
Expand Down Expand Up @@ -893,8 +893,8 @@
},
{
"mutation": "an unset event path leaks TypeError",
"old": " except (TypeError, ValueError, OSError) as error:\n raise LookupError(f\"cannot read the GitHub event: {error}\") from None",
"new": " except (ValueError, OSError) as error:\n raise LookupError(f\"cannot read the GitHub event: {error}\") from None",
"old": " except (TypeError, ValueError, OSError, RecursionError) as error:\n raise LookupError(f\"cannot read the GitHub event: {error}\") from None",
"new": " except (ValueError, OSError, RecursionError) as error:\n raise LookupError(f\"cannot read the GitHub event: {error}\") from None",
"command": "PYTHONPATH=$PWD/src OMP_NUM_THREADS=1 OPENBLAS_NUM_THREADS=1 OMP_WAIT_POLICY=PASSIVE python -m pytest -q -p no:cacheprovider -rf tests/test_track_b_holdout_registry.py tests/test_track_b_holdout_registry_committed.py",
"exit_code": 1,
"failed_tests": [
Expand All @@ -909,10 +909,38 @@
"command": "PYTHONPATH=$PWD/src OMP_NUM_THREADS=1 OPENBLAS_NUM_THREADS=1 OMP_WAIT_POLICY=PASSIVE python -m pytest -q -p no:cacheprovider -rf tests/test_track_b_holdout_registry.py tests/test_track_b_holdout_registry_committed.py",
"exit_code": 1,
"failed_tests": [
"tests/test_track_b_holdout_registry.py::test_a_zero_push_boundary_needs_a_created_branch[1]",
"tests/test_track_b_holdout_registry.py::test_a_zero_push_boundary_needs_a_created_branch[False]",
"tests/test_track_b_holdout_registry.py::test_a_zero_push_boundary_needs_a_created_branch[None]",
"tests/test_track_b_holdout_registry.py::test_a_zero_push_boundary_needs_a_created_branch[true]"
"tests/test_track_b_holdout_registry.py::test_a_zero_push_boundary_needs_a_created_branch[1-40]",
"tests/test_track_b_holdout_registry.py::test_a_zero_push_boundary_needs_a_created_branch[1-64]",
"tests/test_track_b_holdout_registry.py::test_a_zero_push_boundary_needs_a_created_branch[False-40]",
"tests/test_track_b_holdout_registry.py::test_a_zero_push_boundary_needs_a_created_branch[False-64]",
"tests/test_track_b_holdout_registry.py::test_a_zero_push_boundary_needs_a_created_branch[None-40]",
"tests/test_track_b_holdout_registry.py::test_a_zero_push_boundary_needs_a_created_branch[None-64]",
"tests/test_track_b_holdout_registry.py::test_a_zero_push_boundary_needs_a_created_branch[true-40]",
"tests/test_track_b_holdout_registry.py::test_a_zero_push_boundary_needs_a_created_branch[true-64]"
]
},
{
"mutation": "a too deeply nested event leaks RecursionError",
"old": " except (TypeError, ValueError, OSError, RecursionError) as error:\n raise LookupError(f\"cannot read the GitHub event: {error}\") from None",
"new": " except (TypeError, ValueError, OSError) as error:\n raise LookupError(f\"cannot read the GitHub event: {error}\") from None",
"command": "PYTHONPATH=$PWD/src OMP_NUM_THREADS=1 OPENBLAS_NUM_THREADS=1 OMP_WAIT_POLICY=PASSIVE python -m pytest -q -p no:cacheprovider -rf tests/test_track_b_holdout_registry.py tests/test_track_b_holdout_registry_committed.py",
"exit_code": 1,
"failed_tests": [
"tests/test_track_b_holdout_registry.py::test_a_too_deeply_nested_event_raises[pull_request]",
"tests/test_track_b_holdout_registry.py::test_a_too_deeply_nested_event_raises[push]"
]
},
{
"mutation": "a 64-digit zero push boundary falls back without created",
"old": " if event.get(\"created\") is not True:\n",
"new": " if len(before) == 40 and event.get(\"created\") is not True:\n",
"command": "PYTHONPATH=$PWD/src OMP_NUM_THREADS=1 OPENBLAS_NUM_THREADS=1 OMP_WAIT_POLICY=PASSIVE python -m pytest -q -p no:cacheprovider -rf tests/test_track_b_holdout_registry.py tests/test_track_b_holdout_registry_committed.py",
"exit_code": 1,
"failed_tests": [
"tests/test_track_b_holdout_registry.py::test_a_zero_push_boundary_needs_a_created_branch[1-64]",
"tests/test_track_b_holdout_registry.py::test_a_zero_push_boundary_needs_a_created_branch[False-64]",
"tests/test_track_b_holdout_registry.py::test_a_zero_push_boundary_needs_a_created_branch[None-64]",
"tests/test_track_b_holdout_registry.py::test_a_zero_push_boundary_needs_a_created_branch[true-64]"
]
}
]
Expand Down
11 changes: 6 additions & 5 deletions src/populace_dynamics/track_b/holdout_registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1362,11 +1362,12 @@ def _landed_union(

def _event() -> Mapping[str, Any]:
"""The GitHub event payload at ``GITHUB_EVENT_PATH``. Raises
``LookupError`` when it cannot be read or is not a JSON object."""
``LookupError`` when it cannot be read, is nested too deeply to parse,
or is not a JSON object."""
path = os.environ.get("GITHUB_EVENT_PATH")
try:
payload = json.loads(Path(path).read_text(encoding="utf-8"))
except (TypeError, ValueError, OSError) as error:
except (TypeError, ValueError, OSError, RecursionError) as error:
raise LookupError(f"cannot read the GitHub event: {error}") from None
if not isinstance(payload, Mapping):
raise LookupError("the GitHub event is not a JSON object")
Expand All @@ -1389,9 +1390,9 @@ def base_commit(repository: Path) -> str:

Raises ``LookupError`` when none of these resolves, and on a push
whose event cannot be read, whose ``before`` commit does not
resolve, or whose all-zero ``before`` comes without ``created``: a
push is compared with its own boundary, never with a nearer commit
that would check less history."""
resolve, or whose all-zero ``before`` comes without ``created`` set
to true: a push is compared with its own boundary, never with a
nearer commit that would check less history."""
head = _commit(repository, "HEAD")
if head is None:
raise LookupError(f"no HEAD in {repository}")
Expand Down
4 changes: 2 additions & 2 deletions tests/README-tiers.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,9 @@ pytest --collect-only -q -m oracle_policyengine | tail -1

| Tier | Tests at HEAD |
|---|---:|
| `unit` | 18,789 |
| `unit` | 18,795 |
| `artifact` | 4,271 |
| `integration_psid` | 1,471 |
| `reproduction_legacy` | 520 |
| `oracle_policyengine` | 308 |
| **Total** | **25,359** |
| **Total** | **25,365** |
37 changes: 34 additions & 3 deletions tests/test_track_b_holdout_registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2718,18 +2718,20 @@ def test_a_push_compares_with_its_before_commit(
assert registry.base_registry(repository) == middle


@pytest.mark.parametrize("digits", [40, 64])
@pytest.mark.parametrize("created", [None, False, "true", 1])
def test_a_zero_push_boundary_needs_a_created_branch(
tmp_path, no_ci_env, monkeypatch, created
tmp_path, no_ci_env, monkeypatch, created, digits
):
"""GitHub sends an all-zero ``before`` when a push creates its branch,
and says so with ``created: true``. Without that the boundary is
unknown, so the push raises rather than fall back to the merge base,
which would check less history."""
which would check less history. A SHA-256 repository's zero has 64
digits."""
repository = init_repository(tmp_path)
first = registered(["candidate"])
commit_registry(repository, first, "registry")
payload = {"before": "0" * 40}
payload = {"before": "0" * digits}
if created is not None:
payload["created"] = created
event = tmp_path / "event.json"
Expand Down Expand Up @@ -2758,6 +2760,35 @@ def test_an_unset_event_path_raises(
registry.pull_request_head()


@pytest.mark.parametrize("event_name", ["push", "pull_request"])
def test_a_too_deeply_nested_event_raises(
tmp_path, no_ci_env, monkeypatch, event_name
):
"""An event nested too deeply for the JSON parser cannot be read: a
push and a pull request each raise ``LookupError``, never
``RecursionError``, though the payload would otherwise resolve."""
repository = init_repository(tmp_path)
commit_registry(repository, registered(["candidate"]), "registry")
nested = "[" * 200_000 + "]" * 200_000
with pytest.raises(RecursionError):
json.loads(nested)
if event_name == "push":
outer = {"before": "0" * 40, "created": True}
else:
outer = {"pull_request": {"head": {"sha": "a" * 40}}}
event = tmp_path / "event.json"
event.write_text(
json.dumps(outer)[:-1] + ', "deep": ' + nested + "}", encoding="utf-8"
)
monkeypatch.setenv("GITHUB_EVENT_NAME", event_name)
monkeypatch.setenv("GITHUB_EVENT_PATH", str(event))
with pytest.raises(LookupError):
if event_name == "push":
registry.base_commit(repository)
else:
registry.pull_request_head()


@pytest.mark.parametrize(
"payload",
[
Expand Down
2 changes: 1 addition & 1 deletion tests/tier_counts.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"schema_version": 1,
"counts": {
"unit": 18789,
"unit": 18795,
"artifact": 4271,
"integration_psid": 1471,
"reproduction_legacy": 520,
Expand Down
Loading