Repository navigation
chore(deps): update node.js to v24.22.1 - #1044
Merged
Merged
Conversation
24.22.1 is the patched floor for Node 24 in IT's eMudhra certificate check, and machines running it now uninstall older 24.x releases. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Some eMudhra CA certificates were compromised, and 24.22.1 is the first Node 24 release that our internal check treats as patched.
.nvmrcpins 24.21.0, sonvm usehere asks for a version that machines on the patched toolchain no longer have installed.Renovate keeps this pin current and would open the same bump on its next Monday run once 24.22.1 passes the repo's 7-day
minimumReleaseAge. This lands it now. The title matches Renovate's format so its history stays readable.Solution
Bump
.nvmrcfrom 24.21.0 to 24.22.1, keeping the file's lack of a trailing newline.Only
npm-publish.ymlreads.nvmrc(node-version-file). The lint, build and test jobs inmain.yamlusenode-version: 24.x, which already resolves to the latest 24.x on the runner.engines.nodestays>=20.0.0.Tests
No code changes. Locally on Node 24.22.1:
npm ciandnpm run lint(type check and biome) pass. Build and test results are below once they finish.Removed or moved guards
None.
🤖 Generated with Claude Code