Fix language pack validation errors and add a validation workflow - #21
Merged
Merged
Conversation
Email templates: use the variables of the English templates (report_pm_closed, short/report_pm), drop the topic/forum links that exist only in the long templates (short/bookmark, short/topic_notify), and add the missing {U_TOPIC} link (newtopic_notify).
install.php: use %1$s for the installation guide link in INTRODUCTION_BODY and point the documentation links at 3.3 instead of 3.1/3.2. Remove a stray question mark in SUPPORT_BODY.
ucp.php: use the current GPL URL in TERMS_OF_USE_CONTENT and remove a trailing <br /> from PRIVACY_POLICY.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Drop the phpBB Welcome Package link, which the English text no longer has, and replace the mailing-list sentence with the Twitter and Facebook links. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Runs the phpBB Translation Validator (1.6.x) against the official English files of the current stable phpBB 3.3 release on pull requests, pushes to master and weekly. Fails on any fatal or error finding. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
3 tasks done
This was referenced Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@R3gi This PR is part of #14. It replaces #16 (thanks to @janinko for the first draft).
This comes from William Jacoby (bonelifer). The pack came up while the phpbbdocs-hugo documentation translation project was looking for reference language packs.
The
masterbranch fails the phpBB Translation Validator (version 1.6.x, phpBB 3.3.17) with 5 fatal and 4 error findings. This PR fixes all of them. It also adds a workflow that checks the pack on every change.Fixes
report_pm_closed.txtandshort/report_pm.txtnow use the same variables as the English templates.short/bookmark.txtandshort/topic_notify.txt: removed the{U_TOPIC}and{U_FORUM}paragraphs. English has them only in the long templates.newtopic_notify.txt: added the missing{U_TOPIC}paragraph.install.php:INTRODUCTION_BODYuses%1$sfor the link, like English, and not the fixed link../docs/INSTALL.html.SUPPORT_BODYnow matches English: removed the Welcome Package link and a stray?, and added the Twitter and Facebook links.ucp.php: new GPL link inTERMS_OF_USE_CONTENT. Removed an extra<br />at the end ofPRIVACY_POLICY.Result: 0 fatal, 0 error. 20 warnings remain (mostly plural forms and extra links).
Workflow (
.github/workflows/validate.yml)It runs on pull requests, on pushes to
master, once a week, and by hand. It:version.phpbb.com.ext/,language/andstyles/.It needs no secrets and only reads the code. It does not publish anything.
Difference from #16: it uses validator 1.6.x (the
masterbranch supports only phpBB 4.0), the official phpBB zip, and PHP 8.3. It also checksext/andstyles/.A new phpBB 3.3 release can make the weekly run fail until the pack is updated. This is on purpose.
Please note
How it was tested
The workflow ran on GitHub in a fork, on two test branches:
masterand workflow: failed. 5 fatal, 4 error.Not tested yet:
INTRODUCTION_BODYnow uses%1$s, like the English text. The phpBB installer fills it in with the link to the installation guide. Nobody has run the installer in Czech to see the link work.Not done
ucp.phphave fewer paragraphs than English. A Czech speaker should check them.{U_TOPIC}paragraph innewtopic_notify.txtand the Twitter and Facebook sentence inSUPPORT_BODY.README.mdorSECURITY.md. The workflow already leaves them out. To build the zip (czech_<version>.zip), you can use the script in phpbb-release-tools. This is optional. Nothing in this PR needs it.Investigated and written by Claude on behalf of William Jacoby (bonelifer).