Repository navigation
Add audio device listing and selection APIs - #28
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 765f84f3ef
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| }); | ||
| Self { | ||
| sender: Some(sender), | ||
| .spawn(move || native::run(&receiver)) |
There was a problem hiding this comment.
Build the required Windows installer
This new Windows-only audio path has not completed the repository-required packaging validation: the commit’s validation notes explicitly leave the installer build pending in CI. Before treating the feature as complete, run tools/build-windows-installer.ps1 and confirm that it produces a fresh dist\RusticGameEngine-Setup-*.exe; otherwise failures in the Windows integration or installer packaging remain unverified.
AGENTS.md reference: Engine/AGENTS.md:L3-L9
Useful? React with 👍 / 👎.
Scripts can now list and choose audio devices through
Audio.get_output_devices(),get_input_devices(),set_output_device(id), andset_input_device(id)in all language bindings. Lists return opaque IDs and names; passing null chooses the system default.Windows output switching opens the replacement stream before dropping the current stream, preserving playback on failure. Input selection validates and retains a device; microphone capture is not implemented. Headless platforms return empty lists and report unavailable selection. IDs are scene-local snapshots and must be refreshed after another enumeration of the same direction.
Companion website documentation: Rustic-Game-Engine/docs#20
Validation: